From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55851EB64D7 for ; Tue, 20 Jun 2023 23:25:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229916AbjFTXZS (ORCPT ); Tue, 20 Jun 2023 19:25:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229448AbjFTXZP (ORCPT ); Tue, 20 Jun 2023 19:25:15 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F13CE1703 for ; Tue, 20 Jun 2023 16:25:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8A09361382 for ; Tue, 20 Jun 2023 23:25:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC362C433C9; Tue, 20 Jun 2023 23:25:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687303513; bh=vKs3Nn3T/tb9VC69M13qftg8yAfs62GKs6eI5yArd/g=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=h5gLCg7QDfJ81tP2+/Va4XfHxM18mMN55498n2NiTw+wlLeE47Renbz+YpICVh7Pu 7HwHvpMMzlKqGH5VHfEDJd0TxWWVvLFpD0PxnXkKHHhksurtr4o3tIeC0tN0ctUjd2 TWYf5jgsXMdjMY7mfU8NMcWF1mK6u1UwbUd2DYDe93s5lKkVWG+1+pd21v5wS6hzEd nRek0IVVuGsep5lInTahMLflKtF2nnFulQGIgbsM/tkPYXWNRaSgqsjjrCumRPtxqj mWrHQVsfjs52o4Em9fcr0qV0pyzi3/MGBXmTczaXSotOXXzww7ExGPtt7WYt1TtzWJ 91mikawwFt2VQ== Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-4f86e6e4038so3635579e87.0; Tue, 20 Jun 2023 16:25:13 -0700 (PDT) X-Gm-Message-State: AC+VfDz86lk3HuLQ2UsHx4Wafl5ht1m1hvMMru3+OT54EHu1T5EaLgbw 87C70i1WjDTYDSyo8XdxNc/EMrIej8lw1k5C0h4= X-Google-Smtp-Source: ACHHUZ4uR5DEQ8f5ra7Q+/O6bWWssR1OOIHGdmsuiBLVUBsE5Y0ZJwFefrImhfNab17AYlhtRbsnMCBYBbG4Wlixexs= X-Received: by 2002:a05:6512:2346:b0:4f6:1307:80b0 with SMTP id p6-20020a056512234600b004f6130780b0mr7329104lfu.12.1687303511923; Tue, 20 Jun 2023 16:25:11 -0700 (PDT) MIME-Version: 1.0 References: <20230619100121.27534-1-puranjay12@gmail.com> <20230619100121.27534-4-puranjay12@gmail.com> In-Reply-To: <20230619100121.27534-4-puranjay12@gmail.com> From: Song Liu Date: Tue, 20 Jun 2023 16:24:59 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH bpf-next v3 3/3] bpf, arm64: use bpf_jit_binary_pack_alloc To: Puranjay Mohan Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, catalin.marinas@arm.com, mark.rutland@arm.com, bpf@vger.kernel.org, kpsingh@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 19, 2023 at 3:01=E2=80=AFAM Puranjay Mohan wrote: > > Use bpf_jit_binary_pack_alloc for memory management of JIT binaries in > ARM64 BPF JIT. The bpf_jit_binary_pack_alloc creates a pair of RW and RX > buffers. The JIT writes the program into the RW buffer. When the JIT is > done, the program is copied to the final RX buffer > with bpf_jit_binary_pack_finalize. > > Implement bpf_arch_text_copy() and bpf_arch_text_invalidate() for ARM64 > JIT as these functions are required by bpf_jit_binary_pack allocator. > > Signed-off-by: Puranjay Mohan LGTM! Thanks! Acked-by: Song Liu