From: Song Liu <liu.song.a23@gmail.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
shuah@kernel.org, open list <linux-kernel@vger.kernel.org>,
linux-kselftest@vger.kernel.org,
Networking <netdev@vger.kernel.org>
Subject: Re: [PATCH -next] selftests: bpf: remove duplicated include
Date: Fri, 25 Jan 2019 15:01:02 -0800 [thread overview]
Message-ID: <CAPhsuW7_ESxRbM5amk02VmS4=vUORJvD_R3m41=_Cc-kUZQGqw@mail.gmail.com> (raw)
In-Reply-To: <20190125024634.14580-1-yuehaibing@huawei.com>
On Thu, Jan 24, 2019 at 6:49 PM YueHaibing <yuehaibing@huawei.com> wrote:
>
> Remove duplicated include.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Song Liu <songliubraving@fb.com>
Thanks!
> ---
> tools/testing/selftests/bpf/test_flow_dissector.c | 2 --
> tools/testing/selftests/bpf/test_maps.c | 1 -
> tools/testing/selftests/bpf/test_sockmap.c | 1 -
> 3 files changed, 4 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/test_flow_dissector.c b/tools/testing/selftests/bpf/test_flow_dissector.c
> index 12b784a..01f0c63 100644
> --- a/tools/testing/selftests/bpf/test_flow_dissector.c
> +++ b/tools/testing/selftests/bpf/test_flow_dissector.c
> @@ -16,7 +16,6 @@
> #include <errno.h>
> #include <linux/if_packet.h>
> #include <linux/if_ether.h>
> -#include <linux/if_packet.h>
> #include <linux/ipv6.h>
> #include <netinet/ip.h>
> #include <netinet/in.h>
> @@ -25,7 +24,6 @@
> #include <stdbool.h>
> #include <stdlib.h>
> #include <stdio.h>
> -#include <stdlib.h>
> #include <string.h>
> #include <sys/ioctl.h>
> #include <sys/socket.h>
> diff --git a/tools/testing/selftests/bpf/test_maps.c b/tools/testing/selftests/bpf/test_maps.c
> index e2b9eee..1dfef77 100644
> --- a/tools/testing/selftests/bpf/test_maps.c
> +++ b/tools/testing/selftests/bpf/test_maps.c
> @@ -633,7 +633,6 @@ static void test_stackmap(int task, void *data)
> close(fd);
> }
>
> -#include <sys/socket.h>
> #include <sys/ioctl.h>
> #include <arpa/inet.h>
> #include <sys/select.h>
> diff --git a/tools/testing/selftests/bpf/test_sockmap.c b/tools/testing/selftests/bpf/test_sockmap.c
> index e85a771..3845144 100644
> --- a/tools/testing/selftests/bpf/test_sockmap.c
> +++ b/tools/testing/selftests/bpf/test_sockmap.c
> @@ -10,7 +10,6 @@
> #include <unistd.h>
> #include <string.h>
> #include <errno.h>
> -#include <sys/ioctl.h>
> #include <stdbool.h>
> #include <signal.h>
> #include <fcntl.h>
> --
> 2.7.0
>
>
next prev parent reply other threads:[~2019-01-25 23:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 2:46 [PATCH -next] selftests: bpf: remove duplicated include YueHaibing
2019-01-25 23:01 ` Song Liu [this message]
2019-01-28 23:25 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPhsuW7_ESxRbM5amk02VmS4=vUORJvD_R3m41=_Cc-kUZQGqw@mail.gmail.com' \
--to=liu.song.a23@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).