Re: [Outreachy kernel] [PATCH v2] staging: rtl8723bs: hal: Remove camelcase in Hal8723BReg.h

From: FMDF <fmdefrancesco@gmail.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	outreachy-kernel@googlegroups.com, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [Outreachy kernel] [PATCH v2] staging: rtl8723bs: hal: Remove camelcase in Hal8723BReg.h
Date: Tue, 6 Apr 2021 17:05:09 +0200	[thread overview]
Message-ID: <CAPj211uct7K7e2Kcz7drmWGcfuTRQYTWHFRvrA9ah-JmBTotsg@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2104061652590.2882@hadrien>

On Tue, Apr 6, 2021 at 4:55 PM Julia Lawall <julia.lawall@inria.fr> wrote:
>
>
>
> On Tue, 6 Apr 2021, FMDF wrote:
>
> > On Tue, Apr 6, 2021 at 4:11 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> > >
> > > On Tue, Apr 06, 2021 at 03:05:56PM +0200, Fabio M. De Francesco wrote:
> > > > Remove camelcase in some symbols defined in Hal8723BReg.h. These symbols
> > > > are not used anywhere else, therefore this patch does not break the driver.
> > > >
> > > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > > > ---
> > > >  drivers/staging/rtl8723bs/hal/Hal8723BReg.h | 16 ++++++++--------
> > > >  1 file changed, 8 insertions(+), 8 deletions(-)
> > >
> > > If this is "v2", you need to put below the --- line what changed from
> > > v1.
> >
> > It is a v2 only because you made me notice that I forgot to cc
> > linux-staging and linux-kernel.
> > So I sent it again, but probably I shouldn't have changed the version
> > number because nothing else had changed.
> >
> > > Please fix up and send a v3.
> > >
> >
> > No problem at all. I can explain in the patch v3 what I wrote above.
> > May you please confirm that a patch v3 is the correct solution even
> > when nothing changes in the code?
>
> When Greg acknowledges your patch, everyone who is concerned with the
> patch should see it.  So he needs to pick up the right version of the
> patch that has everyone in CC.  He can use the version number to choose
> the most recent one.
>
> The version numbers don't appear anywhere once the code is committed.  So
> it's not a problem to move up to the next version for any reason.  On the
> other hand, if you skip a version, it can be a problem, because someone
> may wonder if they missed some useful information.
>
> julia
>

Thanks for your clear explanation of these details of the workflow,

Fabio

> >
> > Thanks for your help,
> >
> > Fabio
> >
> > > thanks,
> > >
> > > greg k-h
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAPj211u9MHgtjeZGUPsLxU3HkbJ8cr2EUL0v9HA7LE9-b1uUoA%40mail.gmail.com.
> >