From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752423AbbCXWud (ORCPT <rfc822;w@1wt.eu>);
	Tue, 24 Mar 2015 18:50:33 -0400
Received: from mail-wg0-f44.google.com ([74.125.82.44]:33323 "EHLO
	mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752293AbbCXWu3 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 24 Mar 2015 18:50:29 -0400
MIME-Version: 1.0
X-Originating-IP: [213.205.194.55]
In-Reply-To: <1427213239-8775-1-git-send-email-kraxel@redhat.com>
References: <1427213239-8775-1-git-send-email-kraxel@redhat.com>
Date: Tue, 24 Mar 2015 22:50:28 +0000
Message-ID: <CAPj87rN4pXHukDRD-e=ZrO1hcts04cSz1Hr9TNAgicGVWE5_-Q@mail.gmail.com>
Subject: Re: [PATCH] Add virtio gpu driver.
From: Daniel Stone <daniel@fooishbar.org>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: virtio-dev@lists.oasis-open.org, "Michael S. Tsirkin" <mst@redhat.com>,
        "open list:ABI/API" <linux-api@vger.kernel.org>,
        Rusty Russell <rusty@rustcorp.com.au>,
        open list <linux-kernel@vger.kernel.org>,
        "open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
        "open list:VIRTIO CORE, NET..." 
	<virtualization@lists.linux-foundation.org>,
        Dave Airlie <airlied@redhat.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On 24 March 2015 at 16:07, Gerd Hoffmann <kraxel@redhat.com> wrote:
> +static int virtio_gpu_crtc_page_flip(struct drm_crtc *crtc,
> +                                    struct drm_framebuffer *fb,
> +                                    struct drm_pending_vblank_event *event,
> +                                    uint32_t flags)
> +{
> +       return -EINVAL;
> +}

I'm not going to lie, I was really hoping the 5th (?) GPU option for
Qemu would support pageflipping. Daniel's comment about conversion to
atomic is relevant, but: do you have a mechanism which allows you to
post updates (e.g. 'start displaying this buffer now please') that
allows you to get events back when they have actually been displayed?

Cheers,
Daniel