From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752156AbcHFUwo (ORCPT ); Sat, 6 Aug 2016 16:52:44 -0400 Received: from mail-lf0-f42.google.com ([209.85.215.42]:34140 "EHLO mail-lf0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751699AbcHFUwn (ORCPT ); Sat, 6 Aug 2016 16:52:43 -0400 MIME-Version: 1.0 In-Reply-To: <1469196645-3061-3-git-send-email-tomeu.vizoso@collabora.com> References: <1469196645-3061-1-git-send-email-tomeu.vizoso@collabora.com> <1469196645-3061-3-git-send-email-tomeu.vizoso@collabora.com> From: Daniel Stone Date: Sat, 6 Aug 2016 18:04:06 +0100 Message-ID: Subject: Re: [PATCH v3 2/3] drm: Add API for capturing frame CRCs To: Tomeu Vizoso Cc: Linux Kernel Mailing List , linux-doc@vger.kernel.org, Jonathan Corbet , dri-devel , Daniel Vetter , Emil Velikov Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tomeu, On 22 July 2016 at 15:10, Tomeu Vizoso wrote: > +/** > + * DOC: CRC ABI > + * > + * DRM device drivers can provide to userspace CRC information of each frame as > + * it reached a given hardware component (a "source"). > + * > + * Userspace can control generation of CRCs in a given CRTC by writing to the s/can/must/ Is it worth having 'auto' as a default source perhaps? > + * file dri/0/crtc-N/crc/control in debugfs, with N being the index of the CRTC. > + * Accepted values are source names (which are driver-specific) and the "none" > + * and "auto" keywords. "none" will disable CRC generation and "auto" will let > + * the driver select a default source of frame CRCs for this CRTC. Is it also worth having 'connector-%s' (named as per sysfs, e.g. connector-HDMI-A-0) as a standardised entry, for cloneable CRTCs which have CRC control on the connector rather than the CRTC? Cheers, Daniel