From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 069A2C46466 for ; Tue, 6 Oct 2020 07:01:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A46C820796 for ; Tue, 6 Oct 2020 07:01:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=antmicro.com header.i=@antmicro.com header.b="W84ohUHy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727162AbgJFHBF (ORCPT ); Tue, 6 Oct 2020 03:01:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727038AbgJFHBF (ORCPT ); Tue, 6 Oct 2020 03:01:05 -0400 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44881C0613D2 for ; Tue, 6 Oct 2020 00:01:05 -0700 (PDT) Received: by mail-pl1-x643.google.com with SMTP id o8so753749pll.4 for ; Tue, 06 Oct 2020 00:01:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=antmicro.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kLnvcGYBW3K2JHWzUc8H3P/mWmh3X6aiUW1vORxEEk4=; b=W84ohUHypmj3DBg8s+ZzDXVQ6kA9mRdTcNoOJkgWPvlicW1CRh+p6VASoV6JT9Lof9 i2cFX/BdUq1zT+mw/h/8Ekqn69vAzwwDDNWpfSbgbn/hJyJm19TP6hXUliGSLVEYqPmx 9I9pymggsZ2W2CFEInZUD22uUVY+3ty6L24Lk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kLnvcGYBW3K2JHWzUc8H3P/mWmh3X6aiUW1vORxEEk4=; b=h6NGxlZz/ZII1BEI4MqDcrsx7sqo9izOd7IBwLjbK8OwdvEN2ekVPysDTNURnD+jYL izyx0Y4loa5HunWmqbCjcYrPQhxLpHymXUtJIRjNEU4yy/AcoSBKNBrpEqpJ+ZurVzKZ DYudGnkkmUeTmFzkwJxXKYtvq3JVldGNnm/HhxfNB0nGmFJvfTR9CmO9/4XcyyiK7rd3 +dKO//GuI5i/o8hpfEwr6RESr5yTEMiJUo5FXIqiUl4mjj0dpCPkL4x3OWZjpoS88+l5 xbje4yks9WYwkMV0vcBcRcNgdyBpRsrferWHiDd/3xzimFK+1EuEUJU5zJs+Y+tZW9Tb f5IA== X-Gm-Message-State: AOAM531X8HLEVuqENXlY6TWJOeklzZGMULg3817EjKroe5/CLy2lMxfj k7SKltygdMBep9pc57h6SVk/oWqhjZYgXKiLoQGG0w== X-Google-Smtp-Source: ABdhPJyB29qLcQldVmQot4jqrKIxicdkoymtFIjYVQcSuxZVdPXQi6caH4F8RSL3X0MepZkQzzu/+MNsEK9FUgO7seU= X-Received: by 2002:a17:902:9347:b029:d3:b2c6:1500 with SMTP id g7-20020a1709029347b02900d3b2c61500mr2057414plp.5.1601967664699; Tue, 06 Oct 2020 00:01:04 -0700 (PDT) MIME-Version: 1.0 References: <20200923120817.1667149-0-mholenko@antmicro.com> <20200923120817.1667149-4-mholenko@antmicro.com> In-Reply-To: From: Mateusz Holenko Date: Tue, 6 Oct 2020 09:00:52 +0200 Message-ID: Subject: Re: [PATCH v11 4/5] dt-bindings: serial: document LiteUART bindings To: Geert Uytterhoeven Cc: Rob Herring , Mark Rutland , Greg Kroah-Hartman , Jiri Slaby , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:SERIAL DRIVERS" , Stafford Horne , Karol Gugala , Mauro Carvalho Chehab , "David S. Miller" , "Paul E. McKenney" , Filip Kokosinski , Pawel Czarnecki , Joel Stanley , Jonathan Cameron , Maxime Ripard , Shawn Guo , Heiko Stuebner , Sam Ravnborg , Icenowy Zheng , Laurent Pinchart , Linux Kernel Mailing List , "Gabriel L. Somlo" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, On Fri, Sep 25, 2020 at 3:16 PM Geert Uytterhoeven wrote: > > Hi Mateusz, > > On Wed, Sep 23, 2020 at 12:10 PM Mateusz Holenko wrote: > > From: Filip Kokosinski > > > > Add documentation for LiteUART devicetree bindings. > > > > Signed-off-by: Filip Kokosinski > > Signed-off-by: Mateusz Holenko > > Reviewed-by: Rob Herring > > Thanks for your patch! Thanks for your review! > > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/serial/litex,liteuart.yaml > > @@ -0,0 +1,38 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > + > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/serial/litex,liteuart.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: LiteUART serial controller > > + > > +maintainers: > > + - Karol Gugala > > + - Mateusz Holenko > > + > > +description: | > > + LiteUART serial controller is a part of LiteX FPGA SoC builder. It supports > > part of the Right, will fix that. > > + multiple CPU architectures, currently including e.g. OpenRISC and RISC-V. > > + > > +properties: > > + compatible: > > + const: litex,liteuart > > Have you already decided how to handle future LiteUART variants that add > new features (e.g. CTS/RTS, DMA)? We were thinking of adding KConfig options, like [ ] LiteUART serial port support < > LiteUART DMA support and using ifdefs in the code. The other option could be to extend LiteX itself so that the UART core provides information about its configuration via the capabilities register. That way the driver could configure itself automatically at runtime. This is, however, not decided yet. > > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + > > +examples: > > + - | > > + uart0: serial@e0001800 { > > + compatible = "litex,liteuart"; > > + reg = <0xe0001800 0x100>; > > + interrupts = <2>; > > + }; > > -- > > 2.25.1 > > > > > -- > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds Best regards, Mateusz -- Mateusz Holenko Antmicro Ltd | www.antmicro.com Roosevelta 22, 60-829 Poznan, Poland