From: Simon Glass <sjg@chromium.org>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: Matthias Brugger <mbrugger@suse.com>,
U-Boot Mailing List <u-boot@lists.denx.de>,
Bin Meng <bmeng.cn@gmail.com>, Marek Vasut <marex@denx.de>,
lk <linux-kernel@vger.kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Mark Kettenis <mark.kettenis@xs4all.nl>
Subject: Re: [PATCH v4 4/5] dm: pci: Assign controller device node to root bridge
Date: Tue, 16 Jun 2020 07:43:57 -0600 [thread overview]
Message-ID: <CAPnjgZ2jarQArKN=0h0mNnxE7gAL0juvGhMxMF4a0CehqxWcRw@mail.gmail.com> (raw)
In-Reply-To: <20200612164632.25648-5-nsaenzjulienne@suse.de>
Hi Nicolas,
On Fri, 12 Jun 2020 at 10:47, Nicolas Saenz Julienne
<nsaenzjulienne@suse.de> wrote:
>
> There is no distinction in DT between the PCI controller device and the
> root bridge, whereas such distinction exists from dm's perspective. Make
> sure the root bridge ofnode is assigned to the controller's platform
> device node.
>
> This permits setups like this to work correctly:
>
> pcie {
> compatible = "...";
> ...
> dev {
> reg = <0 0 0 0 0>;
> ...
> };
> };
>
> Without this the dev node is assigned to the root bridge and the
> actual device search starts one level lower than expected.
>
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> ---
> drivers/pci/pci-uclass.c | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
Can you update the tests to handle this case please?
Regards,
Simon
next prev parent reply other threads:[~2020-06-16 13:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 16:46 [PATCH v4 0/5] usb: xhci: Load Raspberry Pi 4 VL805's firmware Nicolas Saenz Julienne
2020-06-12 16:46 ` [PATCH v4 1/5] arm: rpi: Add function to trigger VL805's firmware load Nicolas Saenz Julienne
2020-06-12 16:46 ` [PATCH v4 2/5] reset: Add Raspberry Pi 4 firmware reset controller Nicolas Saenz Julienne
2020-06-12 16:46 ` [PATCH v4 3/5] configs: Enable support for reset controllers on RPi4 Nicolas Saenz Julienne
2020-06-12 16:46 ` [PATCH v4 4/5] dm: pci: Assign controller device node to root bridge Nicolas Saenz Julienne
2020-06-16 13:43 ` Simon Glass [this message]
2020-06-16 14:09 ` Nicolas Saenz Julienne
2020-06-16 23:31 ` Simon Glass
2020-06-17 19:15 ` Nicolas Saenz Julienne
2020-06-26 1:12 ` Simon Glass
2020-06-12 16:46 ` [PATCH v4 5/5] usb: xhci-pci: Add reset controller support Nicolas Saenz Julienne
2020-06-12 17:08 ` Marek Vasut
2020-06-15 8:56 ` Nicolas Saenz Julienne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPnjgZ2jarQArKN=0h0mNnxE7gAL0juvGhMxMF4a0CehqxWcRw@mail.gmail.com' \
--to=sjg@chromium.org \
--cc=bmeng.cn@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=marex@denx.de \
--cc=mark.kettenis@xs4all.nl \
--cc=mbrugger@suse.com \
--cc=nsaenzjulienne@suse.de \
--cc=s.nawrocki@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).