From: Robin Holt <robinmholt@gmail.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Cliff Whickman <cpw@sgi.com>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Kees Cook <keescook@chromium.org>
Subject: Re: [sgi-xp] Missing break or false positive?
Date: Wed, 20 Mar 2019 10:23:09 -0500 [thread overview]
Message-ID: <CAPp3RGpDZ1oNBOCfizjyrQvp6yGqS89iB_QkjRRqL4FAfZRTXg@mail.gmail.com> (raw)
In-Reply-To: <480940a4-1b7c-564e-2921-37c5b7e0a5b9@embeddedor.com>
I am sorry for my delayed response. I missed the earlier email.
On Wed, Mar 20, 2019 at 9:37 AM Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
>
...
> > I'm taking a look into the following piece of code in drivers/misc/sgi-xp/xpc_uv.c:
...
> > and I'm trying to figure out if the following warning is due to a missing break
> > at the end of the case, or if this is just a false positive and a /* fall through */
> > annotation should be added:
The fall-through is by design. The protocol previously had a windows
of failure where a connection
could be in the process of being established and a failure could be
detected prior to the
handling of the establishment message. I added the new open complete
message and leveraged
the fall-through to mark the connection established.
Please let me know if you do not intend to submit a patch for this.
Thank you,
Robin Holt
next prev parent reply other threads:[~2019-03-20 15:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 4:24 [sgi-xp] Missing break or false positive? Gustavo A. R. Silva
2019-03-20 14:37 ` Gustavo A. R. Silva
2019-03-20 15:23 ` Robin Holt [this message]
2019-03-20 15:36 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPp3RGpDZ1oNBOCfizjyrQvp6yGqS89iB_QkjRRqL4FAfZRTXg@mail.gmail.com \
--to=robinmholt@gmail.com \
--cc=arnd@arndb.de \
--cc=cpw@sgi.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@embeddedor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).