From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759295AbcLUQYQ (ORCPT ); Wed, 21 Dec 2016 11:24:16 -0500 Received: from mail-oi0-f67.google.com ([209.85.218.67]:33503 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751294AbcLUQYP (ORCPT ); Wed, 21 Dec 2016 11:24:15 -0500 MIME-Version: 1.0 In-Reply-To: <20161217010127.GA140378@beast> References: <20161217010127.GA140378@beast> From: Robin Holt Date: Wed, 21 Dec 2016 10:24:14 -0600 Message-ID: Subject: Re: [PATCH] sgi-xp: use designated initializers To: Kees Cook Cc: LKML , Cliff Whickman Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 16, 2016 at 7:01 PM, Kees Cook wrote: > Prepare to mark sensitive kernel structures for randomization by making > sure they're using designated initializers. These were identified during > allyesconfig builds of x86, arm, and arm64, with most initializer fixes > extracted from grsecurity. I guess I don't understand the context enough here to give you a Signed-off-by. Can you give us more background on this randomization? >>From what I see in the code here, I can see you are providing equivalent functionality and I would give it a signed-off-by, but I am not sure this randomization of which you speak is not going to cause problems for XP, XPC, XPNET, and XPMEM (out of tree GPL kernel module). Robin