From: Jian-Hong Pan <jian-hong@endlessm.com>
To: Kailang Yang <kailang@realtek.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Hui Wang <hui.wang@canonical.com>,
alsa-devel@alsa-project.org,
Linux Kernel <linux-kernel@vger.kernel.org>,
Linux Upstreaming Team <linux@endlessm.com>,
Daniel Drake <drake@endlessm.com>
Subject: Re: [PATCH v2 2/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX533FD with ALC294
Date: Fri, 7 Dec 2018 11:48:08 +0800 [thread overview]
Message-ID: <CAPpJ_ed36NyopArw98qhkstAm=L9A4=xiLPaa2ju0+qMR0tE9Q@mail.gmail.com> (raw)
In-Reply-To: <6FAB7C47BCF00940BB0999A99BE3547A18420211@RTITMBSV02.realtek.com.tw>
Kailang <kailang@realtek.com> 於 2018年12月7日 週五 上午11:32寫道:
>
> Hi Jian Hong,
>
> Could I know who give you the value as below?
>
> + { 0x20, AC_VERB_SET_COEF_INDEX, 0x10 },
> + { 0x20, 0x4c4, 0x20 },
> + { 0x20, AC_VERB_SET_COEF_INDEX, 0x40 },
> + { 0x20, 0x488, 0x00 },
A module maker.
Regards,
Jian-Hong Pan
> -----Original Message-----
> From: Jian-Hong Pan <jian-hong@endlessm.com>
> Sent: Thursday, December 6, 2018 4:46 PM
> To: Jaroslav Kysela <perex@perex.cz>; Takashi Iwai <tiwai@suse.com>; Kailang <kailang@realtek.com>
> Cc: Hui Wang <hui.wang@canonical.com>; alsa-devel@alsa-project.org; linux-kernel@vger.kernel.org; linux@endlessm.com; Jian-Hong Pan <jian-hong@endlessm.com>; Daniel Drake <drake@endlessm.com>
> Subject: [PATCH v2 2/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX533FD with ALC294
>
> The ASUS UX533FD with ALC294 cannot detect the headset MIC and output through the internal speaker and the headphone until ALC294_FIXUP_ASUS_SPK_NOISE quirk applied.
>
> Signed-off-by: Daniel Drake <drake@endlessm.com>
> Signed-off-by: Jian-Hong Pan <jian-hong@endlessm.com>
> ---
> v2:
> - Modify the HDA verbs for UX333FA support
> - Make a new ALC294_FIXUP_ASUS_HEADSET_MIC quirk for ALC294 chain
> - .chain_id = ALC256_FIXUP_ASUS_HEADSET_MODE ==> change to ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC
>
> sound/pci/hda/patch_realtek.c | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index d32e50b1ed60..1525bcdf96e8 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -5518,6 +5518,8 @@ enum {
> ALC295_FIXUP_HP_AUTO_MUTE,
> ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE,
> ALC294_FIXUP_ASUS_MIC,
> + ALC294_FIXUP_ASUS_HEADSET_MIC,
> + ALC294_FIXUP_ASUS_SPK_NOISE,
> };
>
> static const struct hda_fixup alc269_fixups[] = { @@ -6414,6 +6416,28 @@ static const struct hda_fixup alc269_fixups[] = {
> .chained = true,
> .chain_id = ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC
> },
> + [ALC294_FIXUP_ASUS_HEADSET_MIC] = {
> + .type = HDA_FIXUP_PINS,
> + .v.pins = (const struct hda_pintbl[]) {
> + { 0x19, 0x01a1113c }, /* use as headset mic, without its own jack detect */
> + { }
> + },
> + .chained = true,
> + .chain_id = ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC
> + },
> + [ALC294_FIXUP_ASUS_SPK_NOISE] = {
> + .type = HDA_FIXUP_VERBS,
> + .v.verbs = (const struct hda_verb[]) {
> + /* Set EAPD high */
> + { 0x20, AC_VERB_SET_COEF_INDEX, 0x10 },
> + { 0x20, 0x4c4, 0x20 },
> + { 0x20, AC_VERB_SET_COEF_INDEX, 0x40 },
> + { 0x20, 0x488, 0x00 },
> + { }
> + },
> + .chained = true,
> + .chain_id = ALC294_FIXUP_ASUS_HEADSET_MIC
> + },
> };
>
> static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -6556,6 +6580,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x1043, 0x12e0, "ASUS X541SA", ALC256_FIXUP_ASUS_MIC),
> SND_PCI_QUIRK(0x1043, 0x13b0, "ASUS Z550SA", ALC256_FIXUP_ASUS_MIC),
> SND_PCI_QUIRK(0x1043, 0x1427, "Asus Zenbook UX31E", ALC269VB_FIXUP_ASUS_ZENBOOK),
> + SND_PCI_QUIRK(0x1043, 0x14a1, "ASUS UX533FD",
> +ALC294_FIXUP_ASUS_SPK_NOISE),
> SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A),
> SND_PCI_QUIRK(0x1043, 0x16e3, "ASUS UX50", ALC269_FIXUP_STEREO_DMIC),
> SND_PCI_QUIRK(0x1043, 0x1a13, "Asus G73Jw", ALC269_FIXUP_ASUS_G73JW),
> --
> 2.11.0
>
next prev parent reply other threads:[~2018-12-07 3:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 7:42 [PATCH 0/3] Add ALC294 quirks for ASUS laptops Jian-Hong Pan
2018-12-05 7:42 ` [PATCH 1/3] ALSA: hda/realtek: ALC294 mic and headset-mode fixups for ASUS X542UN Jian-Hong Pan
2018-12-05 8:36 ` Kailang
2018-12-05 9:33 ` Jian-Hong Pan
2018-12-05 11:42 ` Kailang
2018-12-06 8:44 ` Jian-Hong Pan
2018-12-06 8:45 ` [PATCH v2 0/3] Add ALC294 quirks for ASUS laptops Jian-Hong Pan
2018-12-06 8:45 ` [PATCH v2 1/3] ALSA: hda/realtek: ALC294 mic and headset-mode fixups for ASUS X542UN Jian-Hong Pan
2018-12-06 8:45 ` [PATCH v2 2/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX533FD with ALC294 Jian-Hong Pan
2018-12-07 3:31 ` Kailang
2018-12-07 3:48 ` Jian-Hong Pan [this message]
2018-12-07 6:52 ` Kailang
2018-12-07 9:13 ` Jian-Hong Pan
2018-12-07 9:17 ` [PATCH v3 0/3] Add ALC294 quirks for ASUS laptops Jian-Hong Pan
2018-12-07 9:17 ` [PATCH v3 1/3] ALSA: hda/realtek: ALC294 mic and headset-mode fixups for ASUS X542UN Jian-Hong Pan
2018-12-07 9:17 ` [PATCH v3 2/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX533FD with ALC294 Jian-Hong Pan
2018-12-07 9:17 ` [PATCH v3 3/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX433FN/UX333FA " Jian-Hong Pan
2018-12-10 10:27 ` [PATCH v3 0/3] Add ALC294 quirks for ASUS laptops Takashi Iwai
2018-12-06 8:45 ` [PATCH v2 3/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX433FN/UX333FA with ALC294 Jian-Hong Pan
2018-12-05 7:42 ` [PATCH 2/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX533FD " Jian-Hong Pan
2018-12-05 7:42 ` [PATCH 3/3] ALSA: hda/realtek: Enable audio jacks of ASUS UX433FN " Jian-Hong Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPpJ_ed36NyopArw98qhkstAm=L9A4=xiLPaa2ju0+qMR0tE9Q@mail.gmail.com' \
--to=jian-hong@endlessm.com \
--cc=alsa-devel@alsa-project.org \
--cc=drake@endlessm.com \
--cc=hui.wang@canonical.com \
--cc=kailang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@endlessm.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).