From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D274C43334 for ; Fri, 17 Jun 2022 15:28:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1383096AbiFQP2p (ORCPT ); Fri, 17 Jun 2022 11:28:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1382909AbiFQP2c (ORCPT ); Fri, 17 Jun 2022 11:28:32 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD43937BDD for ; Fri, 17 Jun 2022 08:28:29 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id cn20so6649590edb.6 for ; Fri, 17 Jun 2022 08:28:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dneg.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WPVSEvTCvflFVWW5j2J0ixJtMAaP9wSf1jUduymLlc0=; b=v7RXMWZyuWDlLd2v5s/ooA/1Btk4V0x78HXw7Xm7i33Wi4KPyENUDcJieRtSDHdqXF y0CguHXlfnWbXj9NHraQ6rewV/+kAKdVxVFcsWohBz4cMSu/XJIxbWcQgFbjOEonH3m9 x0hV49Il2On30MIL5DdT4BGZWralIS3PVPDN2i9lIVxw1wD8EcFvpyfh6Cl/cm6vZzJ6 PL9+Opn3M4m129911zb6XlvplLpltIWORVUm8OXUH2JZIdv6k51S4jV3FKqR0udjmP8z EUCtnQ5UquCW9dfEm1dEWgXhrSK9gx16akUcJ0URmOTwbS6E87UTFqfUUq9H3KW4bcKl wXPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WPVSEvTCvflFVWW5j2J0ixJtMAaP9wSf1jUduymLlc0=; b=22aJv3wHBs3bes8EZ5TPIYf/6DixniA8CSqCZ/XtaEE7vHGhUUX4iXDrRbVRS1BwJP SOAXH7ng2Ilb3HY8hKrk/s9Y1rlj+Hp3FH42WVHhXMmrvusPPHTK25kpXbx6WEATDCFN wJgNJuBxjbPzzuJ5DWuLdz2Ii9XkNoVA4PPy0xqSKeJ9tVZM3+vyi7Ho3iiibTH1ZIoX s9d7CFHPOyrCK4hMlPf1hCJNU3e1hEFOwE1CG8HdilASX0t1nb3NoRLpjEG7GL1pyQ2S zziz4eHf1R8DV92LsDuZ3BtPKef/qFo1r7yg/4kT9BRu4KzSvZ+zO7UEkPGtY7GRsURx jlLQ== X-Gm-Message-State: AJIora9L6FkR4eqpnqbDpLNoQafz3tGmPaQi32HsX8Kc3l8aMbjmpdEm +R6agNT/V4RqXbMdUwr7n8ao2sBnOZF0qJm7rGydsw== X-Google-Smtp-Source: AGRyM1vEi6r6fYhd5rEyG/Oo+64RdkJiqOkUizhd0wgddNSc0WlzPxLW8/Jzu4daDxPaJij9IyK5BeX6kcGkf4WPg5E= X-Received: by 2002:aa7:cf01:0:b0:435:5ace:69cc with SMTP id a1-20020aa7cf01000000b004355ace69ccmr6151037edy.251.1655479708477; Fri, 17 Jun 2022 08:28:28 -0700 (PDT) MIME-Version: 1.0 References: <165516173293.21248.14587048046993234326.stgit@noble.brown> <165534094600.26404.4349155093299535793@noble.neil.brown.name> <165544498126.26404.7712330810213588882@noble.neil.brown.name> In-Reply-To: <165544498126.26404.7712330810213588882@noble.neil.brown.name> From: Daire Byrne Date: Fri, 17 Jun 2022 16:27:52 +0100 Message-ID: Subject: Re: [PATCH RFC 00/12] Allow concurrent directory updates. To: NeilBrown Cc: Anna Schumaker , Al Viro , Trond Myklebust , Chuck Lever , Linux NFS Mailing List , linux-fsdevel@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 17 Jun 2022 at 06:49, NeilBrown wrote: > > On Thu, 16 Jun 2022, Daire Byrne wrote: > > > > I double checked that the patch had been applied and I hadn't made a > > mistake with installation. > > :-) always worth double checking... > > > > > I could perhaps try running with just the VFS patches to see if I can > > still reproduce the "local" VFS hang without the nfsd patches? Your > > previous VFS only patchset was stable for me. > > I've made quite a few changes since that VFS-only patches. Almost > certainly the problem is not in the nfsd code. > > I think that following has a reasonable chance of making things better, > both for the problem you hit and the problem Anna hit. I haven't tested > it at all yet so no promises - up to you if you try it. > > Thanks to both of you for the help with testing. > > NeilBrown This patch does the job for me - no more stack traces and things have been stable all day. I'm going to run some production loads over the weekend and then I'll do some more artificial scale testing next week. Thanks again for this work! Improving the parallelism anywhere we can for single clients and then nfsd is great for reexport servers (especially once you add some "cloud" latency). Cheers, Daire