From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C0F9C433DF for ; Tue, 21 Jul 2020 10:40:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 598DE20714 for ; Tue, 21 Jul 2020 10:40:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GUZPnTeD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729169AbgGUKkW (ORCPT ); Tue, 21 Jul 2020 06:40:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728210AbgGUKkV (ORCPT ); Tue, 21 Jul 2020 06:40:21 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42AC6C061794; Tue, 21 Jul 2020 03:40:21 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id j18so2324079wmi.3; Tue, 21 Jul 2020 03:40:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/hrwegn9jIZlfwVSBJg2Q9e2hdiS+7p2jeJiI2B1tZg=; b=GUZPnTeD2J8NqDSP9WWLzmOQJngE2JShWf5MnBF9DhXIO/nlj0hJgKgpsEtvY5gEbT RCsYzV5kY8oVxrlmD95NjoEa0D8dZhsUismEAoQ3/sm0kJ47GRMw9iDejtWbEyoyfS60 9YrWiHDKQkR9dyIB67BVyHXal3r4JKDYxEdyMqK6H5Fvel4goKQwe0ILREBJzKfsD4IL oddpaPTwduKzajzjyV05JLwl+s0+et5ixn79RXRh9EI82rglF6wwQrOLezuDOr+e8Stf azffswxDOcsC65h6P/eNXvi0ziU7FCHgS/2xFoF7c6qyO3lb+LIBxEEpvoNumaetTZ2I 7BrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/hrwegn9jIZlfwVSBJg2Q9e2hdiS+7p2jeJiI2B1tZg=; b=tvJLqUog5yC9SD1jEBZU0qhftR1sQcQeGbgUSCmRx0znMoj5+8YGkt3PAOQqbiPbYB cikrsLd0HEpeWoCqoxlZKIOSIiE+vRnmz8h+745JxE0fGZf3zK1/EtkEIre1UWYSuAAV 2mij26bD8ExQrZ4MZXyQkqST7DFAD5eZ+UMK307uCUEw0BLn/zE6wed3Q+2RKZNaKj4A q2pmenLgTx/QSDl+IOpoTeDyZVkXTSMml4xRNEHLw3gIOk3fE4naT/uwunR+P3cEUEN5 r3Ytbscghp27LD25YF8/KQbO97wmmCcJun166X2tnYIvpTuvoTH52kK6Zquu/CQ+Vl+N yOYQ== X-Gm-Message-State: AOAM532cxc40DNGCt/xn989Sb4Znxb6u2FIocv68KZYdaaotYTGL2WQd G219KAo8s6NEwIw7Cduf3raiFrW5izbrpj8n3fARAKn5WKPBsw== X-Google-Smtp-Source: ABdhPJyT/1LtNdoeP9Cg9cvSP4SEo5TegkCuPatOEblBQakvVJOOQBQ9X5N76GvU79QNd1w1mkIoxMmbdiwNl8D/88w= X-Received: by 2002:a7b:c921:: with SMTP id h1mr3228394wml.29.1595328020057; Tue, 21 Jul 2020 03:40:20 -0700 (PDT) MIME-Version: 1.0 References: <20200721082128.GE1655283@kroah.com> In-Reply-To: <20200721082128.GE1655283@kroah.com> From: ivan Date: Tue, 21 Jul 2020 18:40:08 +0800 Message-ID: Subject: Re: [PATCH v5 4/4] power: supply: core: property to control reverse charge To: Greg KH Cc: sre@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, jiangfei1@xiaomi.com, Qiwu Huang Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 21, 2020 at 4:21 PM Greg KH wrote: > > On Tue, Jul 21, 2020 at 01:59:37PM +0800, Qiwu Huang wrote: > > From: Qiwu Huang > > > > Interface to control wireless reverse charge. > > Supply reverse charge function when enabled. > > > > Signed-off-by: Qiwu Huang > > --- > > Documentation/ABI/testing/sysfs-class-power | 12 ++++++++++++ > > drivers/power/supply/power_supply_sysfs.c | 1 + > > include/linux/power_supply.h | 1 + > > 3 files changed, 14 insertions(+) > > > > diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power > > index 75ec7de2fe78..54647d6995d3 100644 > > --- a/Documentation/ABI/testing/sysfs-class-power > > +++ b/Documentation/ABI/testing/sysfs-class-power > > @@ -767,3 +767,15 @@ Description: > > > > Access: Read-Only > > Valid values: 0 - 100 > > + > > +What: /sys/class/power_supply//reverse_chg_mode > > +Date: Jul 2020 > > +Contact: Fei Jiang > > +Description: > > + Some phones support wireless reverse charge function which charge other phones. > > Replace "phones" with "devices"? Yes, devices better than phones > > And shouldn't these lines be wrapped properly at 72 colums or so? Sorry, I will modify the format to match this standard. > > > + The property supply interface to control wireless reverse charge. > > I can't understand this sentance. The property provider interface to enable/disable wireless reverse charge. > > > + If enabled, start TX mode and detect RX. Disabled when timeout or manual setting. > > Can this be set, or is it just something to be read? Sorry,I forgot the permission statement Access: Read, Write > > thanks, > > greg k-h -- Thanks Qiwu