From: Marcin Wojtas <mw@semihalf.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
vivien.didelot@gmail.com, Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
pabeni@redhat.com,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Heiner Kallweit <hkallweit1@gmail.com>,
Grzegorz Bernacki <gjb@semihalf.com>,
Grzegorz Jaszczyk <jaz@semihalf.com>,
Tomasz Nowicki <tn@semihalf.com>,
Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
upstream@semihalf.com
Subject: Re: [net-next: PATCH 11/12] net: dsa: mv88e6xxx: switch to device_/fwnode_ APIs
Date: Tue, 21 Jun 2022 11:14:29 +0200 [thread overview]
Message-ID: <CAPv3WKcqpHfN8UnZo19nKPQMbM5hZvptD=mswvuy-8HB6p=BwQ@mail.gmail.com> (raw)
In-Reply-To: <YrC1ymfSJ3nxWw4B@smile.fi.intel.com>
pon., 20 cze 2022 o 20:03 Andy Shevchenko
<andriy.shevchenko@linux.intel.com> napisał(a):
>
> On Mon, Jun 20, 2022 at 05:02:24PM +0200, Marcin Wojtas wrote:
> > In order to support both ACPI and DT, modify the generic
> > DSA code to use device_/fwnode_ equivalent routines.
> > No functional change is introduced by this patch.
>
> ...
>
> > int err;
> >
> > - if (!np && !pdata)
> > + if (!fwnode && !pdata)
> > return -EINVAL;
>
> Sounds like redundant check
>
> if (pdata)
> ...
> else
> compat_info = ...
> if (!compat_info)
> return -EINVAL
>
> ?
>
> > - if (np)
> > - compat_info = of_device_get_match_data(dev);
> > + if (fwnode)
> > + compat_info = device_get_match_data(dev);
> >
> > if (pdata) {
>
> Missed 'else' even in the original code (see above)?
>
fwnode/np is mutually exclusive with pdata, but imo nothing wrong with
adding 'else' here or update the condition as suggested above.
Thanks,
Marcin
> > compat_info = pdata_device_get_match_data(dev);
>
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
next prev parent reply other threads:[~2022-06-21 9:14 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 15:02 [net-next: PATCH 00/12] ACPI support for DSA Marcin Wojtas
2022-06-20 15:02 ` [net-next: PATCH 01/12] net: phy: fixed_phy: switch to fwnode_ API Marcin Wojtas
2022-06-20 17:25 ` Andy Shevchenko
2022-06-20 17:59 ` Andrew Lunn
2022-06-21 9:56 ` Marcin Wojtas
2022-06-21 10:01 ` Russell King (Oracle)
2022-06-20 15:02 ` [net-next: PATCH 02/12] net: mdio: switch fixed-link PHYs API to fwnode_ Marcin Wojtas
2022-06-20 17:32 ` Andy Shevchenko
2022-06-21 9:22 ` Marcin Wojtas
2022-06-20 15:02 ` [net-next: PATCH 03/12] net: dsa: switch to device_/fwnode_ APIs Marcin Wojtas
2022-06-20 17:41 ` Andy Shevchenko
2022-06-21 9:27 ` Marcin Wojtas
2022-06-21 11:02 ` Andy Shevchenko
2022-06-22 16:09 ` Florian Fainelli
2022-06-20 15:02 ` [net-next: PATCH 04/12] net: mvpp2: initialize port fwnode pointer Marcin Wojtas
2022-06-20 17:43 ` Andy Shevchenko
2022-06-20 17:44 ` Andy Shevchenko
2022-06-21 9:28 ` Marcin Wojtas
2022-06-20 15:02 ` [net-next: PATCH 05/12] net: core: switch to fwnode_find_net_device_by_node() Marcin Wojtas
2022-06-20 17:46 ` Andy Shevchenko
2022-06-20 23:15 ` Marcin Wojtas
2022-06-20 22:30 ` kernel test robot
2022-06-20 15:02 ` [net-next: PATCH 06/12] net: mdio: introduce fwnode_mdiobus_register_device() Marcin Wojtas
2022-06-20 17:48 ` Andy Shevchenko
2022-06-21 9:33 ` Marcin Wojtas
2022-06-20 15:02 ` [net-next: PATCH 07/12] net: mdio: allow registering non-PHY devices in ACPI world Marcin Wojtas
2022-06-20 15:02 ` [net-next: PATCH 08/12] ACPI: scan: prevent double enumeration of MDIO bus children Marcin Wojtas
2022-06-20 17:53 ` Andy Shevchenko
2022-06-20 23:04 ` Marcin Wojtas
2022-06-22 12:09 ` Rafael J. Wysocki
2022-06-22 15:05 ` Marcin Wojtas
2022-06-20 19:08 ` Andrew Lunn
2022-06-22 12:05 ` Rafael J. Wysocki
2022-06-22 16:12 ` Florian Fainelli
2022-06-22 16:21 ` Rafael J. Wysocki
2022-06-23 7:41 ` Andrew Lunn
2022-06-23 23:07 ` Marcin Wojtas
2022-06-20 15:02 ` [net-next: PATCH 09/12] Documentation: ACPI: DSD: introduce DSA description Marcin Wojtas
2022-06-20 18:19 ` Andrew Lunn
2022-06-20 23:21 ` Marcin Wojtas
2022-06-20 19:47 ` Andrew Lunn
2022-06-20 23:25 ` Marcin Wojtas
2022-06-21 11:09 ` Andy Shevchenko
2022-06-21 11:18 ` Andrew Lunn
2022-06-21 11:42 ` Andy Shevchenko
2022-06-22 9:08 ` Marcin Wojtas
2022-06-22 9:24 ` Andrew Lunn
2022-06-22 10:22 ` Marcin Wojtas
2022-06-22 10:37 ` Andrew Lunn
2022-06-22 11:08 ` Andy Shevchenko
2022-06-22 11:04 ` Andy Shevchenko
2022-06-22 11:03 ` Andy Shevchenko
2022-06-22 11:22 ` Andrew Lunn
2022-06-22 14:20 ` Andy Shevchenko
2022-06-22 15:00 ` Marcin Wojtas
2022-06-21 9:45 ` Sudeep Holla
2022-06-21 11:15 ` Andy Shevchenko
2022-06-21 11:24 ` Andrew Lunn
2022-06-21 11:46 ` Andy Shevchenko
2022-06-21 11:57 ` Andrew Lunn
2022-06-21 13:28 ` Sudeep Holla
2022-06-21 15:23 ` Rafael J. Wysocki
2022-06-21 15:37 ` Sudeep Holla
2022-06-21 16:00 ` Rafael J. Wysocki
2022-06-21 18:11 ` Sudeep Holla
2022-06-20 15:02 ` [net-next: PATCH 10/12] net: dsa: add ACPI support Marcin Wojtas
2022-06-20 18:32 ` Andrew Lunn
2022-06-20 23:31 ` Marcin Wojtas
2022-06-20 15:02 ` [net-next: PATCH 11/12] net: dsa: mv88e6xxx: switch to device_/fwnode_ APIs Marcin Wojtas
2022-06-20 18:00 ` Andy Shevchenko
2022-06-21 9:14 ` Marcin Wojtas [this message]
2022-06-20 18:04 ` Andy Shevchenko
2022-06-21 9:15 ` Marcin Wojtas
2022-06-20 15:02 ` [net-next: PATCH 12/12] net: dsa: mv88e6xxx: add ACPI support Marcin Wojtas
2022-06-25 2:54 ` kernel test robot
2022-06-20 17:21 ` [net-next: PATCH 00/12] ACPI support for DSA Andy Shevchenko
2022-06-21 10:02 ` Marcin Wojtas
2022-06-20 17:55 ` Andrew Lunn
2022-06-20 18:07 ` Andy Shevchenko
2022-06-20 18:45 ` Andrew Lunn
2022-06-21 10:46 ` Marcin Wojtas
2022-06-22 15:40 ` Marcin Wojtas
2022-06-22 16:14 ` Andy Shevchenko
2022-06-21 10:16 ` Marcin Wojtas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPv3WKcqpHfN8UnZo19nKPQMbM5hZvptD=mswvuy-8HB6p=BwQ@mail.gmail.com' \
--to=mw@semihalf.com \
--cc=Samer.El-Haj-Mahmoud@arm.com \
--cc=andrew@lunn.ch \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=gjb@semihalf.com \
--cc=hkallweit1@gmail.com \
--cc=jaz@semihalf.com \
--cc=kuba@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=rafael@kernel.org \
--cc=tn@semihalf.com \
--cc=upstream@semihalf.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).