From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F566C2B9F4 for ; Thu, 17 Jun 2021 13:23:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 83F0C613C1 for ; Thu, 17 Jun 2021 13:23:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232557AbhFQNZK (ORCPT ); Thu, 17 Jun 2021 09:25:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229931AbhFQNZI (ORCPT ); Thu, 17 Jun 2021 09:25:08 -0400 Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75A1EC06175F for ; Thu, 17 Jun 2021 06:23:00 -0700 (PDT) Received: by mail-qt1-x832.google.com with SMTP id a15so4619443qtx.13 for ; Thu, 17 Jun 2021 06:23:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=EpWxRaSsnLYws7nyDWlyhtmN0+4jL+XRdMFxoBZFNjc=; b=qYJWuKoW9PtFH0BaBavdHQXZ9+p0C7xQmq3feta+NIidPdHSI9MFKCdyx1kNqtfOpg KqwrVyubAH3gQTpeI6o9jbhjf4e5bXent62688TD1VTSRlQz8I1y6Wu1eJ8zsHK6RDpG OYnLDI1J97EFHEm02dAZwqH5IvVSemWWk5jhCh4l+8HyeKmcq+ZHCCsoCz+Pk65nNT0H WrZuO4B/+OyZvmn2W37oZqCq+dr/LuSiONs+3EUOEZUWN5Av3gB5GWbRLGvM+h6RTTEE mExSWQN0MrhdsqePYH2dsvR54j+OhJal4GdCpmXTTJArxMLZufCpWk8KxVW/WZ7Sj83W 4qzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=EpWxRaSsnLYws7nyDWlyhtmN0+4jL+XRdMFxoBZFNjc=; b=GlKeuaQVWbQxAcK+hSF5Bz+TeQUPo6ObQJhLJFehdX4AMKj2nr8K6dhF6kqquoJYd9 cXahnvcoXwxr7xfkNWjqsfQ/8ubKfP3HJYoqH7+lxY4g3ge52v+meCqQjAA/6dhBZrHG pYwhwRdepLCOn/YiiKz/xjdpEawcoinBtHbtLlrG348g17F6gXLIkuOrmfnFmw7WkU32 teX/w2uggxyZxyT/07BxaHER08MtzjK8aabya8oD8wzPkTp3H+bQ3P2ZvSd1+Y1KyV/p aPY/d2Vqpeq4Rw2hAwtNo3BJlLWPno2w6+MnUaAbYMa+J23E92jJE+pr6bxu+6lrQ/sH B6Kw== X-Gm-Message-State: AOAM531OzOwKoYrQB9TuPQemEb2QIkrXMfqWaGjisqShLwplmf9yUQvb 2K9uoyJme916dsVWvRehbiEtrLoFvlW0vYKzMXUG6ALxo9M= X-Google-Smtp-Source: ABdhPJxAO2nFYDYfih/PNHQokbVY+LbN/ZwPSGQzc6cgf+MSSXMDBX0GH72V1GWtMo2c7X3wq8BASCM2xClh5j32XZg= X-Received: by 2002:a05:622a:81:: with SMTP id o1mr5046038qtw.16.1623936179469; Thu, 17 Jun 2021 06:22:59 -0700 (PDT) MIME-Version: 1.0 References: <20210616190759.2832033-1-mw@semihalf.com> <20210616190759.2832033-4-mw@semihalf.com> In-Reply-To: From: Marcin Wojtas Date: Thu, 17 Jun 2021 15:22:48 +0200 Message-ID: Subject: Re: [net-next: PATCH v2 3/7] net/fsl: switch to fwnode_mdiobus_register To: Andrew Lunn Cc: Linux Kernel Mailing List , netdev , "David S. Miller" , Jakub Kicinski , Russell King - ARM Linux , Grzegorz Jaszczyk , Grzegorz Bernacki , upstream@semihalf.com, Samer El-Haj-Mahmoud , Jon Nettleton , Tomasz Nowicki , rjw@rjwysocki.net, lenb@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org czw., 17 cze 2021 o 14:28 Andrew Lunn napisa=C5=82(a): > > On Thu, Jun 17, 2021 at 01:39:40AM +0200, Marcin Wojtas wrote: > > =C5=9Br., 16 cze 2021 o 21:35 Andrew Lunn napisa=C5=82= (a): > > > > > > On Wed, Jun 16, 2021 at 09:07:55PM +0200, Marcin Wojtas wrote: > > > > Utilize the newly added helper routine > > > > for registering the MDIO bus via fwnode_ > > > > interface. > > > > > > You need to add depends on FWNODE_MDIO > > > > > > > Do you mean something like this? > > > > --- a/drivers/net/ethernet/freescale/Kconfig > > +++ b/drivers/net/ethernet/freescale/Kconfig > > @@ -68,8 +68,8 @@ config FSL_PQ_MDIO > > config FSL_XGMAC_MDIO > > tristate "Freescale XGMAC MDIO" > > select PHYLIB > > - depends on OF > > - select OF_MDIO > > + depends on ACPI || OF > > + select FWNODE_MDIO > > help > > You should not need depends on ACPI || OF. FWNODE_MDIO implies > that. And there are no direct calls to of_ functions, so you can drop > the depends on OF. > Ok, I'll leave: depends on FWNODE_MDIO only. Thanks, Marcin