Re: [net-next: PATCH v4 1/7] device property: Introduce fwnode_get_mac_address()

From: Marcin Wojtas <mw@semihalf.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	netdev <netdev@vger.kernel.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Graeme Gregory <graeme.gregory@linaro.org>,
	David Miller <davem@davemloft.net>,
	Russell King - ARM Linux <linux@armlinux.org.uk>,
	Rafael Wysocki <rafael.j.wysocki@intel.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Antoine Tenart <antoine.tenart@free-electrons.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Gregory Clement <gregory.clement@free-electrons.com>,
	Stefan Chulski <stefanc@marvell.com>,
	Nadav Haklai <nadavh@marvell.com>,
	Neta Zur Hershkovits <neta@marvell.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Grzegorz Jaszczyk <jaz@semihalf.com>,
	Tomasz Nowicki <tn@semihalf.com>
Subject: Re: [net-next: PATCH v4 1/7] device property: Introduce fwnode_get_mac_address()
Date: Wed, 24 Jan 2018 07:17:25 +0100	[thread overview]
Message-ID: <CAPv3WKfCRE46W9kKCvffN+SuPBKF1bchUBJNjUuOMoPUj8H0qA@mail.gmail.com> (raw)
In-Reply-To: <CAJZ5v0jpGb8_rSTdtoLJW9os0ufgwLTnbWAQq6MTy_ye6Hr6KA@mail.gmail.com>

Hi Rafael,

2018-01-24 3:08 GMT+01:00 Rafael J. Wysocki <rafael@kernel.org>:
> On Tue, Jan 23, 2018 at 7:12 AM, Marcin Wojtas <mw@semihalf.com> wrote:
>> Hi Rafael,
>>
>>> >         if (res)
>>> >                 return res;
>>> >
>>> > -       return device_get_mac_addr(dev, "address", addr, alen);
>>> > +       return fwnode_get_mac_addr(fwnode, "address", addr, alen);
>>> > +}
>>> > +EXPORT_SYMBOL(fwnode_get_mac_address);
>>>
>>> That should be EXPORT_SYMBOL_GPL().
>>>
>>> I have overlooked that previously, sorry about that.
>>
>> The series landed yesterday in net-next, so I need to send a fix on
>> top.
>
> OK
>
>> Would you be ok with single patch fixing all EXPORT_SYMBOL()
>> occurences? Those would be 2 new routines:
>> - fwnode_get_mac_address
>> - fwnode_irq_get
>> and  2 already existing in the file:
>> - device_get_mac_address
>> - fwnode_graph_parse_endpoint
>>
>> Please let know, how you prefer to handle it?
>
> I guess it's better to fix this up when the series gets merged.
>

Ok, I will do it at that time.

Thanks,
Marcin