From: Marcin Wojtas <mw@semihalf.com>
To: David Miller <davem@davemloft.net>
Cc: "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org,
netdev <netdev@vger.kernel.org>,
"Russell King - ARM Linux" <linux@armlinux.org.uk>,
"Maxime Chevallier" <maxime.chevallier@bootlin.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Grégory Clement" <gregory.clement@bootlin.com>,
"Antoine Tenart" <antoine.tenart@bootlin.com>,
"Stefan Chulski" <stefanc@marvell.com>,
nadavh@marvell.com, "Grzegorz Jaszczyk" <jaz@semihalf.com>
Subject: Re: [PATCH net] net: mvneta: fix operation for 64K PAGE_SIZE
Date: Mon, 17 Dec 2018 00:25:58 +0100 [thread overview]
Message-ID: <CAPv3WKfz4AkODzJ+gsV=u6ve5YnZEdUhZF5+VmFPQa4mp9okUw@mail.gmail.com> (raw)
In-Reply-To: <20181216.124120.731491122771817496.davem@davemloft.net>
Hi David,
niedz., 16 gru 2018 o 21:41 David Miller <davem@davemloft.net> napisał(a):
>
> From: Marcin Wojtas <mw@semihalf.com>
> Date: Tue, 11 Dec 2018 13:56:49 +0100
>
> > Recent changes in the mvneta driver reworked allocation
> > and handling of the ingress buffers to use entire pages.
> > Apart from that in SW BM scenario the HW must be informed
> > via PRXDQS about the biggest possible incoming buffer
> > that can be propagated by RX descriptors.
> >
> > The BufferSize field was filled according to the MTU-dependent
> > pkt_size value. Later change to PAGE_SIZE broke RX operation
> > when usin 64K pages, as the field is simply too small.
> >
> > This patch conditionally limits the value passed to the BufferSize
> > of the PRXDQS register, depending on the PAGE_SIZE used.
> > On the occasion remove now unused frag_size field of the mvneta_port
> > structure.
> >
> > Fixes: 562e2f467e71 ("net: mvneta: Improve the buffer allocation method for SWBM")
> > Signed-off-by: Marcin Wojtas <mw@semihalf.com>
>
> The discussion died on this, but the bug should be fixed.
>
> So in the short term I am applying this and queueing it up for v4.19
> -stable.
>
> Thanks.
Thanks. Indeed, the patch is valid as a fix for current version of SW
BM. However, because this concept is broken, I will rework it and
submit patch/patches some time early 2019.
Best regards,
Marcin
next prev parent reply other threads:[~2018-12-16 23:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 12:56 [PATCH net] net: mvneta: fix operation for 64K PAGE_SIZE Marcin Wojtas
2018-12-12 2:48 ` Jisheng Zhang
2018-12-12 8:22 ` Marcin Wojtas
2018-12-12 9:25 ` Jisheng Zhang
2018-12-12 11:04 ` Marcin Wojtas
2018-12-16 20:41 ` David Miller
2018-12-16 23:25 ` Marcin Wojtas [this message]
2018-12-17 7:37 ` Thomas Petazzoni
2018-12-19 3:11 ` Jisheng Zhang
2018-12-19 9:24 ` Marcin Wojtas
2018-12-19 10:21 ` Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPv3WKfz4AkODzJ+gsV=u6ve5YnZEdUhZF5+VmFPQa4mp9okUw@mail.gmail.com' \
--to=mw@semihalf.com \
--cc=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=gregory.clement@bootlin.com \
--cc=jaz@semihalf.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=stefanc@marvell.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).