From: 施錕鴻 <vincent.sunplus@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
stern@rowland.harvard.edu, p.zabel@pengutronix.de,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
robh+dt@kernel.org, devicetree@vger.kernel.org,
wells.lu@sunplus.com
Subject: Re: [PATCH v1 2/2] dt-bindings: usb: Add bindings doc for Sunplus USB HOST OHCI driver
Date: Thu, 17 Mar 2022 18:24:33 +0800 [thread overview]
Message-ID: <CAPvp3RhOs5y2XBYEdY31f5rc9yP5o-x_2KB2=umhL7VdvGXYTw@mail.gmail.com> (raw)
In-Reply-To: <7d560277-95e2-070c-e603-30f00dea7f51@canonical.com>
Hi, Krzysztof
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> 於 2022年3月15日
週二 上午12:42寫道:
>
> On 14/03/2022 06:32, Vincent Shih wrote:
> > Add bindings doc for Sunplus USB HOST OHCI driver
> >
> > Signed-off-by: Vincent Shih <vincent.sunplus@gmail.com>
> > ---
> > .../bindings/usb/sunplus,sp7021-usb-ohci.yaml | 69 ++++++++++++++++++++++
> > MAINTAINERS | 1 +
> > 2 files changed, 70 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/usb/sunplus,sp7021-usb-ohci.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/usb/sunplus,sp7021-usb-ohci.yaml b/Documentation/devicetree/bindings/usb/sunplus,sp7021-usb-ohci.yaml
> > new file mode 100644
> > index 0000000..7583b68
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/usb/sunplus,sp7021-usb-ohci.yaml
> > @@ -0,0 +1,69 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +# Copyright (C) Sunplus Co., Ltd. 2021
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/usb/sunplus,sp7021-usb-ohci.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
>
> Looks good. Few minor nitpicks:
>
> > +title: Sunplus SP7021 OHCI Controller Device Tree Bindings
>
> Remove "Device Tree Bindings" words here. Title is about hardware.
>
Yes, I will remove it.
> > +
> > +allOf:
> > + - $ref: usb-hcd.yaml#
>
> Put entire "allOf:" just before "properties:".
Yes, I will modify it.
>
> > +
> > +maintainers:
> > + - Vincent Shih <vincent.sunplus@gmail.com>
> > +
> > +description:
> > + Sunplus SP7021 USB HOST IP is a USB2.0 Host Controller. It supports both
> > + Enhanced Host Controller Interface (EHCI) and Open Host Controller Interface
> > + (OHCI).
> > +
> > + It supports 32-bits address bus and 64bit data bus interface, compliant
> > + to AMBA AXI interface for data transfer.
> > +
> > + It supports 32-bits address and data bus interface, compliant to AMBA
> > + AHB interface for register configurations.
> > +
> > + It supports 32-bits address and data bus interface, compliant to AMBA
> > + AXI interface for register alternative configurations.
> > +
> > + The UTM Interface block generates PHY control signals, compliant to
> > + USB2.0 Transceiver Macrocell Interface Specification Revision 1.0.
> > +
> > +properties:
> > + compatible:
> > + const: sunplus,sp7021-usb-ohci
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + clocks:
> > + maxItems: 1
> > +
> > + resets:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
>
> You might need here phys. Are you sure you do not need to configure the
> phy for OHCI? You should not assume it would be configured by other driver.
>
Yes, OHCI driver does not need to configure phy according to the
suggestion of our RD.
The default status of phy after power-on is good enough for OHCI.
> Best regards,
> Krzysztof
Thanks for your review.
next prev parent reply other threads:[~2022-03-17 10:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 5:32 [PATCH v1 0/2] Add USB HOST OHCI driver for Sunplus SP7021 SoC Vincent Shih
2022-03-14 5:32 ` [PATCH v1 1/2] usb: host: ohci-sunplus: Add driver for USB HOST OHCI in " Vincent Shih
2022-03-14 5:32 ` [PATCH v1 2/2] dt-bindings: usb: Add bindings doc for Sunplus USB HOST OHCI driver Vincent Shih
2022-03-14 16:42 ` Krzysztof Kozlowski
2022-03-17 10:24 ` 施錕鴻 [this message]
2022-03-23 18:07 ` [PATCH v1 0/2] Add USB HOST OHCI driver for Sunplus SP7021 SoC Rob Herring
2022-03-24 10:48 ` 施錕鴻
2022-03-24 13:18 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPvp3RhOs5y2XBYEdY31f5rc9yP5o-x_2KB2=umhL7VdvGXYTw@mail.gmail.com' \
--to=vincent.sunplus@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=wells.lu@sunplus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).