From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
To: "Ji-Ze Hong (Peter Hong)" <hpeter@gmail.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jslaby@suse.com>, "Arnd Bergmann" <arnd@arndb.de>,
"Peter Hurley" <peter@hurleysoftware.com>,
linux-serial@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
"PA20 TOM TSAI 蔡宗佑" <tom_tsai@fintek.com.tw>,
"Peter H" <peter_hong@fintek.com.tw>,
"Ji-Ze Hong (Peter Hong)" <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH 7/7] serial: 8250_fintek: Add F81865 Support
Date: Thu, 1 Sep 2016 13:29:29 +0200 [thread overview]
Message-ID: <CAPybu_0bUDRaZKKnEAqEsiBhwuVOqAT_ncWEvJ49BJueKcjH9g@mail.gmail.com> (raw)
In-Reply-To: <1472701196-14795-8-git-send-email-hpeter+linux_kernel@gmail.com>
Hi Peter
On Thu, Sep 1, 2016 at 5:39 AM, Ji-Ze Hong (Peter Hong)
<hpeter@gmail.com> wrote:
>
> switch (pdata->pid) {
> + case CHIP_ID_F81865:
> case CHIP_ID_F81866:
> - sio_write_mask_reg(pdata, F81866_FIFO_CTRL, F81866_IRQ_MODE1,
> - 0);
> + if (pdata->pid == CHIP_ID_F81866)
> + sio_write_mask_reg(pdata, F81866_FIFO_CTRL,
> + F81866_IRQ_MODE1, 0);
> +
> sio_write_mask_reg(pdata, F81866_IRQ_MODE, F81866_IRQ_SHARE,
> F81866_IRQ_SHARE);
> sio_write_mask_reg(pdata, F81866_IRQ_MODE,
What about:
case CHIP_ID_F81866:
sio_write_mask_reg(pdata, F81866_FIFO_CTRL, F81866_IRQ_MODE1, 0);
/* fall through */
case CHIP_ID_F81865:
sio_write_mask_reg(pdata, F81
.....
> @@ -312,6 +318,7 @@ static void fintek_8250_set_rs485_handler(struct uart_8250_port *uart)
> default: /* No RS485 Auto direction functional */
> break;
>
> + case CHIP_ID_F81865:
> case CHIP_ID_F81866:
> case CHIP_ID_F81216AD:
> case CHIP_ID_F81216H:
> --
> 1.9.1
>
--
Ricardo Ribalda
prev parent reply other threads:[~2016-09-01 11:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 3:39 [PATCH 0/7] serial: 8250_fintek: Fix the IRQ mode and code refactoring Ji-Ze Hong (Peter Hong)
2016-09-01 3:39 ` [PATCH 1/7] serial: 8250_fintek: Refactoring read/write method Ji-Ze Hong (Peter Hong)
2016-09-01 3:39 ` [PATCH 2/7] serial: 8250_fintek: Set IRQ Mode when port probed Ji-Ze Hong (Peter Hong)
2016-09-01 3:39 ` [PATCH 3/7] serial: 8250_fintek: Set maximum FIFO of F81216H Ji-Ze Hong (Peter Hong)
2016-09-01 11:16 ` Ricardo Ribalda Delgado
2016-09-06 1:37 ` Ji-Ze Hong (Peter Hong)
2016-09-01 3:39 ` [PATCH 4/7] serial: 8250_fintek: Rearrange function Ji-Ze Hong (Peter Hong)
2016-09-01 11:17 ` Ricardo Ribalda Delgado
2016-09-06 1:56 ` Ji-Ze Hong (Peter Hong)
2016-09-01 3:39 ` [PATCH 5/7] serial: 8250_fintek: Add F81216 Support Ji-Ze Hong (Peter Hong)
2016-09-01 11:22 ` Ricardo Ribalda Delgado
2016-09-06 2:04 ` Ji-Ze Hong (Peter Hong)
2016-09-01 3:39 ` [PATCH 6/7] serial: 8250_fintek: Add F81866 Support Ji-Ze Hong (Peter Hong)
2016-09-01 3:39 ` [PATCH 7/7] serial: 8250_fintek: Add F81865 Support Ji-Ze Hong (Peter Hong)
2016-09-01 11:29 ` Ricardo Ribalda Delgado [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPybu_0bUDRaZKKnEAqEsiBhwuVOqAT_ncWEvJ49BJueKcjH9g@mail.gmail.com \
--to=ricardo.ribalda@gmail.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=hpeter+linux_kernel@gmail.com \
--cc=hpeter@gmail.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=peter_hong@fintek.com.tw \
--cc=tom_tsai@fintek.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).