From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932975AbcIALXV (ORCPT <rfc822;w@1wt.eu>);
        Thu, 1 Sep 2016 07:23:21 -0400
Received: from mail-wm0-f66.google.com ([74.125.82.66]:35323 "EHLO
        mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754222AbcIALXR (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 1 Sep 2016 07:23:17 -0400
MIME-Version: 1.0
In-Reply-To: <1472701196-14795-6-git-send-email-hpeter+linux_kernel@gmail.com>
References: <1472701196-14795-1-git-send-email-hpeter+linux_kernel@gmail.com> <1472701196-14795-6-git-send-email-hpeter+linux_kernel@gmail.com>
From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Date: Thu, 1 Sep 2016 13:22:55 +0200
Message-ID: <CAPybu_19AgXA+Thc6sd-Zp-707P+u47xzJpcnFuJGTa9YvWYbA@mail.gmail.com>
Subject: Re: [PATCH 5/7] serial: 8250_fintek: Add F81216 Support
To: "Ji-Ze Hong (Peter Hong)" <hpeter@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jslaby@suse.com>, Arnd Bergmann <arnd@arndb.de>,
        Peter Hurley <peter@hurleysoftware.com>, linux-serial@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>,
        =?UTF-8?B?UEEyMCBUT00gVFNBSSDolKHlrpfkvZE=?= 
        <tom_tsai@fintek.com.tw>,
        Peter H <peter_hong@fintek.com.tw>,
        "Ji-Ze Hong (Peter Hong)" <hpeter+linux_kernel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Peter

On Thu, Sep 1, 2016 at 5:39 AM, Ji-Ze Hong (Peter Hong)
<hpeter@gmail.com> wrote:

>  int fintek_8250_probe(struct uart_8250_port *uart)
>  {
>         struct fintek_8250 *pdata;
> @@ -248,8 +270,8 @@ int fintek_8250_probe(struct uart_8250_port *uart)
>                 return -ENOMEM;
>
>         memcpy(pdata, &probe_data, sizeof(probe_data));
> -       uart->port.rs485_config = fintek_8250_rs485_config;

Maybe just:


if (pdata->id != CHIP_ID_F81216)
   uart->port.rs485_config = fintek_8250_rs485_config;


Instead of the whole function

>         uart->port.private_data = pdata;
> +       fintek_8250_set_rs485_handler(uart);
>
>         return 0;
>  }
> --
> 1.9.1
>



-- 
Ricardo Ribalda