From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D15AC32788 for ; Thu, 11 Oct 2018 13:43:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4D62F20652 for ; Thu, 11 Oct 2018 13:43:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="s0Bfow9+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D62F20652 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728474AbeJKVKO (ORCPT ); Thu, 11 Oct 2018 17:10:14 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:42664 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727357AbeJKVKO (ORCPT ); Thu, 11 Oct 2018 17:10:14 -0400 Received: by mail-lf1-f67.google.com with SMTP id s10-v6so6713182lfc.9; Thu, 11 Oct 2018 06:42:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VFG35thz5C3Rdme6RdGBfvE+n6fQJ0XR1WWxBMgNFBE=; b=s0Bfow9+5mCa+yfkvwJ2oO87spDBsxETQetUPLe842p+LlKw6H9KAEGqWk8B+n3NML tBTkhilQVpBNkTKFI3LaP4r9+QIrB3sBiNPV+y7Sj7NPvFa+9ATqVqijmQ5yymkVyJA8 bnq01jmEdvJotimnqrHIAIoELfAeZKD3oMy20WNpK8PFhFIC1NwceDdSwulf8syI8X9V 2y+yLAxfAl/zq2KoBn66QXdDcYUTtX3NPj9ZU7r7F/o1wMlHt1XBbXrSkkSxzhMtZke8 L2lYHt3EDeohucA2wVfqYd2jUN5TbqL3QUcNYDx9k3dxWOE+SWeLxO8Qaec1j2nnM2QA a8+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VFG35thz5C3Rdme6RdGBfvE+n6fQJ0XR1WWxBMgNFBE=; b=ifMvDPCBpNtnUmdxPoz0dI/mLTZIlKO1MRZ9dBLElmAvVl+KZ77r4iT/CD+906sV/C xsAPBoM31NQxdboD2DlOOXM3M/IqGV9ixNHm5prsPDeUaE3xJDSgHk29YAgDaeUZ5CS9 TnaOTZ7KOgcwxrU/T/BooD8YPfwX755J9/UNAAOKCBMj9HZcJuz0Z4TJEHQEOYI04ZrE zcoSKNIxW6Gk9wRY1u7Qqk6NqUfdb9+kWDCbBvALZoC/+iCwbk9EW+AqxKFYC8v3He1/ SEtC5UpJy21LJ1bfryuvTyJysXtGCHOWZ2EmYQ+UsYufdZxiNZLA/Yd4Q5nC9GgUm9tt ZKTg== X-Gm-Message-State: ABuFfogy1pKMiqNiBgMw7sySSkXUisJNOZ4YrPz17h7dUUECiEFRdtlH G2D3m4Dc2gIjkTj1ILcsws7bVeABbpQW9+iyav4= X-Google-Smtp-Source: ACcGV62/MKDtjNntQDAraE2s5ZM2p6T7Gdsre7mjVW+ZWBJ7o/w4/Y0bWX5PIRLcF5hbwAi9WcPizL7UxKqcfzlUZbo= X-Received: by 2002:a19:d408:: with SMTP id l8-v6mr1257491lfg.25.1539265375453; Thu, 11 Oct 2018 06:42:55 -0700 (PDT) MIME-Version: 1.0 References: <20181005065300.22882-1-ricardo.ribalda@gmail.com> <20181005065300.22882-3-ricardo.ribalda@gmail.com> <9746eba6-63f5-feaf-e63f-7e0ea7638942@ti.com> In-Reply-To: <9746eba6-63f5-feaf-e63f-7e0ea7638942@ti.com> From: Ricardo Ribalda Delgado Date: Thu, 11 Oct 2018 15:42:38 +0200 Message-ID: Subject: Re: [PATCH v5 3/3] gpiolib: Show correct direction from the beginning To: Vignesh R Cc: Linus Walleij , Timur Tabi , Stephen Boyd , linux-gpio , LKML , Jeffrey Hugo , linux-omap@vger.kernel.org, Tony Lindgren , grygorii.strashko@ti.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vignesh Ups, it does not look too good :S . Can you check if this change fixes it: diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index e016b22658ff..bcd0ef49ce97 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -1349,6 +1349,9 @@ int gpiochip_add_data_with_key(struct gpio_chip *chip, void *data, spin_unlock_irqrestore(&gpio_lock, flags); + for (i = 0; i < chip->ngpio; i++) + gdev->descs[i].gdev = gdev; + #ifdef CONFIG_PINCTRL INIT_LIST_HEAD(&gdev->pin_ranges); #endif @@ -1380,8 +1383,6 @@ int gpiochip_add_data_with_key(struct gpio_chip *chip, void *data, for (i = 0; i < chip->ngpio; i++) { struct gpio_desc *desc = &gdev->descs[i]; - desc->gdev = gdev; - if (chip->get_direction && gpiochip_line_is_valid(chip, i)) desc->flags = !chip->get_direction(chip, i) ? (1 << FLAG_IS_OUT) : 0; Thanks! On Thu, Oct 11, 2018 at 2:18 PM Vignesh R wrote: > > Hi, > > On Friday 05 October 2018 12:23 PM, Ricardo Ribalda Delgado wrote: > > Current code assumes that the direction is input if direction_input > > function is set. > > This might not be the case on GPIOs with programmable direction. > > > > Signed-off-by: Ricardo Ribalda Delgado > > Tested-by: Jeffrey Hugo > > This patch causes oops on TI's AM335x-ICEv2 board on next-20181011: > > [ 0.563797] OMAP GPIO hardware version 0.1 > [ 0.577589] Unable to handle kernel NULL pointer dereference at virtual address 000002b8 > [ 0.586127] pgd = (ptrval) > [ 0.588934] [000002b8] *pgd=00000000 > [ 0.592732] Internal error: Oops: 5 [#1] SMP ARM > [ 0.597499] Modules linked in: > [ 0.600668] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.19.0-rc7-next-20181011 #70 > [ 0.608466] Hardware name: Generic AM33XX (Flattened Device Tree) > [ 0.614770] PC is at gpiod_hog+0x30/0x154 > [ 0.618913] LR is at of_gpiochip_add+0x2fc/0x4e4 > [ 0.623671] pc : [] lr : [] psr: 60000013 > [ 0.630130] sp : ce09bba0 ip : cdf08095 fp : 00000000 > [ 0.635516] r10: c0bfcf24 r9 : 00000000 r8 : 00000007 > [ 0.640902] r7 : cdf08088 r6 : 00000000 r5 : 00000000 r4 : ce191e40 > [ 0.647630] r3 : 00000000 r2 : 00000000 r1 : cdf08088 r0 : ce191e40 > [ 0.654361] Flags: nZCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment none > [ 0.661718] Control: 10c5387d Table: 80004019 DAC: 00000051 > [ 0.667642] Process swapper/0 (pid: 1, stack limit = 0x(ptrval)) > [...] > [ 0.973593] [] (gpiod_hog) from [] (of_gpiochip_add+0x2fc/0x4e4) > [ 0.981588] [] (of_gpiochip_add) from [] (gpiochip_add_data_with_key+ > 0x5a0/0x990) > [ 0.991102] [] (gpiochip_add_data_with_key) from [] (omap_gpio_probe+ > 0x37c/0x75c) > [ 1.000613] [] (omap_gpio_probe) from [] (platform_drv_probe+0x48/0x9 > 8) > [ 1.009237] [] (platform_drv_probe) from [] (really_probe+0x220/0x2d4 > ) > [ 1.017764] [] (really_probe) from [] (driver_probe_device+0x5c/0x164 > ) > [ 1.026293] [] (driver_probe_device) from [] (bus_for_each_drv+0x54/0 > xb8) > [ 1.035090] [] (bus_for_each_drv) from [] (__device_attach+0xcc/0x13c > ) > [ 1.043615] [] (__device_attach) from [] (bus_probe_device+0x88/0x90) > [ 1.052051] [] (bus_probe_device) from [] (device_add+0x3d8/0x608) > [ 1.060223] [] (device_add) from [] (of_platform_device_create_pdata+ > 0x8c/0xc0) > [ 1.069552] [] (of_platform_device_create_pdata) from [] (of_platform > _bus_create+0x190/0x228) > [ 1.080134] [] (of_platform_bus_create) from [] (of_platform_bus_crea > te+0x1dc/0x228) > [ 1.089909] [] (of_platform_bus_create) from [] (of_platform_populate > +0x5c/0xac) > [ 1.099333] [] (of_platform_populate) from [] (pdata_quirks_init+0x6c > /0x90) > [ 1.108306] [] (pdata_quirks_init) from [] (omap_generic_init+0xc/0x1 > 8) > [ 1.116933] [] (omap_generic_init) from [] (customize_machine+0x1c/0x > 30) > [ 1.125645] [] (customize_machine) from [] (do_one_initcall+0x80/0x31 > 0) > [ 1.134265] [] (do_one_initcall) from [] (kernel_init_freeable+0x3c4/ > 0x4ac) > [ 1.143238] [] (kernel_init_freeable) from [] (kernel_init+0x8/0x114) > [ 1.151673] [] (kernel_init) from [] (ret_from_fork+0x14/0x20) > [ 1.159475] Exception stack(0xce09bfb0 to 0xce09bff8) > [ 1.164686] bfa0: 00000000 00000000 00000000 00000000 > [ 1.173119] bfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 > [ 1.181551] bfe0: 00000000 00000000 00000000 00000000 00000013 00000000 > [ 1.188378] Code: 0a000002 e3530000 01a09003 159392b4 (e59352b8) > [ 1.194766] ---[ end trace d5c17cd400f50a22 ]--- > [ 1.199606] Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b > [ 1.199606] > [ 1.209052] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000 > 00b > [ 1.209052] ]--- > [ 3.172292] random: fast init done > > Full log: https://pastebin.ubuntu.com/p/jG8nN6CTBP/ > > Reverting this patch from linux-next allows to boot to prompt. > > Regards > Vignesh > > > --- > > drivers/gpio/gpiolib.c | 27 +++++++++++++-------------- > > 1 file changed, 13 insertions(+), 14 deletions(-) > > > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > > index 907019b67a58..e016b22658ff 100644 > > --- a/drivers/gpio/gpiolib.c > > +++ b/drivers/gpio/gpiolib.c > > @@ -1349,20 +1349,6 @@ int gpiochip_add_data_with_key(struct gpio_chip *chip, void *data, > > > > spin_unlock_irqrestore(&gpio_lock, flags); > > > > - for (i = 0; i < chip->ngpio; i++) { > > - struct gpio_desc *desc = &gdev->descs[i]; > > - > > - desc->gdev = gdev; > > - > > - /* REVISIT: most hardware initializes GPIOs as inputs (often > > - * with pullups enabled) so power usage is minimized. Linux > > - * code should set the gpio direction first thing; but until > > - * it does, and in case chip->get_direction is not set, we may > > - * expose the wrong direction in sysfs. > > - */ > > - desc->flags = !chip->direction_input ? (1 << FLAG_IS_OUT) : 0; > > - } > > - > > #ifdef CONFIG_PINCTRL > > INIT_LIST_HEAD(&gdev->pin_ranges); > > #endif > > @@ -1391,6 +1377,19 @@ int gpiochip_add_data_with_key(struct gpio_chip *chip, void *data, > > if (status) > > goto err_remove_chip; > > > > + for (i = 0; i < chip->ngpio; i++) { > > + struct gpio_desc *desc = &gdev->descs[i]; > > + > > + desc->gdev = gdev; > > + > > + if (chip->get_direction && gpiochip_line_is_valid(chip, i)) > > + desc->flags = !chip->get_direction(chip, i) ? > > + (1 << FLAG_IS_OUT) : 0; > > + else > > + desc->flags = !chip->direction_input ? > > + (1 << FLAG_IS_OUT) : 0; > > + } > > + > > acpi_gpiochip_add(chip); > > > > machine_gpiochip_add(chip); > > > -- Ricardo Ribalda