From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756799AbbDWIHI (ORCPT ); Thu, 23 Apr 2015 04:07:08 -0400 Received: from mail-la0-f52.google.com ([209.85.215.52]:35155 "EHLO mail-la0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756058AbbDWIG6 (ORCPT ); Thu, 23 Apr 2015 04:06:58 -0400 MIME-Version: 1.0 In-Reply-To: <20150422164701.GJ20701@google.com> References: <1429719261-18024-1-git-send-email-ricardo.ribalda@gmail.com> <1429719261-18024-2-git-send-email-ricardo.ribalda@gmail.com> <20150422164701.GJ20701@google.com> From: Ricardo Ribalda Delgado Date: Thu, 23 Apr 2015 10:06:36 +0200 Message-ID: Subject: Re: [PATCH v3 1/4] kernel/resource: Invalid memory access in __release_resource To: Bjorn Helgaas Cc: Greg Kroah-Hartman , Grant Likely , Rob Herring , Andrew Morton , Jakub Sitnicki , Vivek Goyal , Jiang Liu , Mike Travis , Thierry Reding , LKML , "devicetree@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bjorn On Wed, Apr 22, 2015 at 6:47 PM, Bjorn Helgaas wrote: > > I'm not really a fan of this. The NULL pointer oops is a very good clue > all by itself, and it doesn't require any extra code here. It is a pointer to 0x30. For some reason my platform can handle a couple of oops, but if I get a fair amount of them in a short period of time, the whole thing crashes and debugging gets complicated. (no access to dmesg or remote debugging). Therefore this particular bug gave me a bad time. Now that we have located the root of the problem and solved the problem from the root, this particular error will never be hit. I just wanted to save somebody else's time with this patch. All that said, if the other patches are applied, my platform works completely fine. So it is completely your call to accept this or not :) I will resend the patchset without this patch Thanks! -- Ricardo Ribalda