From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
To: Olliver Schinagl <oliver@schinagl.nl>
Cc: Jacek Anaszewski <j.anaszewski@samsung.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Richard Purdie <rpurdie@rpsys.net>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
Peter Meerwald <pmeerw@pmeerw.net>
Subject: Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups
Date: Tue, 19 Apr 2016 15:42:51 +0200 [thread overview]
Message-ID: <CAPybu_2uZqR4exnS08taVYyr=ziK+EzuJy+_FxhbtqSiOE_=mw@mail.gmail.com> (raw)
In-Reply-To: <57163252.5090000@schinagl.nl>
Hi again
On Tue, Apr 19, 2016 at 3:27 PM, Olliver Schinagl <oliver@schinagl.nl> wrote:
> Hey Ricardo,
> Without actually looking at the code right now, but the driver does a
> read/modify/write on the register, and a register is shared among several
> leds. So in that regard, it makes sense and I don't think it's very
> expensive to move the lock, since we have to lock for the write a few lines
> down anyway.
Actually, the code is only making sure that PCA963X_MODE2_DMBLNK is
on. It is never cleared afterwards.
It will be great if you could set that bit on probe and remove those
two lines and verify that it works on real hardware.
The move of the lock can be a bit expensive. i2c writes can take a
while to be performed, this is why only ledout was protected
initially.
Best regards
next prev parent reply other threads:[~2016-04-19 13:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 7:40 [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups Olliver Schinagl
2016-04-19 7:40 ` [PATCH 1/6] leds: pca963x: Alphabetize headers Olliver Schinagl
2016-04-19 7:40 ` [PATCH 2/6] leds: pca963x: Lock i2c r/w access Olliver Schinagl
2016-04-19 7:40 ` [PATCH 3/6] leds: pca963x: Add defines and remove some magic values Olliver Schinagl
2016-04-19 8:16 ` kbuild test robot
2016-04-19 7:40 ` [PATCH 4/6] leds: pca963x: Reduce " Olliver Schinagl
2016-04-19 7:40 ` [PATCH 5/6] leds: pca963x: Inform the output that it is inverted Olliver Schinagl
2016-04-21 15:07 ` Rob Herring
2016-04-22 12:38 ` Olliver Schinagl
2016-04-22 13:09 ` Rob Herring
2016-04-22 15:44 ` Olliver Schinagl
2016-04-19 7:40 ` [PATCH 6/6] leds: pca963x: Remove whitespace and checkpatch problems Olliver Schinagl
2016-04-19 9:23 ` [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups Jacek Anaszewski
2016-04-19 9:39 ` Olliver Schinagl
2016-04-19 11:18 ` Ricardo Ribalda Delgado
2016-04-19 13:27 ` Olliver Schinagl
2016-04-19 13:42 ` Ricardo Ribalda Delgado [this message]
2016-04-20 7:21 ` Olliver Schinagl
2016-04-20 8:01 ` Ricardo Ribalda Delgado
2016-04-20 8:51 ` Olliver Schinagl
2016-04-20 8:56 ` Ricardo Ribalda Delgado
2016-04-20 9:06 ` Olliver Schinagl
2016-04-20 9:17 ` Ricardo Ribalda Delgado
2016-04-20 10:12 ` Olliver Schinagl
2016-04-22 7:21 ` Olliver Schinagl
2016-05-12 9:04 ` Olliver Schinagl
2016-05-12 9:07 ` Olliver Schinagl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPybu_2uZqR4exnS08taVYyr=ziK+EzuJy+_FxhbtqSiOE_=mw@mail.gmail.com' \
--to=ricardo.ribalda@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=j.anaszewski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=oliver@schinagl.nl \
--cc=pawel.moll@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).