From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932712AbcDTI5R (ORCPT ); Wed, 20 Apr 2016 04:57:17 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:36293 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932113AbcDTI5M (ORCPT ); Wed, 20 Apr 2016 04:57:12 -0400 MIME-Version: 1.0 In-Reply-To: <5717430D.30702@schinagl.nl> References: <1461051650-18824-1-git-send-email-oliver@schinagl.nl> <5715F927.3030102@samsung.com> <5715FCE8.7080106@schinagl.nl> <57163252.5090000@schinagl.nl> <57172DFA.9030107@schinagl.nl> <5717430D.30702@schinagl.nl> From: Ricardo Ribalda Delgado Date: Wed, 20 Apr 2016 10:56:51 +0200 Message-ID: Subject: Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups To: Olliver Schinagl Cc: Jacek Anaszewski , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Richard Purdie , "devicetree@vger.kernel.org" , LKML , Linux LED Subsystem , Peter Meerwald Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On Wed, Apr 20, 2016 at 10:51 AM, Olliver Schinagl wrote: >> As I said before, the reason for this proposal is that the code NEVER >> clears PCA963X_MODE2_DMBLNK, only sets it. >> Unfortunately I do not have the HW to test this change. > > The code never clears it, but the hardware does. So we have to set it > everytime we enable blink. Ok, that was the part I was missing. I was not aware that the hw was clearing it. Saving mode2 sounds like a good compromise then. But I still believe that we should limit the lock to ledout. No matter what we do, we cannot have two leds blinking at different frequencies on the same chip. Regards -- Ricardo Ribalda