linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ricardo Ribalda Delgado <ribalda@kernel.org>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: linux-media <linux-media@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] v4l2-ctl: Support setting V4L2_CTRL_TYPE_AREA controls
Date: Mon, 4 Nov 2019 12:21:33 +0100	[thread overview]
Message-ID: <CAPybu_3DQbmuamHmTXWnF15B1tzPzf1Sh_YJe6VS-Uk8z81q1Q@mail.gmail.com> (raw)
In-Reply-To: <31815641-550c-88ab-c037-2e743cea59b3@xs4all.nl>

Hi Hans

Sure I will fix this. Shall I resend it once you have updated the
headers on v4l-utils?

Best regards

On Mon, Nov 4, 2019 at 10:41 AM Hans Verkuil <hverkuil-cisco@xs4all.nl> wrote:
>
> On 11/1/19 12:25 PM, Ricardo Ribalda Delgado wrote:
> > $ v4l2-ctl  -d /dev/video1  -c area=123123x233
> >
> > Signed-off-by: Ricardo Ribalda Delgado <ribalda@kernel.org>
> > ---
> >  utils/v4l2-ctl/v4l2-ctl-common.cpp | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/utils/v4l2-ctl/v4l2-ctl-common.cpp b/utils/v4l2-ctl/v4l2-ctl-common.cpp
> > index 95339561..676b05e0 100644
> > --- a/utils/v4l2-ctl/v4l2-ctl-common.cpp
> > +++ b/utils/v4l2-ctl/v4l2-ctl-common.cpp
> > @@ -973,6 +973,10 @@ void common_set(cv4l_fd &_fd)
> >                                       strncpy(ctrl.string, iter->second.c_str(), qc.maximum);
> >                                       ctrl.string[qc.maximum] = 0;
> >                                       break;
> > +                             case V4L2_CTRL_TYPE_AREA:
> > +                                     sscanf(iter->second.c_str(), "%dx%d",
>
> Use %ux%u since these are unsigned values.
>
> Regards,
>
>         Hans
>
> > +                                            &ctrl.p_area->width, &ctrl.p_area->height);
> > +                                     break;
> >                               default:
> >                                       fprintf(stderr, "%s: unsupported payload type\n",
> >                                                       qc.name);
> >
>

  reply	other threads:[~2019-11-04 11:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-01 11:25 [PATCH 1/4] HEADERS, do not merge!!!! Ricardo Ribalda Delgado
2019-11-01 11:25 ` [PATCH 2/4] v4l2-ctl: Support query V4L2_CTRL_TYPE_AREA controls Ricardo Ribalda Delgado
2019-11-01 11:25 ` [PATCH 3/4] v4l2-ctl: Support getting " Ricardo Ribalda Delgado
2019-11-01 11:25 ` [PATCH 4/4] v4l2-ctl: Support setting " Ricardo Ribalda Delgado
2019-11-04  9:41   ` Hans Verkuil
2019-11-04 11:21     ` Ricardo Ribalda Delgado [this message]
2019-11-04 11:52       ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPybu_3DQbmuamHmTXWnF15B1tzPzf1Sh_YJe6VS-Uk8z81q1Q@mail.gmail.com \
    --to=ribalda@kernel.org \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).