From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
To: Grant Likely <grant.likely@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jakub Sitnicki <jsitnicki@gmail.com>,
Vivek Goyal <vgoyal@redhat.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Jiang Liu <jiang.liu@linux.intel.com>,
Mike Travis <travis@sgi.com>, Thierry Reding <treding@nvidia.com>,
LKML <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v5 2/4] base/platform: Continue on insert_resource() error
Date: Thu, 4 Jun 2015 10:47:07 +0200 [thread overview]
Message-ID: <CAPybu_3gYAZTHHYD7y2MdKFJBwDVyb5a9fwQqEMc+0xmKSTpKg@mail.gmail.com> (raw)
In-Reply-To: <20150604075425.BC0E7C406CA@trevor.secretlab.ca>
Hello Grant
On Thu, Jun 4, 2015 at 9:54 AM, Grant Likely <grant.likely@linaro.org> wrote:
>
> I'm pretty sure this is going to break some platforms. I described it in
> my earlier email today, but I'll summarize here too since this is the
> latest patch set.
The version that is in stable is also broken. Unloading the device
tree crashes the device completely.
>
> Making this change allows the registration of devices to continue, but
> it will still break device drivers that do a request_resource() on a
> region that another device managed to claim with insert_resource(). The
> only way around this is to not do insert_resource() at all, or to remove
> the request_resource() from all drivers (not feasible).
If we do not do insert_resource(), we will have the crash on
release_resource() and a lot! of code duplication.
>
> I think we have to deal with it by making resource insertion optional.
> I'd like to make the default be to do the insertion, and be able to
> blacklist platforms that have issues.
What about, making the request_resource a little bit more clever.
Something like:
If the resouce is not taken
return ok
if the resource is taken:
If the requester or the current owner of the resource are device tree devices
show a warning and continue.
else
return error
Wouldn't this fix the issue and guide the developers towards a proper
fix for their platform, instead of just encourage them to blacklist
their platform?
Thanks!
>
> g.
>
--
Ricardo Ribalda
next prev parent reply other threads:[~2015-06-04 8:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 7:31 [PATCH v5 0/4] Fix null pointer deference when calling of_platform_depopulate Ricardo Ribalda Delgado
2015-05-26 7:31 ` [PATCH v5 1/4] base/platform: Only insert MEM and IO resources Ricardo Ribalda Delgado
2015-05-26 7:31 ` [PATCH v5 2/4] base/platform: Continue on insert_resource() error Ricardo Ribalda Delgado
2015-06-04 7:54 ` Grant Likely
2015-06-04 8:47 ` Ricardo Ribalda Delgado [this message]
2015-06-04 22:07 ` Rob Herring
2015-05-26 7:31 ` [PATCH v5 3/4] of/platform: Use platform_device interface Ricardo Ribalda Delgado
2015-05-26 7:31 ` [PATCH v5 4/4] base/platform: Remove code duplication Ricardo Ribalda Delgado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPybu_3gYAZTHHYD7y2MdKFJBwDVyb5a9fwQqEMc+0xmKSTpKg@mail.gmail.com \
--to=ricardo.ribalda@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jiang.liu@linux.intel.com \
--cc=jsitnicki@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=travis@sgi.com \
--cc=treding@nvidia.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).