From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 988FDC433DF for ; Tue, 23 Jun 2020 22:52:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 73CEB20780 for ; Tue, 23 Jun 2020 22:52:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="QWQq5RDG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388030AbgFWWwV (ORCPT ); Tue, 23 Jun 2020 18:52:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387586AbgFWWwT (ORCPT ); Tue, 23 Jun 2020 18:52:19 -0400 Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EAA87C061573 for ; Tue, 23 Jun 2020 15:30:02 -0700 (PDT) Received: by mail-qk1-x742.google.com with SMTP id l6so82221qkc.6 for ; Tue, 23 Jun 2020 15:30:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=eaPZgevT2CpnMUUM+GmJp3ep826/Vu8USLaTW1XXGMw=; b=QWQq5RDGTnwX3WnqevkbBWkazZh8odQfl932pZ3UbY0dCGQegngCVgx95WkZVr6BnO 65ZIHrqmao0uN6GenF/4y4CW/OcmRkJXPzNKvRDmcXb7ZC7erhMA93XdDlwZ6l3vBF1f GxHnbtJycGks7s5BOlmqFZKUgWd+grPqJxni7VbGgMA8zUApStYLutkeT0rlrIBOHI08 3Cql55Igvie4tl+36H8VyJCyQqgV0RR76/eI9IGW+so79IAWGhwE2UWaR81yETHij9Y+ SmTPqigtUan78yqLcCU63BGCxEuDALLbhJ89gWLbCtwqVG4DBdoucn263Wyo8rE2fDql 8TgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=eaPZgevT2CpnMUUM+GmJp3ep826/Vu8USLaTW1XXGMw=; b=YxD/G9XXwYlCs8xVnxMAHx1OeTXUd8Aqf8l3WCZLmIGE6g8s6CTHpdcLVH+Cem+c0d wKwOiXLvQvQUUHQ1R8n2Sp7zLJqaE0OGeEFnHkaod/7ZKa4G6tcrYGzNKEZ1f1jImYJA BQkJbfSqEPICyhoKVbaH6Wy61x1+ELYSEPI5TCEyhVi+E14/Wr4Y4ZdR8+Yzwj+ew+Xy AcMEx/5pUsWaus793TOsAXDLmfoQ7bUA+6Y2KYRCXw6oerjhSkdJvoIK4agXUIsm+2W1 rg8QnJD6rqgrkO6OCR0QqiRO+JSWYsGj29tvXwCmREWzP7xuNu3f5z2cD1SjCRxqtZK7 sbZQ== X-Gm-Message-State: AOAM532/WNB6xGOaCMp7bQVqT6Mn+6L8y9hbsZP9X4WNNRl4Q/OqWJpv rsUbxMJhoETpP/WTb+qORvcvSg== X-Google-Smtp-Source: ABdhPJwk15aS1BWBT2iEbMasfTOJdZ8L9kYNLCwIeSkqEjFH3YWtkSFhBbq1XdpbSIFrixrWCXSxpg== X-Received: by 2002:a37:5ac1:: with SMTP id o184mr6623255qkb.498.1592951401983; Tue, 23 Jun 2020 15:30:01 -0700 (PDT) Received: from ?IPv6:2600:1000:b118:1dc0:18a:ef24:8000:54d8? ([2600:1000:b118:1dc0:18a:ef24:8000:54d8]) by smtp.gmail.com with ESMTPSA id 207sm1764428qki.134.2020.06.23.15.30.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jun 2020 15:30:01 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Qian Cai Mime-Version: 1.0 (1.0) Subject: Re: [PATCH] mm: Track mmu notifiers in fs_reclaim_acquire/release Date: Tue, 23 Jun 2020 18:29:58 -0400 Message-Id: References: Cc: Intel Graphics Development , DRI Development , LKML , amd-gfx list , =?utf-8?Q?Thomas_Hellstr=C3=B6m?= , Andrew Morton , Jason Gunthorpe , Linux MM , linux-rdma , Maarten Lankhorst , =?utf-8?Q?Christian_K=C3=B6nig?= , Daniel Vetter , linux-xfs@vger.kernel.org In-Reply-To: To: Daniel Vetter X-Mailer: iPhone Mail (17F80) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Jun 23, 2020, at 6:13 PM, Daniel Vetter wrote: >=20 > Ok I tested this. I can't use your script to repro because > - I don't have a setup with xfs, and the splat points at an issue in xfs > - reproducing lockdep splats in shrinker callbacks is always a bit tricky What=E2=80=99s xfs setup are you talking about? This is simple xfs rootfs an= d then trigger swapping. Nothing tricky here as it hit on multiple machines w= ithin a few seconds on linux-next. > Summary: Everything is working as expected, there's no change in the > lockdep annotations. > I really think the problem is that either your testcase doesn't hit > the issue reliably enough, or that you're not actually testing the > same kernels and there's some other changes (xfs most likely, but > really it could be anywhere) which is causing this regression. I'm > rather convinced now after this test that it's not my stuff. Well, the memory pressure workloads have been running for years on daily lin= ux-next builds and never saw this one happened once. Also, the reverting is O= NLY to revert your patch on the top of linux-next will stop the splat, so th= ere is no not testing the same kernel at all.=