linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] seccomp update for v5.18-rc1
Date: Mon, 21 Mar 2022 21:54:32 -0700	[thread overview]
Message-ID: <CF7E8A5F-F80A-4FF2-8B0A-028C475DD045@chromium.org> (raw)
In-Reply-To: <CAHk-=whtmuyBzuHULNWcP3==ixcb8yCb-QVEokZeDJESG_TEbA@mail.gmail.com>



On March 21, 2022 7:45:51 PM PDT, Linus Torvalds <torvalds@linux-foundation.org> wrote:
>On Mon, Mar 21, 2022 at 8:07 AM Kees Cook <keescook@chromium.org> wrote:
>>
>> Please pull this tiny seccomp update for v5.18-rc1.
>
>Well, that *really* didn't work at all.
>
>  In file included from samples/seccomp/dropper.c:29:
>  usr/include/linux/ptrace.h:50: warning: "PTRACE_GETREGSET" redefined
>     50 | #define PTRACE_GETREGSET        0x4204
>        |
>   In file included from samples/seccomp/dropper.c:24:
>  /usr/include/sys/ptrace.h:153: note: this is the location of the
>previous definition
>    153 | #define PTRACE_GETREGSET PTRACE_GETREGSET
>        |
>  [...]
>
>.. and a lot of similar warnings.

Oh, eww. Apologies! That didn't happen for my builders, but yeah, that code is super fragile anyway, so this just confirms my suspicion that the changes weren't useful. I'll drop it from my tree.

-- 
Kees Cook

      reply	other threads:[~2022-03-22  4:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-21 15:06 [GIT PULL] seccomp update for v5.18-rc1 Kees Cook
2022-03-22  2:45 ` Linus Torvalds
2022-03-22  4:54   ` Kees Cook [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CF7E8A5F-F80A-4FF2-8B0A-028C475DD045@chromium.org \
    --to=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).