From: "Marciniszyn, Mike" <mike.marciniszyn@cornelisnetworks.com>
To: "José Expósito" <jose.exposito89@gmail.com>,
"Dalessandro, Dennis" <dennis.dalessandro@cornelisnetworks.com>
Cc: "dledford@redhat.com" <dledford@redhat.com>,
"jgg@ziepe.ca" <jgg@ziepe.ca>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] IB/qib: Fix memory leak in qib_user_sdma_queue_pkts
Date: Wed, 8 Dec 2021 18:07:45 +0000 [thread overview]
Message-ID: <CH0PR01MB715354CD468DD7B80CD2A149F26F9@CH0PR01MB7153.prod.exchangelabs.com> (raw)
In-Reply-To: <20211208175238.29983-1-jose.exposito89@gmail.com>
> Subject: [PATCH] IB/qib: Fix memory leak in qib_user_sdma_queue_pkts
>
> Addresses-Coverity-ID: 1493352 ("Resource leak")
> Signed-off-by: José Expósito <jose.exposito89@gmail.com>
> ---
> drivers/infiniband/hw/qib/qib_user_sdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/qib/qib_user_sdma.c
> b/drivers/infiniband/hw/qib/qib_user_sdma.c
> index ac11943a5ddb..bf2f30d67949 100644
> --- a/drivers/infiniband/hw/qib/qib_user_sdma.c
> +++ b/drivers/infiniband/hw/qib/qib_user_sdma.c
> @@ -941,7 +941,7 @@ static int qib_user_sdma_queue_pkts(const struct
> qib_devdata *dd,
> &addrlimit) ||
> addrlimit > type_max(typeof(pkt->addrlimit))) {
> ret = -EINVAL;
> - goto free_pbc;
> + goto free_pkt;
> }
> pkt->addrlimit = addrlimit;
>
> --
Thanks for catching my mistake!
Mike
Acked-by: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
Fixes d39bf40e55e6 ("IB/qib: Protect from buffer overflow in struct qib_user_sdma_pkt fields"):
next prev parent reply other threads:[~2021-12-08 18:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 17:52 [PATCH] IB/qib: Fix memory leak in qib_user_sdma_queue_pkts José Expósito
2021-12-08 18:07 ` Marciniszyn, Mike [this message]
2021-12-15 0:07 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CH0PR01MB715354CD468DD7B80CD2A149F26F9@CH0PR01MB7153.prod.exchangelabs.com \
--to=mike.marciniszyn@cornelisnetworks.com \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=jose.exposito89@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).