From: "Marciniszyn, Mike" <mike.marciniszyn@cornelisnetworks.com>
To: Tuo Li <islituo@gmail.com>,
"Dalessandro, Dennis" <dennis.dalessandro@cornelisnetworks.com>,
"dledford@redhat.com" <dledford@redhat.com>,
"jgg@ziepe.ca" <jgg@ziepe.ca>
Cc: "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"baijiaju1990@gmail.com" <baijiaju1990@gmail.com>,
TOTE Robot <oslab@tsinghua.edu.cn>
Subject: RE: [PATCH v3] IB/hfi1: Fix possible null-pointer dereference in _extend_sdma_tx_descs()
Date: Mon, 9 Aug 2021 13:15:43 +0000 [thread overview]
Message-ID: <CH0PR01MB71535B0EAF68AEDAA3D45D97F2F69@CH0PR01MB7153.prod.exchangelabs.com> (raw)
In-Reply-To: <20210806133029.194964-1-islituo@gmail.com>
> Fixes: 7724105686e7 ("IB/hfi1: add driver files")
> Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
> Signed-off-by: Tuo Li <islituo@gmail.com>
> ---
> v3:
> * Add fixes line.
> Thank Jason Gunthorpe for helpful advice.
> v2:
> * Assign the return value of kmalloc_array() to a local variable and then check
> it instead of assigning 0 to tx->num_desc when memory allocation fails.
> Thank Mike Marciniszyn for helpful advice.
Thanks!
I'm curious, did you find this with some fault injection testing?
Tested-by: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
Acked-by: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
next prev parent reply other threads:[~2021-08-09 13:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 13:30 [PATCH v3] IB/hfi1: Fix possible null-pointer dereference in _extend_sdma_tx_descs() Tuo Li
2021-08-09 13:15 ` Marciniszyn, Mike [this message]
2021-08-19 14:37 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CH0PR01MB71535B0EAF68AEDAA3D45D97F2F69@CH0PR01MB7153.prod.exchangelabs.com \
--to=mike.marciniszyn@cornelisnetworks.com \
--cc=baijiaju1990@gmail.com \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=dledford@redhat.com \
--cc=islituo@gmail.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=oslab@tsinghua.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).