From: Yash Shah <yash.shah@sifive.com>
To: Marc Zyngier <maz@kernel.org>,
"Paul Walmsley ( Sifive)" <paul.walmsley@sifive.com>
Cc: "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"palmer@dabbelt.com" <palmer@dabbelt.com>,
"aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"jason@lakedaemon.net" <jason@lakedaemon.net>,
"bmeng.cn@gmail.com" <bmeng.cn@gmail.com>,
"atish.patra@wdc.com" <atish.patra@wdc.com>,
Sagar Kadam <sagar.kadam@sifive.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sachin Ghadi <sachin.ghadi@sifive.com>
Subject: RE: [PATCH v4 0/6] GPIO & Hierarchy IRQ support for HiFive Unleashed
Date: Tue, 21 Jan 2020 08:53:26 +0000 [thread overview]
Message-ID: <CH2PR13MB33684A3DB50725FC496C26F18C0D0@CH2PR13MB3368.namprd13.prod.outlook.com> (raw)
In-Reply-To: <8dcb52c94eb5a585f6cf052c18571805@kernel.org>
> -----Original Message-----
> From: Marc Zyngier <maz@kernel.org>
> Sent: 20 January 2020 14:40
> To: Yash Shah <yash.shah@sifive.com>
> Cc: linus.walleij@linaro.org; bgolaszewski@baylibre.com;
> robh+dt@kernel.org; mark.rutland@arm.com; palmer@dabbelt.com; Paul
> Walmsley ( Sifive) <paul.walmsley@sifive.com>; aou@eecs.berkeley.edu;
> tglx@linutronix.de; jason@lakedaemon.net; bmeng.cn@gmail.com;
> atish.patra@wdc.com; Sagar Kadam <sagar.kadam@sifive.com>; linux-
> gpio@vger.kernel.org; devicetree@vger.kernel.org; linux-
> riscv@lists.infradead.org; linux-kernel@vger.kernel.org; Sachin Ghadi
> <sachin.ghadi@sifive.com>
> Subject: Re: [PATCH v4 0/6] GPIO & Hierarchy IRQ support for HiFive
> Unleashed
>
> On 2019-12-10 12:11, Yash Shah wrote:
> > This patch series adds GPIO drivers, DT documentation and DT nodes for
> > HiFive Unleashed board. The gpio patches are mostly based on Wesley's
> > patch.
> > The patchset also adds hierarchy irq domain support as it is required
> > by this gpio driver. It also includes the irqdomain patch to introduce
> > irq_domain_translate_onecell() and irq-nvic driver patch to use this
> > newly introduced function.
> >
> > This patchset is based on Linux 5.4-rc6 and tested on HiFive Unleashed
> > board
> >
> > Changes:
> > v4 vs v3:
> > - Rename the DT yaml document to more standard naming
> > (sifive,gpio.yaml)
> > - Drop "clock-names" property from yaml document
> > - Add "minItems" to "interrupts" node in yaml
> >
> > v3 vs v2:
> > - Include patch for irq-nvic driver to use
> > irq_domain_translate_onecell
> > - Remove unnecessary inclusion of header files
> > - Use a single prefix for all symbols in this driver
> > - Rename the "enabled" field of struct sifive_gpio to "irq_state"
> > - Remove unused variables and locking from probe()
> > - Other minor changes
> >
> > v2 vs v1:
> > - Add patch to introduce irq_domain_translate_onecell() and use it in
> > the sifive PLIC driver
> > - Drop the usage of own locks, instead use internal bgpio_locks
> > - Consistently use regmap for register access throughout the gpio code
> > - Convert the GPIO DT documentation into a json schema
> > - Other minor changes based upon feedback received on v1
> >
> > v1 vs RFC:
> > Incorporated below changes as suggested by Linus Walleij on RFC
> > version of this patchset[0]
> > - Dropped PWM patches as they are already merged.
> > - Include "GPIO_GENERIC" and "REGMAP_MMIO" in Kconfig select option
> > - Remove unwanted inclusion of header files
> > - Use regmap MMIO instead of customised sifive_assign_bit()
> > - Use GPIOLIB_GENERIC and bgpio_init() to set up the accessors
> > - Use hierarchical irqdomain
> >
> > [0]
> > https://lore.kernel.org/linux-
> riscv/20181010123519.RVexDppaPFpIWl7QU_h
> > pP8tc5qqWPJgeuLYn0FaGbeQ@z/
> >
> > Yash Shah (6):
> > genirq: introduce irq_domain_translate_onecell
> > irqchip: nvic: Use irq_domain_translate_onecell instead of custom
> > func
> > irqchip: sifive: Support hierarchy irq domain
> > gpio: sifive: Add DT documentation for SiFive GPIO
> > gpio: sifive: Add GPIO driver for SiFive SoCs
> > riscv: dts: Add DT support for SiFive FU540 GPIO driver
>
> I've queued the first 5 patches. The last one should go via the corresponding
> platform tree.
Thanks.
@Paul, Are you going to merge the last patch (DT support for GPIO) or you want me to rebase and send it separately?
- Yash
>
> Thanks,
>
> M.
> --
> Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2020-01-21 8:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 11:11 [PATCH v4 0/6] GPIO & Hierarchy IRQ support for HiFive Unleashed Yash Shah
2019-12-10 11:11 ` [PATCH v4 1/6] genirq: introduce irq_domain_translate_onecell Yash Shah
2020-01-24 19:11 ` [tip: irq/core] genirq: Introduce irq_domain_translate_onecell tip-bot2 for Yash Shah
2019-12-10 11:11 ` [PATCH v4 2/6] irqchip: nvic: Use irq_domain_translate_onecell instead of custom func Yash Shah
2020-01-24 19:11 ` [tip: irq/core] irqchip/nvic: " tip-bot2 for Yash Shah
2019-12-10 11:11 ` [PATCH v4 3/6] irqchip: sifive: Support hierarchy irq domain Yash Shah
2020-01-24 19:11 ` [tip: irq/core] irqchip/sifive-plic: Support irq domain hierarchy tip-bot2 for Yash Shah
2019-12-10 11:11 ` [PATCH v4 4/6] gpio: sifive: Add DT documentation for SiFive GPIO Yash Shah
2019-12-18 20:51 ` Rob Herring
2020-01-24 19:11 ` [tip: irq/core] gpio/sifive: " tip-bot2 for Yash Shah
2019-12-10 11:11 ` [PATCH v4 5/6] gpio: sifive: Add GPIO driver for SiFive SoCs Yash Shah
2020-01-24 19:11 ` [tip: irq/core] gpio/sifive: " tip-bot2 for Yash Shah
2019-12-10 11:11 ` [PATCH v4 6/6] riscv: dts: Add DT support for SiFive FU540 GPIO driver Yash Shah
2020-01-20 9:09 ` [PATCH v4 0/6] GPIO & Hierarchy IRQ support for HiFive Unleashed Marc Zyngier
2020-01-21 8:53 ` Yash Shah [this message]
2020-01-29 15:00 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CH2PR13MB33684A3DB50725FC496C26F18C0D0@CH2PR13MB3368.namprd13.prod.outlook.com \
--to=yash.shah@sifive.com \
--cc=aou@eecs.berkeley.edu \
--cc=atish.patra@wdc.com \
--cc=bgolaszewski@baylibre.com \
--cc=bmeng.cn@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=sachin.ghadi@sifive.com \
--cc=sagar.kadam@sifive.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).