From: "Rui Miguel Silva" <rmfrfs@gmail.com>
To: <cgel.zte@gmail.com>
Cc: <johan@kernel.org>, <elder@kernel.org>,
<gregkh@linuxfoundation.org>, <greybus-dev@lists.linaro.org>,
<linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
"Minghao Chi" <chi.minghao@zte.com.cn>,
"Zeal Robot" <zealci@zte.com.cn>
Subject: Re: [PATCH] staging: greybus: Remove redundant 'flush_workqueue()' calls
Date: Thu, 10 Feb 2022 11:43:48 +0000 [thread overview]
Message-ID: <CHSC9NU74XQV.2L2R0WCT1UZLA@arch-thunder> (raw)
In-Reply-To: <20220210060205.1607792-1-chi.minghao@zte.com.cn>
Hey Minghao,
Many thanks for the patch.
On Thu Feb 10, 2022 at 6:02 AM WET, wrote:
> From: Minghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn>
>
> 'destroy_workqueue()' already drains the queue before destroying it,
> so there is no need to flush it explicitly.
>
> Remove the redundant 'flush_workqueue()' calls.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn>
LGTM.
Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com>
Cheers,
Rui
> ---
> drivers/staging/greybus/sdio.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/sdio.c b/drivers/staging/greybus/sdio.c
> index 37bf04c22dbc..25bee5335c70 100644
> --- a/drivers/staging/greybus/sdio.c
> +++ b/drivers/staging/greybus/sdio.c
> @@ -858,7 +858,6 @@ static void gb_sdio_remove(struct gbphy_device *gbphy_dev)
> gb_connection_set_data(connection, NULL);
> mutex_unlock(&host->lock);
>
> - flush_workqueue(host->mrq_workqueue);
> destroy_workqueue(host->mrq_workqueue);
> gb_connection_disable_rx(connection);
> mmc_remove_host(mmc);
> --
> 2.25.1
prev parent reply other threads:[~2022-02-10 11:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 6:02 [PATCH] staging: greybus: Remove redundant 'flush_workqueue()' calls cgel.zte
2022-02-10 11:43 ` Rui Miguel Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CHSC9NU74XQV.2L2R0WCT1UZLA@arch-thunder \
--to=rmfrfs@gmail.com \
--cc=cgel.zte@gmail.com \
--cc=chi.minghao@zte.com.cn \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).