From: "Barnabás Pőcze" <pobrn@protonmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Coiby Xu <coiby.xu@gmail.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
Helmut Stult <helmut.stult@schinfo.de>,
Baq Domalaq <domalak@gmail.com>, Pedro Ribeiro <pedrib@gmail.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] HID: i2c-hid: add polling mode based on connected GPIO chip's pin status
Date: Wed, 09 Dec 2020 15:38:11 +0000 [thread overview]
Message-ID: <CHTa60htGkyHzaM2En-TPXqyk1v3jVJUolGOMfHphEr_mMG5Z5f2K4mHTFilYR73bgpGEKNcGM1LFstJ7UhvbuJrgqr1-J2-YTZJenhK83Q=@protonmail.com> (raw)
In-Reply-To: <X9B2B6KuzbP8Is+W@kroah.com>
2020. december 9., szerda 8:00 keltezéssel, Greg KH írta:
> On Tue, Dec 08, 2020 at 09:59:20PM +0000, Barnabás Pőcze wrote:
>
> > 2020. november 25., szerda 16:07 keltezéssel, Greg KH írta:
> >
> > > [...]
> > >
> > > > +static u8 polling_mode;
> > > > +module_param(polling_mode, byte, 0444);
> > > > +MODULE_PARM_DESC(polling_mode, "How to poll (default=0) - 0 disabled; 1 based on GPIO pin's status");
> > >
> > > Module parameters are for the 1990's, they are global and horrible to
> > > try to work with. You should provide something on a per-device basis,
> > > as what happens if your system requires different things here for
> > > different devices? You set this for all devices :(
> > > [...]
> >
> > Hi
> > do you think something like what the usbcore has would be better?
> > A module parameter like "quirks=<vendor-id>:<product-id>:<flags>[,<vendor-id>:<product-id>:<flags>]*"?
>
> Not really, that's just for debugging, and asking users to test
> something, not for a final solution to anything.
My understanding is that this polling mode option is by no means intended
as a final solution, it's purely for debugging/fallback:
"Polling mode could be a fallback solution for enthusiastic Linux users
when they have a new laptop. It also acts like a debugging feature. If
polling mode works for a broken touchpad, we can almost be certain
the root cause is related to the interrupt or power setting."
What would you suggest instead of the module parameter?
Regards,
Barnabás Pőcze
next prev parent reply other threads:[~2020-12-09 15:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 14:10 [PATCH v4] HID: i2c-hid: add polling mode based on connected GPIO chip's pin status Coiby Xu
2020-11-25 15:07 ` Greg KH
2020-12-08 21:59 ` Barnabás Pőcze
2020-12-09 7:00 ` Greg KH
2020-12-09 15:38 ` Barnabás Pőcze [this message]
2020-12-09 15:44 ` Greg KH
2020-12-26 4:29 ` Coiby Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CHTa60htGkyHzaM2En-TPXqyk1v3jVJUolGOMfHphEr_mMG5Z5f2K4mHTFilYR73bgpGEKNcGM1LFstJ7UhvbuJrgqr1-J2-YTZJenhK83Q=@protonmail.com' \
--to=pobrn@protonmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=coiby.xu@gmail.com \
--cc=domalak@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=helmut.stult@schinfo.de \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pedrib@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).