From: "Sireesh Kodali" <sireeshkodali1@gmail.com>
To: "Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
<linux-remoteproc@vger.kernel.org>
Cc: <linux-arm-msm@vger.kernel.org>,
<~postmarketos/upstreaming@lists.sr.ht>,
<bjorn.andersson@linaro.org>, <devicetree@vger.kernel.org>,
<phone-devel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Andy Gross" <agross@kernel.org>,
"Mathieu Poirier" <mathieu.poirier@linaro.org>
Subject: Re: [PATCH 1/9] remoteproc: qcom: pas: Add MSM8953 ADSP PIL support
Date: Thu, 12 May 2022 16:09:17 +0530 [thread overview]
Message-ID: <CJXPVU06SN65.296G7A6NC7PTG@skynet-linux> (raw)
In-Reply-To: <b86b5ba5-91ab-592a-5b4b-10dc738116ca@linaro.org>
On Wed May 11, 2022 at 10:21 PM IST, Dmitry Baryshkov wrote:
> On 11/05/2022 19:15, Sireesh Kodali wrote:
> > Add support for the Audio DSP PIL found on the Qualcomm MSM8953
> > platform. The same configuration is used on all SoCs based on the
> > MSM8953 platform (SDM450, SDA450, SDM625, SDM632, APQ8053).
> >
> > Signed-off-by: Sireesh Kodali <sireeshkodali1@gmail.com>
> > ---
> > drivers/remoteproc/qcom_q6v5_pas.c | 31 ++++++++++++++++++++++++++++++
> > 1 file changed, 31 insertions(+)
> >
> > diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> > index 1ae47cc153e5..4dcb714a1468 100644
> > --- a/drivers/remoteproc/qcom_q6v5_pas.c
> > +++ b/drivers/remoteproc/qcom_q6v5_pas.c
> > @@ -617,7 +617,37 @@ static const struct adsp_data sm8350_adsp_resource = {
> > .ssctl_id = 0x14,
> > };
> >
> > +static const struct adsp_data msm8953_adsp_resource = {
> > + .crash_reason_smem = 423,
> > + .firmware_name = "adsp.mdt",
> > + .pas_id = 1,
> > + .has_aggre2_clk = false,
> > + .auto_boot = true,
> > + .proxy_pd_names = (char*[]){
> > + "cx",
> > + NULL,
> > + },
> > + .ssr_name = "lpass",
> > + .sysmon_name = "adsp",
> > + .ssctl_id = 0x14,
> > +};
> > +
>
> Also it looks like this item is identical to msm8996_adsp_resources. So
> you can existing structure instead.
>
Yes, the msm8953 item is identical to the msm8996_adsp_resource. I
wasn't aware that we could re-use structs like this, I will do that in
v2 of this patch
> > static const struct adsp_data msm8996_adsp_resource = {
> > + .crash_reason_smem = 423,
> > + .firmware_name = "adsp.mdt",
> > + .pas_id = 1,
> > + .has_aggre2_clk = false,
> > + .auto_boot = true,
> > + .proxy_pd_names = (char*[]){
> > + "cx",
> > + NULL,
> > + },
> > + .ssr_name = "lpass",
> > + .sysmon_name = "adsp",
> > + .ssctl_id = 0x14,
> > +};
> > +
> > +static const struct adsp_data msm8998_adsp_resource = {
> > .crash_reason_smem = 423,
> > .firmware_name = "adsp.mdt",
> > .pas_id = 1,
> > @@ -850,6 +880,7 @@ static const struct adsp_data sdx55_mpss_resource = {
> > static const struct of_device_id adsp_of_match[] = {
> > { .compatible = "qcom,msm8974-adsp-pil", .data = &adsp_resource_init},
> > { .compatible = "qcom,msm8996-adsp-pil", .data = &msm8996_adsp_resource},
> > + { .compatible = "qcom,msm8953-adsp-pil", .data = &msm8953_adsp_resource},
> > { .compatible = "qcom,msm8996-slpi-pil", .data = &slpi_resource_init},
> > { .compatible = "qcom,msm8998-adsp-pas", .data = &msm8996_adsp_resource},
> > { .compatible = "qcom,msm8998-slpi-pas", .data = &slpi_resource_init},
>
>
> --
> With best wishes
> Dmitry
Thanks,
Sireesh
next prev parent reply other threads:[~2022-05-12 10:39 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 16:15 [PATCH 0/9] Add support for remoteprocs on the MSM8953 platform Sireesh Kodali
2022-05-11 16:15 ` [PATCH 1/9] remoteproc: qcom: pas: Add MSM8953 ADSP PIL support Sireesh Kodali
2022-05-11 16:49 ` Dmitry Baryshkov
2022-05-11 16:51 ` Dmitry Baryshkov
2022-05-12 10:39 ` Sireesh Kodali [this message]
2022-05-11 16:15 ` [PATCH 2/9] remoteproc: qcom: q6v5-mss: Add modem support on MSM8953 Sireesh Kodali
2022-05-11 16:54 ` Dmitry Baryshkov
2022-05-12 5:16 ` Sireesh Kodali
2022-05-12 10:38 ` Sireesh Kodali
2022-05-11 16:15 ` [PATCH 3/9] remoteproc: qcom: qcom_wcnss: Add support for pronto-v3 Sireesh Kodali
2022-05-11 16:15 ` [PATCH 4/9] dt-bindings: remoteproc: qcom: wcnss: Convert to YAML Sireesh Kodali
2022-05-11 17:15 ` Krzysztof Kozlowski
2022-05-12 6:50 ` Sireesh Kodali
2022-05-12 8:14 ` Krzysztof Kozlowski
2022-05-12 9:32 ` Sireesh Kodali
2022-05-12 11:02 ` Krzysztof Kozlowski
2022-05-12 13:42 ` Sireesh Kodali
2022-05-12 8:36 ` Krzysztof Kozlowski
2022-05-12 10:01 ` Sireesh Kodali
2022-05-12 13:49 ` Rob Herring
2022-12-01 13:22 ` Krzysztof Kozlowski
2022-12-01 16:17 ` Sireesh Kodali
2022-12-01 16:24 ` Krzysztof Kozlowski
2022-05-11 16:15 ` [PATCH 5/9] dt-bindings: remoteproc: qcom: wcnss: Add compatible for pronto v3 Sireesh Kodali
2022-05-11 16:15 ` [PATCH 6/9] dt-bindings: remoteproc: qcom: mss: Convert bindings to YAML Sireesh Kodali
2022-05-11 17:50 ` Krzysztof Kozlowski
2022-05-12 9:50 ` Sireesh Kodali
2022-05-12 13:49 ` Rob Herring
2022-05-11 16:16 ` [PATCH 7/9] dt-bindings: remoteproc: qcom: mss: Add MSS on MSM8953 Sireesh Kodali
2022-05-11 16:16 ` [PATCH 8/9] dt-bindings: remoteproc: qcom: adsp: Add ADSP " Sireesh Kodali
2022-05-11 16:16 ` [PATCH 9/9] arm64: dts: qcom: msm8953: Add remote processor nodes Sireesh Kodali
2022-05-11 17:55 ` Krzysztof Kozlowski
2022-05-12 9:19 ` Sireesh Kodali
2022-05-12 14:37 ` Krzysztof Kozlowski
2022-05-12 15:15 ` Sireesh Kodali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CJXPVU06SN65.296G7A6NC7PTG@skynet-linux \
--to=sireeshkodali1@gmail.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=phone-devel@vger.kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).