From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43820C433DB for ; Mon, 1 Feb 2021 04:27:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0856A64E06 for ; Mon, 1 Feb 2021 04:27:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231136AbhBAE1v (ORCPT ); Sun, 31 Jan 2021 23:27:51 -0500 Received: from mail2.protonmail.ch ([185.70.40.22]:59820 "EHLO mail2.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231392AbhBAEZv (ORCPT ); Sun, 31 Jan 2021 23:25:51 -0500 Date: Mon, 01 Feb 2021 04:24:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1612153500; bh=Zb7ULZT7e66rly2USppGm7Xzx2fnacIRQRjSbtzMRNk=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=QJps2d/UT/K6V3FVJKgq1sL2ySKj1557bsXooFjaT12HgN74NcR8/GcQB3MzcHU7U IUJzePEIXuxL8YmxCFCAtcMdrAUu0dIM8JJhCyXprRdUFPbaaASmT0VKuL7dsVgPqd 117T2VTY7KWM1gNW/nZF3aOy0HD/uOpGrvxqOIgY= To: Takashi Iwai From: Erich Ritz Cc: Michael Catanzaro , "N, Harshapriya" , "alsa-devel@alsa-project.org" , Jaroslav Kysela , Takashi Iwai , "linux-kernel@vger.kernel.org" , "kai.vehmanen@intel.com" , "stable@vger.kernel.org" Reply-To: Erich Ritz Subject: Re: [REGRESSION] "ALSA: HDA: Early Forbid of runtime PM" broke my laptop's internal audio Message-ID: In-Reply-To: References: <9ACPNQ.AF32G3OJNPHA3@redhat.com> <8CEPNQ.GAG87LR8RI871@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, January 29, 2021 9:17 AM, Takashi Iwai wrote: > On Fri, 29 Jan 2021 17:12:08 +0100, > Michael Catanzaro wrote: > > > On Fri, Jan 29, 2021 at 9:30 am, Michael Catanzaro > > mcatanzaro@redhat.com wrote: > > > > > OK, I found "ALSA: hda/via: Apply the workaround generically for > > > Clevo machines" which was just merged yesterday. So I will test > > > again to find out. > > > > Hi Takashi, hi Harsha, > > I can confirm that the problem is fixed by this commit: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/comm= it/?id=3D4961167bf7482944ca09a6f71263b9e47f949851 > > Thanks, good to hear. > > Then I think we can drop the entry from power_save_denylist in > hda_intel.c. Could you try that it still works with the patch below? > > thanks, > > Takashi > > --- a/sound/pci/hda/hda_intel.c > +++ b/sound/pci/hda/hda_intel.c > @@ -2217,8 +2217,6 @@ static const struct snd_pci_quirk power_save_denyli= st[] =3D { > /* https://bugzilla.redhat.com/show_bug.cgi?id=3D1525104 / > SND_PCI_QUIRK(0x1043, 0x8733, "Asus Prime X370-Pro", 0), > / https://bugzilla.redhat.com/show_bug.cgi?id=3D1525104 */ > > - SND_PCI_QUIRK(0x1558, 0x6504, "Clevo W65_67SB", 0), > - /* https://bugzilla.redhat.com/show_bug.cgi?id=3D1525104 / > SND_PCI_QUIRK(0x1028, 0x0497, "Dell Precision T3600", 0), > / https://bugzilla.redhat.com/show_bug.cgi?id=3D1525104 / > / Note the P55A-UD3 and Z87-D3HP share the subsys id for the HDA dev = */ For me applying patch 4961167bf7482944ca09a6f71263b9e47f949851 on top of 5.= 10.12 fixes audio, but the above quoted patch applied to 5.10.12 does NOT f= ix audio. What I mean by fixes: Audio works normally on 5.4.94, and on 5.10.12 with patch 4961167 applied. I hear no audio from the laptop speakers on 5.10.12 and 5.10.12 with the ab= ove quoted patch applied. Opening pavucontrol shows a graphical response i= n the meter, but no audio is heard from the speakers. I did not test plugg= ing in headphones and did not test audio over HDMI. I have a System76 Gazelle Pro 7 (gazp7). # lspci -s "00:1b" -vv 00:1b.0 Audio device: Intel Corporation 7 Series/C210 Series Chipset Family= High Definition Audio Controller (rev 04) Subsystem: CLEVO/KAPOK Computer 7 Series/C210 Series Chipset Family= High Definition Audio Controller Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-= Stepping- SERR- FastB2B- DisINTx+ Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=3Dfast >TAbort- SERR-