From: <Kavyasree.Kotagiri@microchip.com>
To: <Horatiu.Vultur@microchip.com>, <linux-gpio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: <linus.walleij@linaro.org>, <alexandre.belloni@bootlin.com>,
<Horatiu.Vultur@microchip.com>
Subject: RE: [PATCH] pinctrl: ocelot: Fix for lan966x
Date: Wed, 20 Apr 2022 06:32:30 +0000 [thread overview]
Message-ID: <CO1PR11MB4865F8C372AC4CD2E19CCAF792F59@CO1PR11MB4865.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220413192918.3777234-1-horatiu.vultur@microchip.com>
> For lan966x, the GPIO 35 has the wrong function for alternate mode 2.
> The mode is not none but is PTP sync.
>
> Fixes: 531d6ab36571c2 ("pinctrl: ocelot: Extend support for lan966x")
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
Reviewed-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
> ---
> drivers/pinctrl/pinctrl-ocelot.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-ocelot.c b/drivers/pinctrl/pinctrl-ocelot.c
> index 51261f1231cc..40f76e4144e4 100644
> --- a/drivers/pinctrl/pinctrl-ocelot.c
> +++ b/drivers/pinctrl/pinctrl-ocelot.c
> @@ -130,6 +130,7 @@ enum {
> FUNC_PTP1,
> FUNC_PTP2,
> FUNC_PTP3,
> + FUNC_PTPSYNC_0,
> FUNC_PTPSYNC_1,
> FUNC_PTPSYNC_2,
> FUNC_PTPSYNC_3,
> @@ -253,6 +254,7 @@ static const char *const ocelot_function_names[] = {
> [FUNC_PTP1] = "ptp1",
> [FUNC_PTP2] = "ptp2",
> [FUNC_PTP3] = "ptp3",
> + [FUNC_PTPSYNC_0] = "ptpsync_0",
> [FUNC_PTPSYNC_1] = "ptpsync_1",
> [FUNC_PTPSYNC_2] = "ptpsync_2",
> [FUNC_PTPSYNC_3] = "ptpsync_3",
> @@ -984,7 +986,7 @@ LAN966X_P(31, GPIO, FC3_c, CAN1, NONE,
> OB_TRG, RECO_b, NON
> LAN966X_P(32, GPIO, FC3_c, NONE, SGPIO_a, NONE, MIIM_Sa,
> NONE, R);
> LAN966X_P(33, GPIO, FC1_b, NONE, SGPIO_a, NONE, MIIM_Sa,
> MIIM_b, R);
> LAN966X_P(34, GPIO, FC1_b, NONE, SGPIO_a, NONE, MIIM_Sa,
> MIIM_b, R);
> -LAN966X_P(35, GPIO, FC1_b, NONE, SGPIO_a, CAN0_b, NONE,
> NONE, R);
> +LAN966X_P(35, GPIO, FC1_b, PTPSYNC_0, SGPIO_a, CAN0_b, NONE,
> NONE, R);
> LAN966X_P(36, GPIO, NONE, PTPSYNC_1, NONE, CAN0_b, NONE,
> NONE, R);
> LAN966X_P(37, GPIO, FC_SHRD0, PTPSYNC_2, TWI_SLC_GATE_AD, NONE,
> NONE, NONE, R);
> LAN966X_P(38, GPIO, NONE, PTPSYNC_3, NONE, NONE, NONE,
> NONE, R);
> --
> 2.33.0
Thanks,
Kavya
next prev parent reply other threads:[~2022-04-20 6:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 19:29 [PATCH] pinctrl: ocelot: Fix for lan966x Horatiu Vultur
2022-04-20 6:32 ` Kavyasree.Kotagiri [this message]
2022-04-28 22:47 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB4865F8C372AC4CD2E19CCAF792F59@CO1PR11MB4865.namprd11.prod.outlook.com \
--to=kavyasree.kotagiri@microchip.com \
--cc=Horatiu.Vultur@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).