From: "Sit, Michael Wei Hong" <michael.wei.hong.sit@intel.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "Jose.Abreu@synopsys.com" <Jose.Abreu@synopsys.com>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"kuba@kernel.org" <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"peppe.cavallaro@st.com" <peppe.cavallaro@st.com>,
"alexandre.torgue@foss.st.com" <alexandre.torgue@foss.st.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
"Voon, Weifeng" <weifeng.voon@intel.com>,
"Ong, Boon Leong" <boon.leong.ong@intel.com>,
"Tan, Tee Min" <tee.min.tan@intel.com>,
"vee.khee.wong@linux.intel.com" <vee.khee.wong@linux.intel.com>,
"Wong, Vee Khee" <vee.khee.wong@intel.com>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net-next v3 2/3] net: pcs: add 2500BASEX support for Intel mGbE controller
Date: Fri, 28 May 2021 01:57:58 +0000 [thread overview]
Message-ID: <CO1PR11MB5044DDF8E9080BDB9701B3339D229@CO1PR11MB5044.namprd11.prod.outlook.com> (raw)
In-Reply-To: <YLAqrte9qwQ/64BI@lunn.ch>
> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Friday, 28 May, 2021 7:27 AM
> To: Sit, Michael Wei Hong <michael.wei.hong.sit@intel.com>
> Cc: Jose.Abreu@synopsys.com; hkallweit1@gmail.com;
> linux@armlinux.org.uk; kuba@kernel.org;
> netdev@vger.kernel.org; peppe.cavallaro@st.com;
> alexandre.torgue@foss.st.com; davem@davemloft.net;
> mcoquelin.stm32@gmail.com; Voon, Weifeng
> <weifeng.voon@intel.com>; Ong, Boon Leong
> <boon.leong.ong@intel.com>; Tan, Tee Min
> <tee.min.tan@intel.com>; vee.khee.wong@linux.intel.com;
> Wong, Vee Khee <vee.khee.wong@intel.com>; linux-stm32@st-
> md-mailman.stormreply.com; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH net-next v3 2/3] net: pcs: add 2500BASEX
> support for Intel mGbE controller
>
> > +static int xpcs_config_2500basex(struct mdio_xpcs_args *xpcs)
> {
> > + int ret;
> > +
> > + ret = xpcs_read(xpcs, MDIO_MMD_VEND2,
> DW_VR_MII_DIG_CTRL1);
> > + if (ret < 0)
> > + return ret;
> > + ret |= DW_VR_MII_DIG_CTRL1_2G5_EN;
> > + ret &=
> ~DW_VR_MII_DIG_CTRL1_MAC_AUTO_SW;
> > + ret = xpcs_write(xpcs, MDIO_MMD_VEND2,
> DW_VR_MII_DIG_CTRL1, ret);
> > + if (ret < 0)
> > + return ret;
> > +
> > + ret = xpcs_read(xpcs, MDIO_MMD_VEND2,
> DW_VR_MII_MMD_CTRL);
> > + if (ret < 0)
> > + return ret;
> > + ret &= ~AN_CL37_EN;
> > + ret |= SGMII_SPEED_SS6;
> > + ret &= ~SGMII_SPEED_SS13;
> > + return xpcs_write(xpcs, MDIO_MMD_VEND2,
> DW_VR_MII_MMD_CTRL, ret);
> > +
> > + return 0;
>
> Indentation is messed up here? Or a rebase gone wrong
> removing an if statement?
>
Thanks Andrew! Good catch, missed this indentation error,
will fix in next revision
> Andrew
next prev parent reply other threads:[~2021-05-28 1:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 9:24 [PATCH net-next v3 0/3] Enable 2.5Gbps speed for stmmac Michael Sit Wei Hong
2021-05-27 9:24 ` [PATCH net-next v3 1/3] net: stmmac: split xPCS setup from mdio register Michael Sit Wei Hong
2021-05-27 9:24 ` [PATCH net-next v3 2/3] net: pcs: add 2500BASEX support for Intel mGbE controller Michael Sit Wei Hong
2021-05-27 23:26 ` Andrew Lunn
2021-05-28 1:57 ` Sit, Michael Wei Hong [this message]
2021-05-27 9:24 ` [PATCH net-next v3 3/3] net: stmmac: enable Intel mGbE 2.5Gbps link speed Michael Sit Wei Hong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB5044DDF8E9080BDB9701B3339D229@CO1PR11MB5044.namprd11.prod.outlook.com \
--to=michael.wei.hong.sit@intel.com \
--cc=Jose.Abreu@synopsys.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@lunn.ch \
--cc=boon.leong.ong@intel.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=tee.min.tan@intel.com \
--cc=vee.khee.wong@intel.com \
--cc=vee.khee.wong@linux.intel.com \
--cc=weifeng.voon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).