From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755978AbcETQvj (ORCPT ); Fri, 20 May 2016 12:51:39 -0400 Received: from mail-bn1bon0147.outbound.protection.outlook.com ([157.56.111.147]:40654 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752568AbcETQvi convert rfc822-to-8bit (ORCPT ); Fri, 20 May 2016 12:51:38 -0400 From: Hartley Sweeten To: Ian Abbott , "devel@driverdev.osuosl.org" CC: Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 03/20] staging: comedi: drivers: rename PLX PCI 9080 register offsets Thread-Topic: [PATCH 03/20] staging: comedi: drivers: rename PLX PCI 9080 register offsets Thread-Index: AQHRsp5198XVaejrqk2yCb4XZ8znip/B/6fwgAAFAwCAAAUyEA== Date: Fri, 20 May 2016 16:51:34 +0000 Message-ID: References: <1463752162-15181-1-git-send-email-abbotti@mev.co.uk> <1463752162-15181-4-git-send-email-abbotti@mev.co.uk> <573F3BB2.6020601@mev.co.uk> In-Reply-To: <573F3BB2.6020601@mev.co.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mev.co.uk; dkim=none (message not signed) header.d=none;mev.co.uk; dmarc=none action=none header.from=visionengravers.com; x-originating-ip: [184.183.19.121] x-ms-office365-filtering-correlation-id: 4e5b51e8-ba70-4d76-6d2f-08d380cf00f9 x-microsoft-exchange-diagnostics: 1;CO2PR01MB2085;5:ZVBNvuhOwyrpubMuGU6Co3Y9Kw0IBrJXUxj8LZsIhP8xjt6RFlp22PqlY+K+nDTNR8DH1QeWHC+7aYAXIH1WLfYe2Q0aT+lZ3PcUu38uuJZ8gzQhQjRqdSRudyA4gyu87TCnCZdVae/UB8fWx9B6UA==;24:qZvuUU3q5cN7PayCZ9lkFf4KBdcHMZ53/upN4F+T2oemixD8FojGjXBfZnoam0lBbqVhH4uVJRdimXcRMuLGTrWndnu0PqT7o07+IosSqLM=;7:aeSwKS+e6HgtI8mSEndRJExzX3kNyH8LYQ7934PF1DmoCTfFNonNJdE3KRP5/qu4msCozrHIY5Ldcct0+sIxQhMq+Vo5biS81tA4KUeOUrQWUfnqiW3HwRvcryOr6Ff9C8Qs0wGtQ7pSzBv6k1HgrAiXxUZedhKMLu26eDkxc5/TWjM01N1hyK0RgpBBbblo x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CO2PR01MB2085; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040130)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041072)(6043046);SRVR:CO2PR01MB2085;BCL:0;PCL:0;RULEID:;SRVR:CO2PR01MB2085; x-forefront-prvs: 09480768F8 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(24454002)(377454003)(122556002)(54356999)(50986999)(2906002)(86362001)(11100500001)(76176999)(66066001)(92566002)(5004730100002)(80792005)(33656002)(6116002)(4326007)(3846002)(5001770100001)(586003)(189998001)(87936001)(106116001)(1220700001)(102836003)(5008740100001)(2501003)(5002640100001)(74316001)(10400500002)(93886004)(8676002)(81166006)(3280700002)(3660700001)(77096005)(2950100001)(2900100001)(9686002)(5003600100002)(8936002)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:CO2PR01MB2085;H:CO2PR01MB2088.prod.exchangelabs.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: visionengravers.com X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2016 16:51:34.7616 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d698601f-af92-4269-8099-fd6f11636477 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR01MB2085 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, May 20, 2016 9:31 AM, Ian Abbott wrote: > On 20/05/16 17:21, Hartley Sweeten wrote: >> Just an comment on your renaming. >> >> You also renamed the registers in the daqbook2000 driver in the >> _REG_ format. Personally I prefer the format to be >> __REG. That way a grep for _ will >> return both the register and bit uses. > > It makes it easier to distinguish the register offsets from the register > values, imho. I guess. It's just not as common in comedi right now and it does make grep'ing for all the register/bit uses a bit more cumbersome. Regards, Hartley