From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751883AbcERWpW (ORCPT ); Wed, 18 May 2016 18:45:22 -0400 Received: from mail-bn1on0136.outbound.protection.outlook.com ([157.56.110.136]:62240 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751780AbcERWpV convert rfc822-to-8bit (ORCPT ); Wed, 18 May 2016 18:45:21 -0400 From: Hartley Sweeten To: Ian Abbott , "devel@driverdev.osuosl.org" CC: Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v2 06/14] staging: comedi: daqboard2000: rename register offset macros Thread-Topic: [PATCH v2 06/14] staging: comedi: daqboard2000: rename register offset macros Thread-Index: AQHRsQIL+xovMQkm4Uy7Em0gvSXfdp+/SziQ Date: Wed, 18 May 2016 22:45:17 +0000 Message-ID: References: <1463478773-5916-1-git-send-email-abbotti@mev.co.uk> <1463575029-12089-1-git-send-email-abbotti@mev.co.uk> <1463575029-12089-7-git-send-email-abbotti@mev.co.uk> In-Reply-To: <1463575029-12089-7-git-send-email-abbotti@mev.co.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mev.co.uk; dkim=none (message not signed) header.d=none;mev.co.uk; dmarc=none action=none header.from=visionengravers.com; x-originating-ip: [184.183.19.121] x-ms-office365-filtering-correlation-id: 018777d0-ad16-4946-68e5-08d37f6e15b2 x-microsoft-exchange-diagnostics: 1;CO2PR01MB2088;5:nkzDTscpuaGXto2GfuONYeGmhXjzN6+sPmPO7E4qhgFAi/82u169zWsvyFPcGktLHGkMiV0IgwGhcman+j6xJNeimMMncbFgmSHn2nELGShOTxho4qL4CVCjC+ECFzNYP/yWWF4ewf1aLp9H2ZU/HA==;24:DHzJZx28AMzDVnb3fBXBUXSrehMIocGdrj8j+kYZm24+xzyENMZbPsbufIrQobxYXOVbJT/uqfmseBrEUVIfZERd2b4eH1H9rPUaVhSaJWg=;7:3I66SYaLnu3xecePWFL4o+FI66rH4D0QQ43tjnekNuYYwKtstFiQdM74yA6ajpj7uMG352S13KzSL1/Fexo3Eoc5qWJCdUvq4HwuIrTOYwSU8BENfaplCHPmncT13+L5paG6O95LUviJg6+ZnTbAIBBukjqGOafOX7JdAfBkLaktsLjPvEmEMUHXUIR4vB1d x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CO2PR01MB2088; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040130)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041072)(6043046)(6042046);SRVR:CO2PR01MB2088;BCL:0;PCL:0;RULEID:;SRVR:CO2PR01MB2088; x-forefront-prvs: 0946DC87A1 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(24454002)(377454003)(8936002)(81166006)(106116001)(76176999)(3660700001)(54356999)(50986999)(3846002)(92566002)(8676002)(19580405001)(19580395003)(86362001)(80792005)(189998001)(2950100001)(102836003)(10400500002)(5008740100001)(87936001)(5001770100001)(4326007)(2906002)(9686002)(5002640100001)(77096005)(586003)(2900100001)(5003600100002)(122556002)(2501003)(1220700001)(5004730100002)(3280700002)(33656002)(11100500001)(66066001)(74316001)(6116002);DIR:OUT;SFP:1102;SCL:1;SRVR:CO2PR01MB2088;H:CO2PR01MB2088.prod.exchangelabs.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: visionengravers.com X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2016 22:45:17.4172 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d698601f-af92-4269-8099-fd6f11636477 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR01MB2088 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, May 18, 2016 5:37 AM, Ian Abbott wrote: > Rename the macros defining register offsets to avoid CamelCase, and to > use namespace associated with the driver. > > Signed-off-by: Ian Abbott > Reviewed-by: H Hartley Sweeten > --- > Other CamelCase issues in this patch will be dealt with by later > patches in the series. > > v2: Shortened prefix from `DAQBOARD2000_` to `DB2K_`. > --- > drivers/staging/comedi/drivers/daqboard2000.c | 112 ++++++++++++++------------ > 1 file changed, 61 insertions(+), 51 deletions(-) [snip] +#define DB2K_REG_DIO_P2_EXP_IO_16_BIT(x) (0xc0 + (x) * 2) /* s16 */ You slipped an extra space in here: WARNING: please, no space before tabs #184: FILE: drivers/staging/comedi/drivers/daqboard2000.c:184: +#define DB2K_REG_DIO_P2_EXP_IO_16_BIT(x) ^I(0xc0 + (x) * 2) /* s16 */$ Regards, Hartley