From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755944AbcETQVn (ORCPT ); Fri, 20 May 2016 12:21:43 -0400 Received: from mail-by2on0106.outbound.protection.outlook.com ([207.46.100.106]:27622 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755845AbcETQVk convert rfc822-to-8bit (ORCPT ); Fri, 20 May 2016 12:21:40 -0400 X-Greylist: delayed 150342 seconds by postgrey-1.27 at vger.kernel.org; Fri, 20 May 2016 12:21:40 EDT From: Hartley Sweeten To: Ian Abbott , "devel@driverdev.osuosl.org" CC: Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 03/20] staging: comedi: drivers: rename PLX PCI 9080 register offsets Thread-Topic: [PATCH 03/20] staging: comedi: drivers: rename PLX PCI 9080 register offsets Thread-Index: AQHRsp5198XVaejrqk2yCb4XZ8znip/B/6fw Date: Fri, 20 May 2016 16:21:27 +0000 Message-ID: References: <1463752162-15181-1-git-send-email-abbotti@mev.co.uk> <1463752162-15181-4-git-send-email-abbotti@mev.co.uk> In-Reply-To: <1463752162-15181-4-git-send-email-abbotti@mev.co.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mev.co.uk; dkim=none (message not signed) header.d=none;mev.co.uk; dmarc=none action=none header.from=visionengravers.com; x-originating-ip: [184.183.19.121] x-ms-office365-filtering-correlation-id: 230a52f8-c8e9-417c-9e9b-08d380cacb91 x-microsoft-exchange-diagnostics: 1;CO2PR01MB2085;5:5NQXTVhz45zprQHCYw83Z49tNU6GLjgX2PJzLDAi6m0PlJAS2Dzow+Mw+HdxXPpqv/F7wwphq2HsKrU/elZb5b1IjyvrfbhYlN4WOrtmH84fKSh+BDUG5arstP9XjIigPOzXXRUYny76EtdOCmjxjQ==;24:QjDz/CZfL0UCz1UwHjbjmSnUSwQ8jhR3toIy5GAAkKc5D7txO8o2MAIBSSNSh2sJB14dWhn+835nCW5aApgO/TWB4JFBAgK0Pj3QKNT4ESA=;7:xHXZwpIM/uK2/2NL0hq0iyTGrhRD4bw14Put5diCzgMtMVv9fiSWCd5j6jiXouKsn0c8D3cwLO1Av0cRXZnRrbGjwThlYQzHUhTE0YUNWFOybJQFdFsrzGzCY6qz9aioSGAUAosmz5buFMuCyf4aSHTDbJA1pCuj3niPELKL4LA0xmp6JAua8Ly54YRYSViW x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CO2PR01MB2085; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040130)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041072)(6043046);SRVR:CO2PR01MB2085;BCL:0;PCL:0;RULEID:;SRVR:CO2PR01MB2085; x-forefront-prvs: 09480768F8 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(24454002)(377454003)(122556002)(54356999)(50986999)(2906002)(86362001)(11100500001)(76176999)(66066001)(92566002)(5004730100002)(80792005)(33656002)(6116002)(4326007)(189998001)(3846002)(5001770100001)(586003)(87936001)(106116001)(1220700001)(102836003)(5008740100001)(2501003)(5002640100001)(74316001)(19580405001)(19580395003)(10400500002)(8676002)(81166006)(3280700002)(3660700001)(77096005)(2900100001)(2950100001)(9686002)(5003600100002)(8936002)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:CO2PR01MB2085;H:CO2PR01MB2088.prod.exchangelabs.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: visionengravers.com X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2016 16:21:27.4387 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d698601f-af92-4269-8099-fd6f11636477 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR01MB2085 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, May 20, 2016 6:49 AM, Ian Abbott wrote: > Rename the macros in "plx9080.h" that define the offsets of registers, > following the pattern `PLX_REG_`, where `` is the register > name from the PLX PCI 9080 Data Book. > > Add defines for the "Mailbox" registers, and add parameterized macros > for the mailbox registers and the DMA control registers. Make use of > the parameterized versions of the macros where it seems appropriate. > > The registers for supporting the I2O (Intelligent Input/Output) feature > are largely left undefined, just defining enough to allow the I2O > feature to be disabled. > > Signed-off-by: Ian Abbott Ian, Just an comment on your renaming. You also renamed the registers in the daqbook2000 driver in the _REG_ format. Personally I prefer the format to be __REG. That way a grep for _ will return both the register and bit uses. Currently the _REG_ form is not as common in comedi. Looks like it's only used in amcc_35933.h and will be in daqboard2000.c. The __REG form is used a lot. Not a big deal, just a comment. Hartley