From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752110AbcEQR3M (ORCPT ); Tue, 17 May 2016 13:29:12 -0400 Received: from mail-bn1on0114.outbound.protection.outlook.com ([157.56.110.114]:57943 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751721AbcEQR3I convert rfc822-to-8bit (ORCPT ); Tue, 17 May 2016 13:29:08 -0400 From: Hartley Sweeten To: Ian Abbott , "devel@driverdev.osuosl.org" CC: Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 01/14] staging: comedi: daqboard2000: remove commented out code Thread-Topic: [PATCH 01/14] staging: comedi: daqboard2000: remove commented out code Thread-Index: AQHRsCHvN6J6DTKqikOyYT2ExznVOJ+9Xgsg Date: Tue, 17 May 2016 17:14:23 +0000 Message-ID: References: <1463478773-5916-1-git-send-email-abbotti@mev.co.uk> <1463478773-5916-2-git-send-email-abbotti@mev.co.uk> In-Reply-To: <1463478773-5916-2-git-send-email-abbotti@mev.co.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mev.co.uk; dkim=none (message not signed) header.d=none;mev.co.uk; dmarc=none action=none header.from=visionengravers.com; x-originating-ip: [184.183.19.121] x-ms-office365-filtering-correlation-id: 196a6c56-d1cf-4f08-7e94-08d37e76b201 x-microsoft-exchange-diagnostics: 1;CO2PR01MB2087;5:bSIBmCIAHqWCnkFVGrT6IQ9gZSsK5Y+bxSZ71jvlqoQynF2aftwrJzj2cQ2CtImSHO0jeYPcWw4mD0lzN6Y54YbHidEy0HW1nqbrF0Od4FDKxaMtlD+Ou+arSvkeFj1BnN84LYFXh8uJujd8waXKhQ==;24:SsQh2r5Z0cGGcRLv6PdX0v1cLIYA9ucTEGhUnquLKcAUmgE3/Rf+q8PifKsiJvKiHSuFYY6HTcNWIrnDH7AUjzqVujFAweP2OWzeg8yyUsg=;7:Fx+jbt8QJ1umDRkOYQUx8waja5oWxffQwVwP3cHQiSiDv//NlQDQnXjeCnKxQ00q3N6eHo2zjACc8tFTEVhMySsdTiQSDvb6JJkOAJ3vV5W46nFpk6QGB8kDAohnmOPvcZFDyPq3mEc4oBVshparJpBpPjx5WNslFFlFAAMsGu/pafSAt9k85MlYhPBZMl1h x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CO2PR01MB2087; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040130)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041072)(6043046);SRVR:CO2PR01MB2087;BCL:0;PCL:0;RULEID:;SRVR:CO2PR01MB2087; x-forefront-prvs: 0945B0CC72 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(24454002)(377454003)(33656002)(106116001)(5008740100001)(74316001)(54356999)(76176999)(77096005)(2900100001)(189998001)(6116002)(8676002)(4326007)(586003)(3846002)(2950100001)(102836003)(1220700001)(2501003)(9686002)(122556002)(80792005)(5003600100002)(19580395003)(8936002)(2906002)(81166006)(19580405001)(5002640100001)(92566002)(5004730100002)(86362001)(87936001)(66066001)(5001770100001)(11100500001)(10400500002)(50986999);DIR:OUT;SFP:1102;SCL:1;SRVR:CO2PR01MB2087;H:CO2PR01MB2088.prod.exchangelabs.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: visionengravers.com X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2016 17:14:23.7836 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d698601f-af92-4269-8099-fd6f11636477 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR01MB2087 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote: > Remove some commented out code. Some of it uses constructs that don't > exist in the driver, and probably come from the source code for the MS > Windows driver. > > Signed-off-by: Ian Abbott > --- > drivers/staging/comedi/drivers/daqboard2000.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/daqboard2000.c b/drivers/staging/comedi/drivers/daqboard2000.c > index 57ab668..8c9a024 100644 > --- a/drivers/staging/comedi/drivers/daqboard2000.c > +++ b/drivers/staging/comedi/drivers/daqboard2000.c > @@ -278,9 +278,7 @@ struct daqboard2000_private { > > static void writeAcqScanListEntry(struct comedi_device *dev, u16 entry) > { > - /* udelay(4); */ > writew(entry & 0x00ff, dev->mmio + acqScanListFIFO); > - /* udelay(4); */ > writew((entry >> 8) & 0x00ff, dev->mmio + acqScanListFIFO); > } > > @@ -315,10 +313,6 @@ static void setup_sampling(struct comedi_device *dev, int chan, int gain) > word3 = 0; > break; > } > -/* > - dev->eeprom.correctionDACSE[i][j][k].offset = 0x800; > - dev->eeprom.correctionDACSE[i][j][k].gain = 0xc00; > -*/ > /* These should be read from EEPROM */ > word2 |= 0x0800; > word3 |= 0xc000; It might be a good idea to add a comment about the magic 0x0800 and 0xc000 values: > word2 |= 0x0800; /* offset */ > word3 |= 0xc000; /* gain */ Wish I could find a register map for this board. I sent an email to Measurement Computing to see if one is available. Regards, Hartley