From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755144AbcESQtu (ORCPT ); Thu, 19 May 2016 12:49:50 -0400 Received: from mail-bl2on0114.outbound.protection.outlook.com ([65.55.169.114]:35169 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753865AbcESQts convert rfc822-to-8bit (ORCPT ); Thu, 19 May 2016 12:49:48 -0400 From: Hartley Sweeten To: Ian Abbott , "devel@driverdev.osuosl.org" CC: Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v3 06/14] staging: comedi: daqboard2000: rename register offset macros Thread-Topic: [PATCH v3 06/14] staging: comedi: daqboard2000: rename register offset macros Thread-Index: AQHRsbSq3C0cSD9wbE6YGOoEQjw4ZJ/AeNgA Date: Thu, 19 May 2016 16:49:44 +0000 Message-ID: References: <1463575029-12089-7-git-send-email-abbotti@mev.co.uk> <1463651747-6734-1-git-send-email-abbotti@mev.co.uk> In-Reply-To: <1463651747-6734-1-git-send-email-abbotti@mev.co.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mev.co.uk; dkim=none (message not signed) header.d=none;mev.co.uk; dmarc=none action=none header.from=visionengravers.com; x-originating-ip: [184.183.19.121] x-ms-office365-filtering-correlation-id: 6b0c8bfe-f783-4967-b695-08d380059501 x-microsoft-exchange-diagnostics: 1;CO2PR01MB2085;5:PLW2yvLMFIzoARgPLn3wZchSl6Spv10W7WpiBMFvwoIbBtuix9uJi7lFBZhdoappW4KKQ2Ndz6cgIxR9nl30ao5c+r4FXJxEjIuOxaRMJlkQXRTA57icWK535IdQqszh8Lh8uVlTNAtGqha/UbHffg==;24:3Gbc53I4pr2aauBPes+iISaVOcLYn3D/HQuzKIJOSBkMMU1u15cSzsUaXq6bQxzVF4vDDdDOrXytB83UFc919vlMjT6K7RFkY+3Fx0xKbfk=;7:KNS7Z/AlsO1aWOW0J/xNEd7W4W7IH47QgIDd+kGSAcZozNWZQQ1t7Nogx7oje1unhBQdOK3md/UAPQzfK/wYXWUkBmQlcWLNnvUOf3KXmMNaBDewpMdvNViRKQvwKft3a9WHYvmeSXiXZsI7sLva4kFD8QJ87M8TWf+drGAnaGYxht3OpvCdY7kqLZGeEbFR x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CO2PR01MB2085; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040130)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041072)(6043046);SRVR:CO2PR01MB2085;BCL:0;PCL:0;RULEID:;SRVR:CO2PR01MB2085; x-forefront-prvs: 094700CA91 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(24454002)(377454003)(122556002)(54356999)(2906002)(50986999)(86362001)(76176999)(66066001)(92566002)(80792005)(11100500001)(5004730100002)(586003)(3846002)(6116002)(189998001)(87936001)(106116001)(4326007)(102836003)(5001770100001)(1220700001)(2501003)(5008740100001)(5002640100001)(74316001)(9686002)(19580395003)(19580405001)(10400500002)(33656002)(8936002)(77096005)(8676002)(81166006)(3280700002)(3660700001)(2950100001)(2900100001)(5003600100002);DIR:OUT;SFP:1102;SCL:1;SRVR:CO2PR01MB2085;H:CO2PR01MB2088.prod.exchangelabs.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: visionengravers.com X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2016 16:49:44.6766 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d698601f-af92-4269-8099-fd6f11636477 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR01MB2085 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, May 19, 2016 2:56 AM, Ian Abbott wrote: > Rename the macros defining register offsets to avoid CamelCase, and to > use namespace associated with the driver. > > Signed-off-by: Ian Abbott > Reviewed-by: H Hartley Sweeten > --- > Other CamelCase issues in this patch will be dealt with by later > patches in the series. > > v2: Shortened prefix from `DAQBOARD2000_` to `DB2K_`. > v3: Removed a space before tab that slipped in in v2. Ian, Your [PATCH v2 07/14: ...] does not apply after this one. It's probably better if Greg drops the previous patches and you post a full series. Regards, Hartley