From: Damian Kos <dkos@cadence.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: David Airlie <airlied@linux.ie>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Archit Taneja <architt@codeaurora.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Gustavo Padovan <gustavo@padovan.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Sean Paul <sean@poorly.run>, Sandy Huang <hjc@rock-chips.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-rockchip@lists.infradead.org"
<linux-rockchip@lists.infradead.org>,
Przemyslaw Gaj <pgaj@cadence.com>,
Lukasz Tyrala <ltyrala@cadence.com>,
Scott Telford <stelford@cadence.com>,
Artur Jedrysek <jartur@cadence.com>,
Piotr Sroka <piotrs@cadence.com>,
"quentin.schulz@bootlin.com" <quentin.schulz@bootlin.com>,
"jbergsagel@ti.com" <jbergsagel@ti.com>,
Quentin Schulz <quentin.schulz@free-electrons.com>
Subject: RE: [PATCH v4 5/5] drm: bridge: add support for Cadence MHDP DPI/DP bridge
Date: Mon, 24 Sep 2018 11:40:03 +0000 [thread overview]
Message-ID: <CO2PR07MB2551EC0A7DEB61C54A4D6A5FCD170@CO2PR07MB2551.namprd07.prod.outlook.com> (raw)
In-Reply-To: <1903708.pJTgKoWLiI@phil>
Hi Heiko,
> Hi Damian,
>
> Am Donnerstag, 20. September 2018, 16:54:40 CEST schrieb Damian Kos:
> > From: Quentin Schulz <quentin.schulz@free-electrons.com>
> >
> > This adds basic support for Cadence MHDP DPI to DP bridge.
> >
> > Basically, it takes a DPI stream as input and output it encoded in DP
> > format. It's missing proper HPD, HDCP and currently supports only SST
> > mode.
> >
> > Changes made in the low level driver (cdn-dp-reg.*):
> > - moved it to from drivers/gpu/drm/rockchip to
> > drivers/gpu/drm/bridge/cdns-mhdp-common.*
> > - functions for sending/receiving commands are now public
> > - added functions for reading registers and link training
> > adjustment
> >
> > Changes made in RK's driver (cdn-dp-core.*):
> > - Moved audio_info and audio_pdev fields from cdn_dp_device to
> > cdns_mhdp_device structure.
> >
> > Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
> > Signed-off-by: Damian Kos <dkos@cadence.com>
>
> [...]
>
> > diff --git a/drivers/gpu/drm/rockchip/Kconfig
> > b/drivers/gpu/drm/rockchip/Kconfig
> > index 0ccc76217ee4..129b0529f3e1 100644
> > --- a/drivers/gpu/drm/rockchip/Kconfig
> > +++ b/drivers/gpu/drm/rockchip/Kconfig
> > @@ -27,7 +27,9 @@ config ROCKCHIP_ANALOGIX_DP
> >
> > config ROCKCHIP_CDN_DP
> > bool "Rockchip cdn DP"
> > - depends on EXTCON=y || (EXTCON=m && DRM_ROCKCHIP=m)
> > + depends on DRM_ROCKCHIP=m
>
> Sorry, I wasn't fast enough in my reply to you mail to catch that before your v4, but I don't think this is necessary.
> Instead I do guess, the select below should do the right thing by making EXTCON=y if DRM_ROCKCHIP=y.
>
> Somewhat clumsily verified by making EXTCON=m in my defconfig and seeing get changed to y upon build, which I guess comes from a different "select" in the config.
>
I've changed it to:
config ROCKCHIP_CDN_DP
bool "Rockchip cdn DP"
depends on DRM_ROCKCHIP
select EXTCON if DRM_ROCKCHIP=y
select DRM_CDNS_MHDP
help...
and it seems that there are no issues. At least for me.
Please let me know if that's OK.
>
> > + select EXTCON
> > + select DRM_CDNS_MHDP
> > help
> > This selects support for Rockchip SoC specific extensions
> > for the cdn DP driver. If you want to enable Dp on diff --git
> > a/drivers/gpu/drm/rockchip/Makefile
> > b/drivers/gpu/drm/rockchip/Makefile
> > index a314e2109e76..16ba61ffca39 100644
> > --- a/drivers/gpu/drm/rockchip/Makefile
> > +++ b/drivers/gpu/drm/rockchip/Makefile
> > @@ -3,13 +3,15 @@
> > # Makefile for the drm device driver. This driver provides support
> > for the # Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher.
> >
> > +ccflags-y += -I$(src)/../bridge
>
> hmm, instead of adding an include path, the shared header should probably just live in /include/drm/bridge/... in the kernel source?
>
I'll move the common header to include/drm/bridge/ in v5.
>
> Heiko
--
Damian
next prev parent reply other threads:[~2018-09-24 11:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 14:54 [PATCH v4 0/5] drm: add support for Cadence MHDP DPI/DP bridge Damian Kos
2018-09-20 14:54 ` [PATCH v4 1/5] drm/rockchip: prepare common code for cdns and rk dpi/dp driver Damian Kos
2018-09-20 14:54 ` [PATCH v4 2/5] drm/dp: fix link probing for devices supporting DP 1.4+ Damian Kos
2018-09-21 7:59 ` Manasi Navare
2018-10-01 9:27 ` Quentin Schulz
2018-10-02 13:28 ` Ville Syrjälä
2018-09-20 14:54 ` [PATCH v4 3/5] drm/dp: make dp_get_lane_status usable from outside of the core Damian Kos
2018-09-20 14:54 ` [PATCH v4 4/5] dt-bindings: drm/bridge: Document Cadence MHDP bridge bindings Damian Kos
2018-09-20 14:54 ` [PATCH v4 5/5] drm: bridge: add support for Cadence MHDP DPI/DP bridge Damian Kos
2018-09-21 8:41 ` Heiko Stuebner
2018-09-24 11:40 ` Damian Kos [this message]
2018-09-24 12:28 ` Heiko Stuebner
2018-09-24 12:47 ` Damian Kos
2018-09-21 14:01 ` Sean Paul
2018-09-24 10:22 ` Damian Kos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO2PR07MB2551EC0A7DEB61C54A4D6A5FCD170@CO2PR07MB2551.namprd07.prod.outlook.com \
--to=dkos@cadence.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=architt@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo@padovan.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=jartur@cadence.com \
--cc=jbergsagel@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=ltyrala@cadence.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mark.rutland@arm.com \
--cc=pgaj@cadence.com \
--cc=piotrs@cadence.com \
--cc=quentin.schulz@bootlin.com \
--cc=quentin.schulz@free-electrons.com \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
--cc=stelford@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).