From: Yuval Mintz <Yuval.Mintz@qlogic.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: David Miller <davem@davemloft.net>,
Manish Chopra <manish.chopra@qlogic.com>,
Sudarsana Kalluru <Sudarsana.Kalluru@qlogic.com>,
netdev <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Ariel Elior <Ariel.Elior@qlogic.com>
Subject: RE: [PATCH] qed: fix qed_fill_link() error handling
Date: Mon, 30 May 2016 16:24:07 +0000 [thread overview]
Message-ID: <CO2PR11MB00881A57063B9AB617359A9097450@CO2PR11MB0088.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1464623197-2084229-1-git-send-email-arnd@arndb.de>
> + if (IS_ENABLED(CONFIG_QED_SRIOV) && !IS_PF(hwfn->cdev)) {
> + qed_vf_get_link_params(hwfn, params);
> + qed_vf_get_link_state(hwfn, link);
> + qed_vf_get_link_caps(hwfn, link_caps);
> +
> + return 0;
> + }
The IS_ENABLED here seems a bit wasteful to me - we have empty implementation
under qed_vf.h just for this case [I.e., that SRIOV isn't enabled for qed].
If all we're trying achieve is removing these gcc warnings, I think we can simply
memset the structs in the currently-empty qed_vf_get_link_* functions.
next prev parent reply other threads:[~2016-05-30 16:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 15:46 [PATCH] qed: fix qed_fill_link() error handling Arnd Bergmann
2016-05-30 16:24 ` Yuval Mintz [this message]
2016-05-31 21:20 ` David Miller
2016-05-31 22:34 ` Arnd Bergmann
2016-06-01 10:55 ` Yuval Mintz
2016-06-01 11:03 ` Arnd Bergmann
2016-06-01 11:10 ` Yuval Mintz
2016-06-01 13:29 ` [PATCH v2] " Arnd Bergmann
2016-06-01 13:36 ` Yuval Mintz
2016-06-02 5:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO2PR11MB00881A57063B9AB617359A9097450@CO2PR11MB0088.namprd11.prod.outlook.com \
--to=yuval.mintz@qlogic.com \
--cc=Ariel.Elior@qlogic.com \
--cc=Sudarsana.Kalluru@qlogic.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=manish.chopra@qlogic.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).