From: Chao Yu <yuchaochina@hotmail.com>
To: "'Jaegeuk Kim'" <jaegeuk@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-f2fs-devel@lists.sourceforge.net>
Subject: RE: [f2fs-dev] [PATCH] f2fs: fix to release inode page in get_new_data_page
Date: Sat, 11 Jul 2015 10:02:51 +0800 [thread overview]
Message-ID: <COL402-EAS409F2B0F7AE6CCD5F95F8D1AB9E0@phx.gbl> (raw)
In-Reply-To: <20150711001715.GA61190@jaegeuk-mac02>
Hi Jaegeuk,
> -----Original Message-----
> From: Jaegeuk Kim [mailto:jaegeuk@kernel.org]
> Sent: Saturday, July 11, 2015 8:17 AM
> To: Chao Yu; Chao Yu
> Cc: linux-kernel@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net;
> linux-kernel@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net
> Subject: Re: [f2fs-dev] [PATCH] f2fs: fix to release inode page in get_new_data_page
>
> Hi Chao,
>
> On Thu, Jul 09, 2015 at 06:20:08PM +0800, Chao Yu wrote:
> > get_new_data_page should release inode page when we encounter any
> > error in its procedure, but there is one error path didn't cover
> > this, fix it.
>
> Nice catch.
> But, I think we should fix its caller:
>
> in init_inode_metadata(),
> err = make_empty_dir();
> if (err)
> goto put_error;
> ---------------
Previously, I fixed in the same way, but I got an oops when I test the
patch with xfstest suit, it shows we will meet an error in this call
path IIRC:
->f2fs_mkdir
->__f2fs_add_link
->init_inode_metadata
->make_empty_dir
->get_new_data_page
->f2fs_reserve_block
->reserve_new_block
->inc_valid_block_count
return -ENOSPC;
->f2fs_put_dnode
->f2fs_put_page(ipage, 1)
put_error:
->f2fs_put_page(ipage, 1);
f2fs_bug_on(F2FS_P_SB(page), !PageLocked(page));
And I don't think we should change error handling method of f2fs_put_dnode
for just fixing this issue.
How do you think?
Thanks,
> Thanks,
>
> >
> > Signed-off-by: Chao Yu <chao2.yu@samsung.com>
> > ---
> > fs/f2fs/data.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> > index 08dfdc6..ea8898b 100644
> > --- a/fs/f2fs/data.c
> > +++ b/fs/f2fs/data.c
> > @@ -397,8 +397,10 @@ struct page *get_new_data_page(struct inode *inode,
> > int err;
> > repeat:
> > page = grab_cache_page(mapping, index);
> > - if (!page)
> > + if (!page) {
> > + f2fs_put_page(ipage, 1);
> > return ERR_PTR(-ENOMEM);
> > + }
> >
> > set_new_dnode(&dn, inode, ipage, NULL, 0);
> > err = f2fs_reserve_block(&dn, index);
> > --
> > 2.4.2
>
> ------------------------------------------------------------------------------
> Don't Limit Your Business. Reach for the Cloud.
> GigeNET's Cloud Solutions provide you with the tools and support that
> you need to offload your IT needs and focus on growing your business.
> Configured For All Businesses. Start Your Cloud Today.
> https://www.gigenetcloud.com/
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2015-07-11 6:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 10:20 [PATCH] f2fs: fix to release inode page in get_new_data_page Chao Yu
2015-07-11 0:17 ` Jaegeuk Kim
2015-07-11 2:02 ` Chao Yu [this message]
2015-07-13 23:25 ` [f2fs-dev] " Jaegeuk Kim
2015-07-14 10:13 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=COL402-EAS409F2B0F7AE6CCD5F95F8D1AB9E0@phx.gbl \
--to=yuchaochina@hotmail.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).