From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9478C433E2 for ; Tue, 15 Sep 2020 10:07:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 78D1F21D7D for ; Tue, 15 Sep 2020 10:07:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=crapouillou.net header.i=@crapouillou.net header.b="JjKJkr55" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726290AbgIOKHq (ORCPT ); Tue, 15 Sep 2020 06:07:46 -0400 Received: from crapouillou.net ([89.234.176.41]:50084 "EHLO crapouillou.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726130AbgIOKHl (ORCPT ); Tue, 15 Sep 2020 06:07:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1600164455; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i0x55otxMpUkdJhAxtRyRNzid5yrQkcNryvNuSbY120=; b=JjKJkr554CtSU+QnzXW0ch7pQ3bS3gqTytqZwc4VR1umrd3soq7NGPIdyiFbjMUS+Nhzhz k6c4fs+MIO2EP24+rEt3Vh8+gJwbbEQ2e5qmiZFukSa0WIG94cUJWezD2ITO7GQ/XBZ2Ps k0nygKqOTATm1rLY76iZ1Zc4KXNyyLs= Date: Tue, 15 Sep 2020 12:07:24 +0200 From: Paul Cercueil Subject: Re: [PATCH 3/3] i2c: jz4780: Remove of_match_ptr() To: Rob Herring Cc: od@zcrc.me, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: In-Reply-To: <20200914221230.GA349829@bogus> References: <20200904131152.17390-1-paul@crapouillou.net> <20200904131152.17390-3-paul@crapouillou.net> <20200914221230.GA349829@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, Le lun. 14 sept. 2020 =E0 16:12, Rob Herring a =E9crit : > On Fri, Sep 04, 2020 at 03:11:52PM +0200, Paul Cercueil wrote: >> CONFIG_OF is selected by CONFIG_MACH_INGENIC, therefore we don't=20 >> need to >> handle the case where Device Tree is not supported. >=20 > What about COMPILE_TEST? If not supported, why not? What about it? It will still compile fine with COMPILE_TEST. -Paul >>=20 >> Signed-off-by: Paul Cercueil >> --- >> drivers/i2c/busses/i2c-jz4780.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >>=20 >> diff --git a/drivers/i2c/busses/i2c-jz4780.c=20 >> b/drivers/i2c/busses/i2c-jz4780.c >> index ed2ec86f6f1a..cb4a25ebb890 100644 >> --- a/drivers/i2c/busses/i2c-jz4780.c >> +++ b/drivers/i2c/busses/i2c-jz4780.c >> @@ -857,7 +857,7 @@ static struct platform_driver jz4780_i2c_driver=20 >> =3D { >> .remove =3D jz4780_i2c_remove, >> .driver =3D { >> .name =3D "jz4780-i2c", >> - .of_match_table =3D of_match_ptr(jz4780_i2c_of_matches), >> + .of_match_table =3D jz4780_i2c_of_matches, >> }, >> }; >>=20 >> -- >> 2.28.0 >>=20