linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Christian Löhle" <CLoehle@hyperstone.com>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: "pali@kernel.org" <pali@kernel.org>,
	"huyue2@yulong.com" <huyue2@yulong.com>,
	"tiantao6@hisilicon.com" <tiantao6@hisilicon.com>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>
Subject: Re: [PATCH] mmc: enable UHS voltage switch for SDSC if supported【请注意,邮件由linux-mmc-owner@vger.kernel.org代发】
Date: Fri, 23 Apr 2021 06:38:22 +0000	[thread overview]
Message-ID: <CWXP265MB2680E0D998AF13C041D18859C4459@CWXP265MB2680.GBRP265.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <35677467-4ccd-9eae-3800-2bc7597cfa0f@rock-chips.com>

Claiming UHS-I support with SDSC is pretty rare, for obvious reasons (namely they are non-standard, so it's a gamble if a host makes use of it), but here you go:
https://de.rs-online.com/web/p/micro-sd-karten/8743910/
(sorry for the german, the site has a en. subpage, but it's certificate seem untrusted.)
The more likely case is that they do not advertise UHS-I to customers,
but the card will show support to the host.
Let's look at this product, just as an example.
https://www.tme.eu/html/EN/goodram-industrial-industrial-sd-sd-micro-memory-cards/ramka_15242_EN_pelny.html
They provide an MLC and pSLC version of each device, with half the capacity naturally.
The 4GB MLC claims UHS-I support, the 2GB pSLC is very likely to be the same controller,
it only claims Class 6.
So either they specifically changed the firmware to remove any UHS support indication,
or, more likely IMO, the card still reports UHS support to the host.
Such a card would benefit from this patch.

Disclaimer: I do not own the product and have not confirmed this device in any way,
but I have seen UHS support on other devices that do not advertise it for their
SDSC versions.
If the mailing list would be interested, I can try to acquire such devices, listed in
public open stores. Modern, potentially UHS supporting cards. are,
as mentioned in the initial Mail, often SLC or pSLC and often are made on
a customers request.


From: Shawn Lin <shawn.lin@rock-chips.com>
Sent: Friday, April 23, 2021 3:34 AM
To: Christian Löhle <CLoehle@hyperstone.com>
Cc: shawn.lin@rock-chips.com <shawn.lin@rock-chips.com>; pali@kernel.org <pali@kernel.org>; huyue2@yulong.com <huyue2@yulong.com>; tiantao6@hisilicon.com <tiantao6@hisilicon.com>; linux-mmc@vger.kernel.org <linux-mmc@vger.kernel.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>; ulf.hansson@linaro.org <ulf.hansson@linaro.org>
Subject: Re: [PATCH] mmc: enable UHS voltage switch for SDSC if supported【请注意,邮件由linux-mmc-owner@vger.kernel.org代发】 
 
On 2021/4/22 21:18, Christian Löhle wrote:
> Ignore the reported capacity if the card otherwise reports UHS support.
> 
> Currently SDSC cards reporting UHS support except for the CCS do not run
> through the voltage switch.
> While strictly speaking a SDSC card cannot support UHS in compliance
> with the standard, there is no good reason to throttle them that way.
> Especially for pSLCs in practice such cards benefit greatly by this patch,

Cduld you provide some more infomation about the SDSC cards which ones 
are labeled as UHS, e.g brand, webpage....

> as they can be new and UHS supporting, but must not lie about their CCS.
> The behaviour of linux-mmc for SDSC is deviating from the standard anyway
> in such a case, as the card is treated as UHS card not supporting the
> voltage switch in general.
> Such a card will come up as
> mmc0: new ultra high speed SDR25 SD card at address 0001.
> Thus the subsystem will support CMD23 and others to the card.
> But if we deviate from the standard anyway, then we might as well
> not throttle SDSC to 25MB/s.
> 
> Signed-off-by: Christian Loehle <cloehle@hyperstone.com>
> ---
>   drivers/mmc/core/sd.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c
> index 6fa51a6ed058..281ca2da8e0b 100644
> --- a/drivers/mmc/core/sd.c
> +++ b/drivers/mmc/core/sd.c
> @@ -841,11 +841,10 @@ int mmc_sd_get_cid(struct mmc_host *host, u32 ocr, u32 *cid, u32 *rocr)
>                return err;
>   
>        /*
> -      * In case CCS and S18A in the response is set, start Signal Voltage
> -      * Switch procedure. SPI mode doesn't support CMD11.
> +      * In case S18A in the response is set, start Signal Voltage Switch
> +      * procedure. SPI mode doesn't support CMD11.
>         */
> -     if (!mmc_host_is_spi(host) && rocr &&
> -        ((*rocr & 0x41000000) == 0x41000000)) {
> +     if (!mmc_host_is_spi(host) && rocr && (*rocr & 0x01000000)) {
>                err = mmc_set_uhs_voltage(host, pocr);
>                if (err == -EAGAIN) {
>                        retries--;
> 


Hyperstone GmbH | Line-Eid-Strasse 3 | 78467 Konstanz
Managing Directors: Dr. Jan Peter Berns.
Commercial register of local courts: Freiburg HRB381782

  reply	other threads:[~2021-04-23  6:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-22 13:18 [PATCH] mmc: enable UHS voltage switch for SDSC if supported Christian Löhle
2021-04-23  1:34 ` [PATCH] mmc: enable UHS voltage switch for SDSC if supported【请注意,邮件由linux-mmc-owner@vger.kernel.org代发】 Shawn Lin
2021-04-23  6:38   ` Christian Löhle [this message]
2021-04-23  6:51     ` Shawn Lin
2021-04-30 10:45 ` [PATCH] mmc: enable UHS voltage switch for SDSC if supported Christian Löhle
2021-05-05 10:09 ` Ulf Hansson
2021-05-05 12:12   ` Christian Löhle
2021-05-05 14:20     ` Ulf Hansson
2021-05-06  8:34       ` Christian Löhle
2021-05-06 13:54         ` Ulf Hansson
2021-05-12 16:03 ` [PATCH v2] " Christian Löhle
2021-06-04 12:10   ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CWXP265MB2680E0D998AF13C041D18859C4459@CWXP265MB2680.GBRP265.PROD.OUTLOOK.COM \
    --to=cloehle@hyperstone.com \
    --cc=huyue2@yulong.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=pali@kernel.org \
    --cc=shawn.lin@rock-chips.com \
    --cc=tiantao6@hisilicon.com \
    --cc=ulf.hansson@linaro.org \
    --subject='Re: [PATCH] mmc: enable UHS voltage switch for SDSC if supported【请注意,邮件由linux-mmc-owner@vger.kernel.org代发】' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).