From: Jolly Shah <JOLLYS@xilinx.com>
To: Rob Herring <robh@kernel.org>
Cc: "matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"andy.gross@linaro.org" <andy.gross@linaro.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"geert+renesas@glider.be" <geert+renesas@glider.be>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"sean.wang@mediatek.com" <sean.wang@mediatek.com>,
"m.szyprowski@samsung.com" <m.szyprowski@samsung.com>,
Michal Simek <michals@xilinx.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
Rajan Vaja <RAJANV@xilinx.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rajan Vaja <RAJANV@xilinx.com>
Subject: RE: [PATCH v2 1/3] dt-bindings: soc: Add ZynqMP PM bindings
Date: Fri, 24 Aug 2018 22:15:13 +0000 [thread overview]
Message-ID: <CY1PR02MB213857834064CF182DA72704B8360@CY1PR02MB2138.namprd02.prod.outlook.com> (raw)
In-Reply-To: <20180820194906.GB26783@bogus>
Hi Rob,
> -----Original Message-----
> From: Rob Herring [mailto:robh@kernel.org]
> Sent: Monday, August 20, 2018 12:49 PM
> To: Jolly Shah <JOLLYS@xilinx.com>
> Cc: matthias.bgg@gmail.com; andy.gross@linaro.org; shawnguo@kernel.org;
> geert+renesas@glider.be; bjorn.andersson@linaro.org;
> sean.wang@mediatek.com; m.szyprowski@samsung.com; Michal Simek
> <michals@xilinx.com>; mark.rutland@arm.com; Rajan Vaja
> <RAJANV@xilinx.com>; devicetree@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Rajan Vaja
> <RAJANV@xilinx.com>; Jolly Shah <JOLLYS@xilinx.com>
> Subject: Re: [PATCH v2 1/3] dt-bindings: soc: Add ZynqMP PM bindings
>
> On Mon, Aug 20, 2018 at 02:40:57PM -0500, Rob Herring wrote:
> > On Thu, Aug 16, 2018 at 12:08:01PM -0700, Jolly Shah wrote:
> > > From: Rajan Vaja <rajan.vaja@xilinx.com>
> > >
> > > Add documentation to describe Xilinx ZynqMP power management
> > > bindings.
> > >
> > > Signed-off-by: Rajan Vaja <rajan.vaja@xilinx.com>
> > > Signed-off-by: Jolly Shah <jollys@xilinx.com>
> > > ---
> > > .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt | 16
> ++++++++++++++++
>
> Also, this should be located in bindings/power/reset/
Base firmware node has clock subnode too. Do you still suggest to move bindings to "bindings/power/reset/" or keep it
under "bindings/firmware" ?
Thanks,
Jolly Shah
>
> > > 1 file changed, 16 insertions(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firm
> > > ware.txt
> > > b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firm
> > > ware.txt
> > > index d215d15..cb9a6b7 100644
> > > ---
> > > a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firm
> > > ware.txt
> > > +++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-
> > > +++ firmware.txt
> > > @@ -64,6 +64,17 @@ Output clocks are registered based on clock
> > > information received from firmware. Output clocks indexes are
> > > mentioned in include/dt-bindings/clock/xlnx,zynqmp-clk.h.
> > >
> > > +-------------------------------------------------------------------
> > > +- Device Tree Bindings for the Xilinx Zynq MPSoC Power Management
> > > +-------------------------------------------------------------------
> > > +- The zynqmp-power node describes the power management
> > > +configurations.
> > > +It will control remote suspend/shutdown interfaces.
> > > +
> > > +Required properties:
> > > + - compatible: Must contain: "xlnx,zynqmp-power"
> > > + - interrupt-parent: Interrupt controller the interrupt is routed through
> >
> > interrupt-parent is implied and could be in a parent node, so remove.
> >
> > With that,
> >
> > Reviewed-by: Rob Herring <robh@kernel.org>
> >
> > > + - interrupts: Interrupt specifier
> > > +
> > > -------
> > > Example
> > > -------
> > > @@ -78,5 +89,10 @@ firmware {
> > > clocks = <&pss_ref_clk>, <&video_clk>,
> <&pss_alt_ref_clk>, <&aux_ref_clk>, <>_crx_ref_clk>;
> > > clock-names = "pss_ref_clk", "video_clk",
> "pss_alt_ref_clk","aux_ref_clk", "gt_crx_ref_clk";
> > > };
> > > + zynqmp_power: zynqmp-power {
> > > + compatible = "xlnx,zynqmp-power";
> > > + interrupt-parent = <&gic>;
> > > + interrupts = <0 35 4>;
> > > + };
> > > };
> > > };
> > > --
> > > 2.7.4
> > >
next prev parent reply other threads:[~2018-08-24 22:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 19:08 [PATCH v2 0/3] drivers: soc: xilinx: Add support for ZynqMP PM driver Jolly Shah
2018-08-16 19:08 ` [PATCH v2 1/3] dt-bindings: soc: Add ZynqMP PM bindings Jolly Shah
2018-08-20 19:40 ` Rob Herring
2018-08-20 19:49 ` Rob Herring
2018-08-24 22:15 ` Jolly Shah [this message]
2018-08-16 19:08 ` [PATCH v2 2/3] firmware: xilinx: Implement ZynqMP power management APIs Jolly Shah
2018-08-16 19:08 ` [PATCH v2 3/3] drivers: soc: xilinx: Add ZynqMP PM driver Jolly Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY1PR02MB213857834064CF182DA72704B8360@CY1PR02MB2138.namprd02.prod.outlook.com \
--to=jollys@xilinx.com \
--cc=RAJANV@xilinx.com \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=michals@xilinx.com \
--cc=robh@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).