From: Hou Zhiqiang <B48286@freescale.com>
To: Michal Suchanek <hramrach@gmail.com>,
Andrew Murray <amurray@embedded-bits.co.uk>
Cc: "Huang Shijie" <shijie.huang@intel.com>,
"David Woodhouse" <dwmw2@infradead.org>,
"Brian Norris" <computersforpeace@gmail.com>,
"Xu Han" <han.xu@freescale.com>,
"Rafa? Mi?ecki" <zajec5@gmail.com>,
"Huang Shijie" <b32955@freescale.com>,
"Ben Hutchings" <ben@decadent.org.uk>,
"Marek Vasut" <marex@denx.de>, "Gabor Juhos" <juhosg@openwrt.org>,
"Bean Huo 霍斌斌," <beanhuo@micron.com>,
"MTD Maling List" <linux-mtd@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v4 7/7] mtd: spi-nor: add read loop
Date: Thu, 5 Nov 2015 03:39:18 +0000 [thread overview]
Message-ID: <CY1PR0301MB0780A9588AA9348DCEA4823F8B290@CY1PR0301MB0780.namprd03.prod.outlook.com> (raw)
In-Reply-To: <CAOMqctQOU91hbt+2O0qQe3tjMn=3pSYE8E4xPpeS3iGG2A5h8w@mail.gmail.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 2134 bytes --]
Hi Michal,
Does this have any updates?
Thanks,
Zhiqiang
> -----Original Message-----
> From: Michal Suchanek [mailto:hramrach@gmail.com]
> Sent: 2015å¹´8æ14æ¥ 18:08
> To: Andrew Murray
> Cc: Hou Zhiqiang-B48286; Huang Shijie; David Woodhouse; Brian Norris; Xu
> Han-B45815; RafaÅ MiÅecki; Huang Shijie; Ben Hutchings; Marek Vasut;
> Gabor Juhos; Bean Huo éææ,; MTD Maling List; LKML
> Subject: Re: [PATCH v4 7/7] mtd: spi-nor: add read loop
>
> On 14 August 2015 at 12:02, Andrew Murray <amurray@embedded-bits.co.uk>
> wrote:
> > On 14 August 2015 at 10:23, Michal Suchanek <hramrach@gmail.com> wrote:
> >> mtdblock and ubi do not handle the situation when read returns less
> >> data than requested. Loop in spi-nor until buffer is filled or an
> >> error is returned.
> >>
> >> Signed-off-by: Michal Suchanek <hramrach@gmail.com>
> >> ---
> >> drivers/mtd/spi-nor/spi-nor.c | 20 ++++++++++++++------
> >> 1 file changed, 14 insertions(+), 6 deletions(-)
> >>
> >> diff --git a/drivers/mtd/spi-nor/spi-nor.c
> >> b/drivers/mtd/spi-nor/spi-nor.c index e0ae9cf..246fac7 100644
> >> --- a/drivers/mtd/spi-nor/spi-nor.c
> >> +++ b/drivers/mtd/spi-nor/spi-nor.c
> >> @@ -738,14 +738,22 @@ static int spi_nor_read(struct mtd_info *mtd,
> loff_t from, size_t len,
> >> if (ret)
> >> return ret;
> >>
> >> - ret = nor->read(nor, from, len, buf);
> >> + while (len) {
> >> + ret = nor->read(nor, from, len, buf);
> >> + if (ret <= 0)
> >> + goto read_err;
> >> +
> >> + BUG_ON(ret > len);
> >> + *retlen += ret;
> >
> > Is *retlen initialized to 0 anywhere?
>
> It's initialized in mtdcore and passed into mtd->_read.
>
> Yes, the interface is really awkward.
>
> int mtd_read(struct mtd_info *mtd, loff_t from, size_t len, size_t
> *retlen,
> u_char *buf)
> {
> int ret_code;
> *retlen = 0;
>
>
> Thanks
>
> Michal
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
next prev parent reply other threads:[~2015-11-05 3:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1439543572.git.hramrach@gmail.com>
[not found] ` <1592668a061137b33c9a6392dfccc67c69fc1fe6.1439543572.git.hramrach@gmail.com>
2015-08-14 10:02 ` [PATCH v4 7/7] mtd: spi-nor: add read loop Andrew Murray
2015-08-14 10:08 ` Michal Suchanek
2015-11-05 3:39 ` Hou Zhiqiang [this message]
2015-11-20 19:18 ` Michal Suchanek
2016-01-12 6:35 ` Zhiqiang Hou
2015-11-19 23:39 ` Brian Norris
2015-11-20 6:26 ` Heiner Kallweit
2015-08-15 1:51 ` [PATCH v4 0/7] Add spi-nor SPI transfer error handling Bean Huo 霍斌斌 (beanhuo)
2015-08-16 10:20 ` Michal Suchanek
[not found] ` <e1251eea4ec9cc8c72d54300f3396919a3afe4b1.1439543572.git.hramrach@gmail.com>
2015-11-19 23:18 ` [PATCH v4 6/7] mtd: spi-nor: simplify write loop Brian Norris
2015-11-20 18:59 ` Michal Suchanek
2015-11-19 23:43 ` [PATCH v4 0/7] Add spi-nor SPI transfer error handling Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY1PR0301MB0780A9588AA9348DCEA4823F8B290@CY1PR0301MB0780.namprd03.prod.outlook.com \
--to=b48286@freescale.com \
--cc=amurray@embedded-bits.co.uk \
--cc=b32955@freescale.com \
--cc=beanhuo@micron.com \
--cc=ben@decadent.org.uk \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=han.xu@freescale.com \
--cc=hramrach@gmail.com \
--cc=juhosg@openwrt.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marex@denx.de \
--cc=shijie.huang@intel.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).