From: Parshuram Raju Thombare <pthombar@cadence.com>
To: Pratyush Yadav <p.yadav@ti.com>
Cc: "broonie@kernel.org" <broonie@kernel.org>,
"lukas@wunner.de" <lukas@wunner.de>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jayshri Dajiram Pawar <jpawar@cadence.com>,
Milind Parab <mparab@cadence.com>,
Konrad Kociolek <konrad@cadence.com>
Subject: RE: [PATCH v3 1/2] spi: cadence: add dt-bindings documentation for Cadence XSPI controller
Date: Wed, 8 Sep 2021 06:52:37 +0000 [thread overview]
Message-ID: <CY4PR07MB2757DF7EFD862D67FBF648CBC1D49@CY4PR07MB2757.namprd07.prod.outlook.com> (raw)
In-Reply-To: <20210903181722.ukarfanyew2b7yoz@ti.com>
>This needs to be a "subclass" of the spi-controller.yaml binding.
>
>allOf:
> - $ref: spi-controller.yaml#
Isn't stating that validation need against spi-controller.yaml as well as
this schema sufficient ? Can you please point an example how to make
controller binding a "subclass" of spi-controller.yaml binding ?
>Node name should be flash@0.
I think spi-controller.yaml uses wildcard for the name of a device node,
so anything in string@hexvalue: should work.
>> + compatible = "spi-nor", "micron,mt35xu512";
>
>These compatibles are arbitrary and undocumented. You probably just need
>"jedec,spi-nor". If you need anything else, you need to justify why.
Although just "spi-nor" also works, I agree to use "jedec, spi-nor" and drop
device name.
Regards,
Parshuram Thombare
next prev parent reply other threads:[~2021-09-08 6:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 12:35 [PATCH v3 0/2] add support for Cadence's XSPI controller Parshuram Thombare
2021-09-01 12:37 ` [PATCH v3 1/2] spi: cadence: add dt-bindings documentation for Cadence " Parshuram Thombare
2021-09-02 12:03 ` Rob Herring
2021-09-03 8:03 ` Parshuram Raju Thombare
2021-09-03 18:17 ` Pratyush Yadav
2021-09-08 6:52 ` Parshuram Raju Thombare [this message]
2021-09-08 11:32 ` Pratyush Yadav
2021-09-08 11:58 ` Parshuram Raju Thombare
2021-09-01 12:37 ` [PATCH v3 2/2] spi: cadence: add support " Parshuram Thombare
2021-09-02 14:39 ` Mark Brown
2021-09-03 8:10 ` Parshuram Raju Thombare
2021-09-03 10:18 ` Mark Brown
2021-09-03 10:47 ` Parshuram Raju Thombare
2021-09-03 11:24 ` Mark Brown
2021-09-03 18:56 ` Pratyush Yadav
2021-09-08 7:27 ` Parshuram Raju Thombare
2021-09-08 11:21 ` Pratyush Yadav
2021-09-08 11:40 ` Parshuram Raju Thombare
2021-09-08 12:24 ` Mark Brown
2021-09-08 16:22 ` Pratyush Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR07MB2757DF7EFD862D67FBF648CBC1D49@CY4PR07MB2757.namprd07.prod.outlook.com \
--to=pthombar@cadence.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jpawar@cadence.com \
--cc=konrad@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mparab@cadence.com \
--cc=p.yadav@ti.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).