From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753743AbdF1CdQ (ORCPT ); Tue, 27 Jun 2017 22:33:16 -0400 Received: from mail-bl2nam02on0043.outbound.protection.outlook.com ([104.47.38.43]:30186 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753080AbdF1CdJ (ORCPT ); Tue, 27 Jun 2017 22:33:09 -0400 From: "Kershner, David A" To: Quytelda Kahja , "gregkh@linuxfoundation.org" CC: "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] Replace the literal function name "visorbus_create_instance" with the format specifier "%s" so it can be dynamically filled by the __func__ macro. Thread-Topic: [PATCH] Replace the literal function name "visorbus_create_instance" with the format specifier "%s" so it can be dynamically filled by the __func__ macro. Thread-Index: AQHS74rrZZuVBrzSz0Syip46iucjXKI5jdBg Date: Wed, 28 Jun 2017 02:33:06 +0000 Message-ID: References: <20170627211746.27519-1-quytelda@tamalin.org> In-Reply-To: <20170627211746.27519-1-quytelda@tamalin.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: tamalin.org; dkim=none (message not signed) header.d=none;tamalin.org; dmarc=none action=none header.from=unisys.com; x-originating-ip: [98.115.244.50] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY4PR07MB3176;7:isaEl0FNMWcHD79taCn/x8HN7UXQ9Svd3ENha4Vc3tkDCJrMYhrKPZNI4FwyAQITpSk8AUwTvYx/wqHempNU6tR09ZCRwG2nM4X/sC0ov0kadBbudgKQpjnEJjU/4JiuHebvxcpP4MIRrLSn67b/DXRSW80OxW7ibOAiHKXnyuu0STyPOn4VGazu06btxBHXhS/LEAozMEhv/aadp5XzEfuEffZHA0sfA6dqMxEEOVSjU/pC953WtxXy3eAZbPjCAaeHDPmDq3BlEzHmWUWriOfiTZd+TrQjqJR33y38b/i7psgYH2nE9Yy+6Abm/+EotO2audsKtQaWYTfTS/YIHtAWIDpbk1HEw/9s+hVqP4elpn1Ff0XVntO7b1SxcXefCotLx1ShmWxlFxz1pxWOiCc1Vsb5R7kLURujkghQ78HGtgSLGQZ1/yc9lqiFECynWLndPx6T1BrAvGseKJTE8TeBFD8krBc1ZGU19kRUTvvQLzr/VtbIyviIzsOFupmtBw/CfGyFOsDrzHOHnUbQA4ketvb81SV8tbToB2DElVzbe+ipe5GzDruOxRTPOR/neE5Ib0P8zuceAshWz62tqBKlBUNtPNNvQVAi+1ug08ylcys0Hoxsx9v7X9XIPmV+7CmBVjwdVKEpymGgg71ndG3rcfincpqbIQT4WxGYAjVuY1uqmfiIohcQ3IBL3LhEsSg5NrxhVg7jPNcYOUeKb+BoGYxpGx3bC29B5rr4Ur8wIZJiinHJsWMqoQsT6CSB7eJNJo7M1Jd4aAt/fPUD2CcJIvX4xLUBo4zreu0OMCI= x-ms-office365-filtering-correlation-id: e01eb9e2-7ef7-4a31-b05e-08d4bdce0262 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254075)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095);SRVR:CY4PR07MB3176; x-ms-traffictypediagnostic: CY4PR07MB3176: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(236129657087228)(9452136761055)(174360191007938)(788757137089); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(3002001)(6041248)(20161123555025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123560025)(20161123562025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY4PR07MB3176;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY4PR07MB3176; x-forefront-prvs: 03524FBD26 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39400400002)(39850400002)(39410400002)(39860400002)(39450400003)(39840400002)(377454003)(13464003)(74316002)(99286003)(2900100001)(66066001)(53936002)(54906002)(305945005)(3660700001)(9686003)(25786009)(6116002)(4326008)(6506006)(38730400002)(86362001)(76176999)(54356999)(189998001)(2501003)(50986999)(6246003)(2906002)(3280700002)(5660300001)(229853002)(7736002)(2950100002)(6436002)(72206003)(7696004)(77096006)(8936002)(478600001)(102836003)(55016002)(53546010)(3846002)(81166006)(33656002)(8676002);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR07MB3176;H:CY4PR07MB3176.namprd07.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: unisys.com X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2017 02:33:06.5767 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 8d894c2b-238f-490b-8dd1-d93898c5bf83 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3176 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v5S2XUqe012973 > -----Original Message----- > From: Quytelda Kahja [mailto:quytelda@tamalin.org] > Sent: Tuesday, June 27, 2017 5:18 PM > To: Kershner, David A ; > gregkh@linuxfoundation.org > Cc: devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org; Quytelda > Kahja > Subject: [PATCH] Replace the literal function name > "visorbus_create_instance" with the format specifier "%s" so it can be > dynamically filled by the __func__ macro. I think the subject line got lost somehow, and should this have been a v2? Subject line should start with staging: unisys: visorbus: preferably. David Kershner > > Signed-off-by: Quytelda Kahja > --- > drivers/staging/unisys/visorbus/visorbus_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c > b/drivers/staging/unisys/visorbus/visorbus_main.c > index 1c785dd19ddd..1c6dc3a3e64a 100644 > --- a/drivers/staging/unisys/visorbus/visorbus_main.c > +++ b/drivers/staging/unisys/visorbus/visorbus_main.c > @@ -1030,7 +1030,7 @@ visorbus_create_instance(struct visor_device > *dev) > err_debugfs_dir: > debugfs_remove_recursive(dev->debugfs_dir); > kfree(hdr_info); > - dev_err(&dev->device, "visorbus_create_instance failed: %d\n", > err); > + dev_err(&dev->device, "%s failed: %d\n", __func__, err); > return err; > } > > -- > 2.13.2